File apache2-mod_auth_openidc-CVE-2025-3891.patch of Package apache2-mod_auth_openidc.38966
Index: mod_auth_openidc-2.3.8/src/authz.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/authz.c
+++ mod_auth_openidc-2.3.8/src/authz.c
@@ -56,6 +56,7 @@
#include <http_protocol.h>
#include "mod_auth_openidc.h"
+#include "const.h"
#include <pcre.h>
@@ -71,7 +72,7 @@ static apr_byte_t oidc_authz_match_value
/* see if it is a string and it (case-insensitively) matches the Require'd value */
if (json_is_string(val)) {
- if (apr_strnatcmp(json_string_value(val), spec_c) == 0)
+ if (_oidc_strcmp(json_string_value(val), spec_c) == 0)
return TRUE;
/* see if it is a integer and it equals the Require'd value */
@@ -83,7 +84,7 @@ static apr_byte_t oidc_authz_match_value
/* see if it is a boolean and it (case-insensitively) matches the Require'd value */
} else if (json_is_boolean(val)) {
- if (apr_strnatcmp(json_is_true(val) ? "true" : "false", spec_c) == 0)
+ if (_oidc_strcmp(json_is_true(val) ? "true" : "false", spec_c) == 0)
return TRUE;
/* if it is an array, we'll walk it */
@@ -100,12 +101,12 @@ static apr_byte_t oidc_authz_match_value
* whitespace). At this point, spec_c points to the
* NULL-terminated value pattern.
*/
- if (apr_strnatcmp(json_string_value(elem), spec_c) == 0)
+ if (_oidc_strcmp(json_string_value(elem), spec_c) == 0)
return TRUE;
} else if (json_is_boolean(elem)) {
- if (apr_strnatcmp(
+ if (_oidc_strcmp(
json_is_true(elem) ? "true" : "false", spec_c) == 0)
return TRUE;
@@ -267,7 +268,7 @@ static apr_byte_t jq_parse(request_rec *
jv dumped = jv_dump_string(result, 0);
const char *str = jv_string_value(dumped);
oidc_debug(r, "dumped: %s", str);
- rv = (apr_strnatcmp(str, "true") == 0);
+ rv = (_oidc_strcmp(str, "true") == 0);
}
jv_free(result);
Index: mod_auth_openidc-2.3.8/src/cache/file.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/cache/file.c
+++ mod_auth_openidc-2.3.8/src/cache/file.c
@@ -60,6 +60,7 @@
#include <http_log.h>
#include "../mod_auth_openidc.h"
+#include "../const.h"
extern module AP_MODULE_DECLARE_DATA auth_openidc_module;
@@ -329,7 +330,7 @@ static apr_status_t oidc_cache_file_clea
/* skip non-cache entries, cq. the ".", ".." and the metadata file */
if ((fi.name[0] == OIDC_CHAR_DOT)
|| (strstr(fi.name, OIDC_CACHE_FILE_PREFIX) != fi.name)
- || ((apr_strnatcmp(fi.name,
+ || ((_oidc_strcmp(fi.name,
oidc_cache_file_name(r, "cache-file",
OIDC_CACHE_FILE_LAST_CLEANED)) == 0)))
continue;
Index: mod_auth_openidc-2.3.8/src/cache/shm.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/cache/shm.c
+++ mod_auth_openidc-2.3.8/src/cache/shm.c
@@ -59,6 +59,7 @@
#include "apr_shm.h"
#include "../mod_auth_openidc.h"
+#include "../const.h"
extern module AP_MODULE_DECLARE_DATA auth_openidc_module;
@@ -194,7 +195,7 @@ static apr_byte_t oidc_cache_shm_get(req
i++, OIDC_CACHE_SHM_ADD_OFFSET(t, cfg->cache_shm_entry_size_max)) {
const char *tablekey = t->section_key;
- if ((tablekey != NULL) && (apr_strnatcmp(tablekey, section_key) == 0)) {
+ if ((tablekey != NULL) && (_oidc_strcmp(tablekey, section_key) == 0)) {
/* found a match, check if it has expired */
if (t->expires > apr_time_now()) {
@@ -280,7 +281,7 @@ static apr_byte_t oidc_cache_shm_set(req
}
/* see if a value already exists for this key */
- if (apr_strnatcmp(t->section_key, section_key) == 0) {
+ if (_oidc_strcmp(t->section_key, section_key) == 0) {
match = t;
break;
}
Index: mod_auth_openidc-2.3.8/src/config.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/config.c
+++ mod_auth_openidc-2.3.8/src/config.c
@@ -65,6 +65,7 @@
#include "mod_auth_openidc.h"
#include "parse.h"
+#include "const.h"
#define OPENSSL_THREAD_DEFINES
#include <openssl/opensslconf.h>
@@ -498,11 +499,11 @@ const char *oidc_parse_pkce_type(apr_poo
if (rv != NULL)
return rv;
- if (apr_strnatcmp(arg, OIDC_PKCE_METHOD_PLAIN) == 0) {
+ if (_oidc_strcmp(arg, OIDC_PKCE_METHOD_PLAIN) == 0) {
*type = &oidc_pkce_plain;
- } else if (apr_strnatcmp(arg, OIDC_PKCE_METHOD_S256) == 0) {
+ } else if (_oidc_strcmp(arg, OIDC_PKCE_METHOD_S256) == 0) {
*type = &oidc_pkce_s256;
- } else if (apr_strnatcmp(arg, OIDC_PKCE_METHOD_REFERRED_TB) == 0) {
+ } else if (_oidc_strcmp(arg, OIDC_PKCE_METHOD_REFERRED_TB) == 0) {
*type = &oidc_pkce_referred_tb;
}
@@ -1258,7 +1259,7 @@ void *oidc_merge_server_config(apr_pool_
add->provider.ssl_validate_server :
base->provider.ssl_validate_server;
c->provider.client_name =
- apr_strnatcmp(add->provider.client_name, OIDC_DEFAULT_CLIENT_NAME)
+ _oidc_strcmp(add->provider.client_name, OIDC_DEFAULT_CLIENT_NAME)
!= 0 ?
add->provider.client_name : base->provider.client_name;
c->provider.client_contact =
@@ -1270,10 +1271,10 @@ void *oidc_merge_server_config(apr_pool_
add->provider.registration_token :
base->provider.registration_token;
c->provider.scope =
- apr_strnatcmp(add->provider.scope, OIDC_DEFAULT_SCOPE) != 0 ?
+ _oidc_strcmp(add->provider.scope, OIDC_DEFAULT_SCOPE) != 0 ?
add->provider.scope : base->provider.scope;
c->provider.response_type =
- apr_strnatcmp(add->provider.response_type,
+ _oidc_strcmp(add->provider.response_type,
OIDC_DEFAULT_RESPONSE_TYPE) != 0 ?
add->provider.response_type : base->provider.response_type;
c->provider.response_mode =
@@ -1368,7 +1369,7 @@ void *oidc_merge_server_config(apr_pool_
add->oauth.introspection_endpoint_url :
base->oauth.introspection_endpoint_url;
c->oauth.introspection_endpoint_method =
- apr_strnatcmp(add->oauth.introspection_endpoint_method,
+ _oidc_strcmp(add->oauth.introspection_endpoint_method,
OIDC_DEFAULT_OAUTH_ENDPOINT_METHOD) != 0 ?
add->oauth.introspection_endpoint_method :
base->oauth.introspection_endpoint_method;
@@ -1385,18 +1386,18 @@ void *oidc_merge_server_config(apr_pool_
add->oauth.introspection_client_auth_bearer_token :
base->oauth.introspection_client_auth_bearer_token;
c->oauth.introspection_token_param_name =
- apr_strnatcmp(add->oauth.introspection_token_param_name,
+ _oidc_strcmp(add->oauth.introspection_token_param_name,
OIDC_DEFAULT_OAUTH_TOKEN_PARAM_NAME) != 0 ?
add->oauth.introspection_token_param_name :
base->oauth.introspection_token_param_name;
c->oauth.introspection_token_expiry_claim_name =
- apr_strnatcmp(add->oauth.introspection_token_expiry_claim_name,
+ _oidc_strcmp(add->oauth.introspection_token_expiry_claim_name,
OIDC_DEFAULT_OAUTH_EXPIRY_CLAIM_NAME) != 0 ?
add->oauth.introspection_token_expiry_claim_name :
base->oauth.introspection_token_expiry_claim_name;
c->oauth.introspection_token_expiry_claim_format =
- apr_strnatcmp(add->oauth.introspection_token_expiry_claim_format,
+ _oidc_strcmp(add->oauth.introspection_token_expiry_claim_format,
OIDC_DEFAULT_OAUTH_EXPIRY_CLAIM_FORMAT) != 0 ?
add->oauth.introspection_token_expiry_claim_format :
base->oauth.introspection_token_expiry_claim_format;
@@ -1407,7 +1408,7 @@ void *oidc_merge_server_config(apr_pool_
base->oauth.introspection_token_expiry_claim_required;
c->oauth.remote_user_claim.claim_name =
- apr_strnatcmp(add->oauth.remote_user_claim.claim_name,
+ _oidc_strcmp(add->oauth.remote_user_claim.claim_name,
OIDC_DEFAULT_OAUTH_CLAIM_REMOTE_USER) != 0 ?
add->oauth.remote_user_claim.claim_name :
base->oauth.remote_user_claim.claim_name;
@@ -1516,12 +1517,12 @@ void *oidc_merge_server_config(apr_pool_
add->cookie_domain != NULL ?
add->cookie_domain : base->cookie_domain;
c->claim_delimiter =
- apr_strnatcmp(add->claim_delimiter, OIDC_DEFAULT_CLAIM_DELIMITER)
+ _oidc_strcmp(add->claim_delimiter, OIDC_DEFAULT_CLAIM_DELIMITER)
!= 0 ? add->claim_delimiter : base->claim_delimiter;
c->claim_prefix =
add->claim_prefix != NULL ? add->claim_prefix : base->claim_prefix;
c->remote_user_claim.claim_name =
- apr_strnatcmp(add->remote_user_claim.claim_name,
+ _oidc_strcmp(add->remote_user_claim.claim_name,
OIDC_DEFAULT_CLAIM_REMOTE_USER) != 0 ?
add->remote_user_claim.claim_name :
base->remote_user_claim.claim_name;
@@ -1647,7 +1648,7 @@ void *oidc_create_dir_config(apr_pool_t
char *oidc_cfg_dir_discover_url(request_rec *r) {
oidc_dir_cfg *dir_cfg = ap_get_module_config(r->per_dir_config,
&auth_openidc_module);
- if ((dir_cfg->discover_url != NULL) && (apr_strnatcmp(dir_cfg->discover_url,
+ if ((dir_cfg->discover_url != NULL) && (_oidc_strcmp(dir_cfg->discover_url,
OIDC_CONFIG_STRING_UNSET) == 0))
return NULL;
return dir_cfg->discover_url;
@@ -1658,7 +1659,7 @@ char *oidc_cfg_dir_cookie(request_rec *r
&auth_openidc_module);
if ((dir_cfg->cookie == NULL)
|| ((dir_cfg->cookie != NULL)
- && (apr_strnatcmp(dir_cfg->cookie, OIDC_CONFIG_STRING_UNSET)
+ && (_oidc_strcmp(dir_cfg->cookie, OIDC_CONFIG_STRING_UNSET)
== 0)))
return OIDC_DEFAULT_COOKIE;
return dir_cfg->cookie;
@@ -1669,7 +1670,7 @@ char *oidc_cfg_dir_cookie_path(request_r
&auth_openidc_module);
if ((dir_cfg->cookie_path == NULL)
|| ((dir_cfg->cookie_path != NULL)
- && (apr_strnatcmp(dir_cfg->cookie_path,
+ && (_oidc_strcmp(dir_cfg->cookie_path,
OIDC_CONFIG_STRING_UNSET) == 0)))
return OIDC_DEFAULT_COOKIE_PATH;
return dir_cfg->cookie_path;
@@ -1680,7 +1681,7 @@ char *oidc_cfg_dir_authn_header(request_
&auth_openidc_module);
if ((dir_cfg->authn_header == NULL)
|| ((dir_cfg->authn_header != NULL)
- && (apr_strnatcmp(dir_cfg->authn_header,
+ && (_oidc_strcmp(dir_cfg->authn_header,
OIDC_CONFIG_STRING_UNSET) == 0)))
return OIDC_DEFAULT_AUTHN_HEADER;
return dir_cfg->authn_header;
@@ -1789,16 +1790,16 @@ void *oidc_merge_dir_config(apr_pool_t *
oidc_dir_cfg *base = BASE;
oidc_dir_cfg *add = ADD;
c->discover_url =
- (apr_strnatcmp(add->discover_url, OIDC_CONFIG_STRING_UNSET) != 0) ?
+ (_oidc_strcmp(add->discover_url, OIDC_CONFIG_STRING_UNSET) != 0) ?
add->discover_url : base->discover_url;
c->cookie =
- (apr_strnatcmp(add->cookie, OIDC_CONFIG_STRING_UNSET) != 0) ?
+ (_oidc_strcmp(add->cookie, OIDC_CONFIG_STRING_UNSET) != 0) ?
add->cookie : base->cookie;
c->cookie_path =
- (apr_strnatcmp(add->cookie_path, OIDC_CONFIG_STRING_UNSET) != 0) ?
+ (_oidc_strcmp(add->cookie_path, OIDC_CONFIG_STRING_UNSET) != 0) ?
add->cookie_path : base->cookie_path;
c->authn_header =
- (apr_strnatcmp(add->authn_header, OIDC_CONFIG_STRING_UNSET) != 0) ?
+ (_oidc_strcmp(add->authn_header, OIDC_CONFIG_STRING_UNSET) != 0) ?
add->authn_header : base->authn_header;
c->unauth_action =
add->unauth_action != OIDC_CONFIG_POS_INT_UNSET ?
@@ -1886,7 +1887,7 @@ static int oidc_check_config_openid_open
} else {
apr_uri_parse(s->process->pconf, c->provider.metadata_url, &r_uri);
if ((r_uri.scheme == NULL)
- || (apr_strnatcmp(r_uri.scheme, "https") != 0)) {
+ || (_oidc_strcmp(r_uri.scheme, "https") != 0)) {
oidc_swarn(s,
"the URL scheme (%s) of the configured " OIDCProviderMetadataURL " SHOULD be \"https\" for security reasons!",
r_uri.scheme);
@@ -1904,7 +1905,7 @@ static int oidc_check_config_openid_open
apr_uri_parse(s->process->pconf, c->redirect_uri, &r_uri);
if (!redirect_uri_is_relative) {
- if (apr_strnatcmp(r_uri.scheme, "https") != 0) {
+ if (_oidc_strcmp(r_uri.scheme, "https") != 0) {
oidc_swarn(s,
"the URL scheme (%s) of the configured " OIDCRedirectURI " SHOULD be \"https\" for security reasons (moreover: some Providers may reject non-HTTPS URLs)",
r_uri.scheme);
@@ -1937,7 +1938,7 @@ static int oidc_check_config_oauth(serve
if (c->oauth.metadata_url != NULL) {
apr_uri_parse(s->process->pconf, c->oauth.metadata_url, &r_uri);
if ((r_uri.scheme == NULL)
- || (apr_strnatcmp(r_uri.scheme, "https") != 0)) {
+ || (_oidc_strcmp(r_uri.scheme, "https") != 0)) {
oidc_swarn(s,
"the URL scheme (%s) of the configured " OIDCOAuthServerMetadataURL " SHOULD be \"https\" for security reasons!",
r_uri.scheme);
Index: mod_auth_openidc-2.3.8/src/jose.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/jose.c
+++ mod_auth_openidc-2.3.8/src/jose.c
@@ -54,6 +54,7 @@
#include <apr_base64.h>
#include "jose.h"
+#include "const.h"
#include <openssl/evp.h>
#include <openssl/hmac.h>
@@ -127,7 +128,7 @@ char *oidc_jwt_serialize(apr_pool_t *poo
oidc_jose_error_t *err) {
cjose_err cjose_err;
const char *cser = NULL;
- if (strcmp(jwt->header.alg, CJOSE_HDR_ALG_NONE) != 0) {
+ if (_oidc_strcmp(jwt->header.alg, CJOSE_HDR_ALG_NONE) != 0) {
if (cjose_jws_export(jwt->cjose_jws, &cser, &cjose_err) == FALSE) {
oidc_jose_error(err, "cjose_jws_export failed: %s",
oidc_cjose_e2s(pool, cjose_err));
@@ -157,24 +158,24 @@ char *oidc_jwt_serialize(apr_pool_t *poo
* return the key type for an algorithm
*/
static int oidc_alg2kty(const char *alg) {
- if (strcmp(alg, CJOSE_HDR_ALG_DIR) == 0)
+ if (_oidc_strcmp(alg, CJOSE_HDR_ALG_DIR) == 0)
return CJOSE_JWK_KTY_OCT;
- if (strncmp(alg, "RS", 2) == 0)
+ if (_oidc_strncmp(alg, "RS", 2) == 0)
return CJOSE_JWK_KTY_RSA;
- if (strncmp(alg, "PS", 2) == 0)
+ if (_oidc_strncmp(alg, "PS", 2) == 0)
return CJOSE_JWK_KTY_RSA;
- if (strncmp(alg, "HS", 2) == 0)
+ if (_oidc_strncmp(alg, "HS", 2) == 0)
return CJOSE_JWK_KTY_OCT;
#if (OIDC_JOSE_EC_SUPPORT)
- if (strncmp(alg, "ES", 2) == 0)
+ if (_oidc_strncmp(alg, "ES", 2) == 0)
return CJOSE_JWK_KTY_EC;
#endif
- if ((strcmp(alg, CJOSE_HDR_ALG_A128KW) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_A192KW) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_A256KW) == 0))
+ if ((_oidc_strcmp(alg, CJOSE_HDR_ALG_A128KW) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_A192KW) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_A256KW) == 0))
return CJOSE_JWK_KTY_OCT;
- if ((strcmp(alg, CJOSE_HDR_ALG_RSA1_5) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_RSA_OAEP) == 0))
+ if ((_oidc_strcmp(alg, CJOSE_HDR_ALG_RSA1_5) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_RSA_OAEP) == 0))
return CJOSE_JWK_KTY_RSA;
return -1;
}
@@ -194,24 +195,24 @@ unsigned int oidc_alg2keysize(const char
if (alg == NULL)
return 0;
- if (strcmp(alg, CJOSE_HDR_ALG_A128KW) == 0)
+ if (_oidc_strcmp(alg, CJOSE_HDR_ALG_A128KW) == 0)
return 16;
- if (strcmp(alg, CJOSE_HDR_ALG_A192KW) == 0)
+ if (_oidc_strcmp(alg, CJOSE_HDR_ALG_A192KW) == 0)
return 24;
- if (strcmp(alg, CJOSE_HDR_ALG_A256KW) == 0)
+ if (_oidc_strcmp(alg, CJOSE_HDR_ALG_A256KW) == 0)
return 32;
- if ((strcmp(alg, CJOSE_HDR_ALG_RS256) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_PS256) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_HS256) == 0))
+ if ((_oidc_strcmp(alg, CJOSE_HDR_ALG_RS256) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_PS256) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_HS256) == 0))
return 32;
- if ((strcmp(alg, CJOSE_HDR_ALG_RS384) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_PS384) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_HS384) == 0))
+ if ((_oidc_strcmp(alg, CJOSE_HDR_ALG_RS384) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_PS384) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_HS384) == 0))
return 48;
- if ((strcmp(alg, CJOSE_HDR_ALG_RS512) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_PS512) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_HS512) == 0))
+ if ((_oidc_strcmp(alg, CJOSE_HDR_ALG_RS512) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_PS512) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_HS512) == 0))
return 64;
return 0;
@@ -256,7 +257,7 @@ static cjose_jwk_t *oidc_jwk_parse_rsa_x
goto end;
}
- if (apr_strnatcmp(kty, OIDC_JOSE_HDR_KTY_RSA) != 0) {
+ if (_oidc_strcmp(kty, OIDC_JOSE_HDR_KTY_RSA) != 0) {
oidc_jose_error(err,
"no \"" OIDC_JOSE_HDR_KTY_RSA "\" key type found JWK JSON value");
goto end;
@@ -460,7 +461,7 @@ static apr_byte_t oidc_jose_array_has_st
const char *needle) {
int i = 0;
while (i < haystack->nelts) {
- if (apr_strnatcmp(((const char**) haystack->elts)[i], needle) == 0)
+ if (_oidc_strcmp(((const char**) haystack->elts)[i], needle) == 0)
return TRUE;
i++;
}
@@ -1004,22 +1005,22 @@ apr_byte_t oidc_jose_hash_bytes(apr_pool
* return the OpenSSL hash algorithm associated with a specified JWT algorithm
*/
static char *oidc_jose_alg_to_openssl_digest(const char *alg) {
- if ((strcmp(alg, CJOSE_HDR_ALG_RS256) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_PS256) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_HS256) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_ES256) == 0)) {
+ if ((_oidc_strcmp(alg, CJOSE_HDR_ALG_RS256) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_PS256) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_HS256) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_ES256) == 0)) {
return LN_sha256;
}
- if ((strcmp(alg, CJOSE_HDR_ALG_RS384) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_PS384) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_HS384) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_ES384) == 0)) {
+ if ((_oidc_strcmp(alg, CJOSE_HDR_ALG_RS384) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_PS384) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_HS384) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_ES384) == 0)) {
return LN_sha384;
}
- if ((strcmp(alg, CJOSE_HDR_ALG_RS512) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_PS512) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_HS512) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_ES512) == 0)) {
+ if ((_oidc_strcmp(alg, CJOSE_HDR_ALG_RS512) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_PS512) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_HS512) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_ES512) == 0)) {
return LN_sha512;
}
return NULL;
@@ -1048,22 +1049,22 @@ apr_byte_t oidc_jose_hash_string(apr_poo
* return hash length
*/
int oidc_jose_hash_length(const char *alg) {
- if ((strcmp(alg, CJOSE_HDR_ALG_RS256) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_PS256) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_HS256) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_ES256) == 0)) {
+ if ((_oidc_strcmp(alg, CJOSE_HDR_ALG_RS256) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_PS256) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_HS256) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_ES256) == 0)) {
return 32;
}
- if ((strcmp(alg, CJOSE_HDR_ALG_RS384) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_PS384) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_HS384) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_ES384) == 0)) {
+ if ((_oidc_strcmp(alg, CJOSE_HDR_ALG_RS384) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_PS384) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_HS384) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_ES384) == 0)) {
return 48;
}
- if ((strcmp(alg, CJOSE_HDR_ALG_RS512) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_PS512) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_HS512) == 0)
- || (strcmp(alg, CJOSE_HDR_ALG_ES512) == 0)) {
+ if ((_oidc_strcmp(alg, CJOSE_HDR_ALG_RS512) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_PS512) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_HS512) == 0)
+ || (_oidc_strcmp(alg, CJOSE_HDR_ALG_ES512) == 0)) {
return 64;
}
return 0;
Index: mod_auth_openidc-2.3.8/src/metadata.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/metadata.c
+++ mod_auth_openidc-2.3.8/src/metadata.c
@@ -61,6 +61,7 @@
#include "mod_auth_openidc.h"
#include "parse.h"
+#include "const.h"
extern module AP_MODULE_DECLARE_DATA auth_openidc_module;
@@ -884,7 +885,7 @@ apr_byte_t oidc_metadata_list(request_re
/* skip other non-provider entries */
char *ext = strrchr(fi.name, OIDC_CHAR_DOT);
if ((ext == NULL)
- || (strcmp(++ext, OIDC_METADATA_SUFFIX_PROVIDER) != 0))
+ || (_oidc_strcmp(++ext, OIDC_METADATA_SUFFIX_PROVIDER) != 0))
continue;
/* get the issuer from the filename */
Index: mod_auth_openidc-2.3.8/src/mod_auth_openidc.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/mod_auth_openidc.c
+++ mod_auth_openidc-2.3.8/src/mod_auth_openidc.c
@@ -73,6 +73,7 @@
#include "http_request.h"
#include "mod_auth_openidc.h"
+#include "const.h"
// TODO:
// - sort out oidc_cfg vs. oidc_dir_cfg stuff
@@ -145,7 +146,7 @@ void oidc_scrub_headers(request_rec *r)
const char *prefix = oidc_cfg_claim_prefix(r);
apr_hash_t *hdrs = apr_hash_make(r->pool);
- if (apr_strnatcmp(prefix, "") == 0) {
+ if (_oidc_strcmp(prefix, "") == 0) {
if ((cfg->white_listed_claims != NULL)
&& (apr_hash_count(cfg->white_listed_claims) > 0))
hdrs = apr_hash_overlay(r->pool, cfg->white_listed_claims,
@@ -204,7 +205,7 @@ void oidc_strip_cookies(request_rec *r)
for (i = 0; i < strip->nelts; i++) {
name = ((const char**) strip->elts)[i];
- if ((strncmp(cookie, name, strlen(name)) == 0)
+ if ((_oidc_strncmp(cookie, name, strlen(name)) == 0)
&& (cookie[strlen(name)] == OIDC_CHAR_EQUAL)) {
oidc_debug(r, "stripping: %s", name);
break;
@@ -413,7 +414,7 @@ static const char *oidc_original_request
return OIDC_METHOD_GET;
const char *content_type = oidc_util_hdr_in_content_type_get(r);
- if ((r->method_number == M_POST) && (apr_strnatcmp(content_type,
+ if ((r->method_number == M_POST) && (_oidc_strcmp(content_type,
OIDC_CONTENT_TYPE_FORM_ENCODED) == 0))
method = OIDC_METHOD_FORM_POST;
}
@@ -439,7 +440,7 @@ apr_byte_t oidc_post_preserve_javascript
const char *method = oidc_original_request_method(r, cfg, FALSE);
- if (apr_strnatcmp(method, OIDC_METHOD_FORM_POST) != 0)
+ if (_oidc_strcmp(method, OIDC_METHOD_FORM_POST) != 0)
return FALSE;
/* read the parameters that are POST-ed to us */
@@ -590,7 +591,7 @@ static apr_byte_t oidc_unsolicited_proto
return FALSE;
}
- if (apr_strnatcmp(rfp, OIDC_PROTO_ISS) != 0) {
+ if (_oidc_strcmp(rfp, OIDC_PROTO_ISS) != 0) {
oidc_error(r, "\"%s\" (%s) does not match \"%s\", aborting",
OIDC_CLAIM_RFP, rfp, OIDC_PROTO_ISS);
oidc_jwt_destroy(jwt);
@@ -712,7 +713,7 @@ static int oidc_clean_expired_state_cook
*cookie = '\0';
cookie++;
if ((currentCookieName == NULL)
- || (apr_strnatcmp(cookieName, currentCookieName)
+ || (_oidc_strcmp(cookieName, currentCookieName)
!= 0)) {
oidc_proto_state_t *proto_state =
oidc_proto_state_from_cookie(r, c, cookie);
@@ -770,7 +771,7 @@ static apr_byte_t oidc_restore_proto_sta
/* calculate the hash of the browser fingerprint concatenated with the nonce */
char *calc = oidc_get_browser_state_hash(r, nonce);
/* compare the calculated hash with the value provided in the authorization response */
- if (apr_strnatcmp(calc, state) != 0) {
+ if (_oidc_strcmp(calc, state) != 0) {
oidc_error(r,
"calculated state from cookie does not match state parameter passed back in URL: \"%s\" != \"%s\"",
state, calc);
@@ -1057,7 +1058,7 @@ static apr_byte_t oidc_check_cookie_doma
cfg->cookie_domain : oidc_get_current_url_host(r);
const char *s_cookie_domain = oidc_session_get_cookie_domain(r, session);
if ((s_cookie_domain == NULL)
- || (apr_strnatcmp(c_cookie_domain, s_cookie_domain) != 0)) {
+ || (_oidc_strcmp(c_cookie_domain, s_cookie_domain) != 0)) {
oidc_warn(r,
"aborting: detected attempt to play cookie against a different domain/host than issued for! (issued=%s, current=%s)",
s_cookie_domain, c_cookie_domain);
@@ -1534,7 +1535,7 @@ static apr_byte_t oidc_authorization_res
oidc_debug(r, "enter (state=%s)", state);
- if ((state == NULL) || (apr_strnatcmp(state, "") == 0)) {
+ if ((state == NULL) || (_oidc_strcmp(state, "") == 0)) {
oidc_error(r, "state parameter is not set");
return FALSE;
}
@@ -1579,7 +1580,7 @@ static int oidc_authorization_response_e
prompt = apr_pstrdup(r->pool, prompt);
oidc_proto_state_destroy(proto_state);
if ((prompt != NULL)
- && (apr_strnatcmp(prompt, OIDC_PROTO_PROMPT_NONE) == 0)) {
+ && (_oidc_strcmp(prompt, OIDC_PROTO_PROMPT_NONE) == 0)) {
return oidc_session_redirect_parent_window_to_logout(r, c);
}
return oidc_util_html_send_error(r, c->error_template,
@@ -1868,7 +1869,7 @@ static apr_byte_t oidc_handle_browser_ba
o_url = oidc_session_get_original_url(r, session);
if ((r_state != NULL) && (s_state != NULL)
- && (apr_strnatcmp(r_state, s_state) == 0)) {
+ && (_oidc_strcmp(r_state, s_state) == 0)) {
/* log the browser back event detection */
oidc_warn(r,
@@ -1964,12 +1965,12 @@ static int oidc_handle_authorization_res
/* session management: if the user in the new response is not equal to the old one, error out */
if ((prompt != NULL)
- && (apr_strnatcmp(prompt, OIDC_PROTO_PROMPT_NONE) == 0)) {
+ && (_oidc_strcmp(prompt, OIDC_PROTO_PROMPT_NONE) == 0)) {
// TOOD: actually need to compare sub? (need to store it in the session separately then
//const char *sub = NULL;
//oidc_session_get(r, session, "sub", &sub);
- //if (apr_strnatcmp(sub, jwt->payload.sub) != 0) {
- if (apr_strnatcmp(session->remote_user, r->user) != 0) {
+ //if (_oidc_strcmp(sub, jwt->payload.sub) != 0) {
+ if (_oidc_strcmp(session->remote_user, r->user) != 0) {
oidc_warn(r,
"user set from new id_token is different from current one");
oidc_jwt_destroy(jwt);
@@ -2009,7 +2010,7 @@ static int oidc_handle_authorization_res
original_url, original_method);
/* check whether form post data was preserved; if so restore it */
- if (apr_strnatcmp(original_method, OIDC_METHOD_FORM_POST) == 0) {
+ if (_oidc_strcmp(original_method, OIDC_METHOD_FORM_POST) == 0) {
return oidc_request_post_preserved_restore(r, original_url);
}
@@ -2042,7 +2043,7 @@ static int oidc_handle_post_authorizatio
if ((apr_table_elts(params)->nelts < 1)
|| ((apr_table_elts(params)->nelts == 1)
&& apr_table_get(params, OIDC_PROTO_RESPONSE_MODE)
- && (apr_strnatcmp(
+ && (_oidc_strcmp(
apr_table_get(params, OIDC_PROTO_RESPONSE_MODE),
OIDC_PROTO_RESPONSE_MODE_FRAGMENT) == 0))) {
return oidc_util_html_send_error(r, c->error_template,
@@ -2313,8 +2314,8 @@ static int oidc_authenticate_user(reques
memset(&r_uri, 0, sizeof(apr_uri_t));
apr_uri_parse(r->pool, original_url, &o_uri);
apr_uri_parse(r->pool, oidc_get_redirect_uri(r, c), &r_uri);
- if ((apr_strnatcmp(o_uri.scheme, r_uri.scheme) != 0)
- && (apr_strnatcmp(r_uri.scheme, "https") == 0)) {
+ if ((_oidc_strcmp(o_uri.scheme, r_uri.scheme) != 0)
+ && (_oidc_strcmp(r_uri.scheme, "https") == 0)) {
oidc_error(r,
"the URL scheme (%s) of the configured " OIDCRedirectURI " does not match the URL scheme of the URL being accessed (%s): the \"state\" and \"session\" cookies will not be shared between the two!",
r_uri.scheme, o_uri.scheme);
@@ -2323,9 +2324,9 @@ static int oidc_authenticate_user(reques
}
if (c->cookie_domain == NULL) {
- if (apr_strnatcmp(o_uri.hostname, r_uri.hostname) != 0) {
+ if (_oidc_strcmp(o_uri.hostname, r_uri.hostname) != 0) {
char *p = strstr(o_uri.hostname, r_uri.hostname);
- if ((p == NULL) || (apr_strnatcmp(r_uri.hostname, p) != 0)) {
+ if ((p == NULL) || (_oidc_strcmp(r_uri.hostname, p) != 0)) {
oidc_error(r,
"the URL hostname (%s) of the configured " OIDCRedirectURI " does not match the URL hostname of the URL being accessed (%s): the \"state\" and \"session\" cookies will not be shared between the two!",
r_uri.hostname, o_uri.hostname);
@@ -2370,9 +2371,9 @@ static int oidc_target_link_uri_matches_
if (cfg->cookie_domain == NULL) {
/* cookie_domain set: see if the target_link_uri matches the redirect_uri host (because the session cookie will be set host-wide) */
- if (apr_strnatcmp(o_uri.hostname, r_uri.hostname) != 0) {
+ if (_oidc_strcmp(o_uri.hostname, r_uri.hostname) != 0) {
char *p = strstr(o_uri.hostname, r_uri.hostname);
- if ((p == NULL) || (apr_strnatcmp(r_uri.hostname, p) != 0)) {
+ if ((p == NULL) || (_oidc_strcmp(r_uri.hostname, p) != 0)) {
oidc_error(r,
"the URL hostname (%s) of the configured " OIDCRedirectURI " does not match the URL hostname of the \"target_link_uri\" (%s): aborting to prevent an open redirect.",
r_uri.hostname, o_uri.hostname);
@@ -2382,7 +2383,7 @@ static int oidc_target_link_uri_matches_
} else {
/* cookie_domain set: see if the target_link_uri is within the cookie_domain */
char *p = strstr(o_uri.hostname, cfg->cookie_domain);
- if ((p == NULL) || (apr_strnatcmp(cfg->cookie_domain, p) != 0)) {
+ if ((p == NULL) || (_oidc_strcmp(cfg->cookie_domain, p) != 0)) {
oidc_error(r,
"the domain (%s) configured in " OIDCCookieDomain " does not match the URL hostname (%s) of the \"target_link_uri\" (%s): aborting to prevent an open redirect.",
cfg->cookie_domain, o_uri.hostname, target_link_uri);
@@ -2532,7 +2533,7 @@ static int oidc_handle_discovery_respons
/* compare CSRF cookie value with query parameter value */
if ((csrf_query == NULL)
- || apr_strnatcmp(csrf_query, csrf_cookie) != 0) {
+ || _oidc_strcmp(csrf_query, csrf_cookie) != 0) {
oidc_warn(r,
"CSRF protection failed, no Discovery and dynamic client registration will be allowed");
csrf_cookie = NULL;
@@ -2576,7 +2577,7 @@ static int oidc_handle_discovery_respons
if (c->metadata_dir == NULL) {
if ((oidc_provider_static_config(r, c, &provider) == TRUE)
&& (issuer != NULL)) {
- if (apr_strnatcmp(provider->issuer, issuer) != 0) {
+ if (_oidc_strcmp(provider->issuer, issuer) != 0) {
return oidc_util_html_send_error(r, c->error_template,
"Invalid Request",
apr_psprintf(r->pool,
@@ -2660,9 +2661,9 @@ static apr_uint32_t oidc_transparent_pix
static apr_byte_t oidc_is_front_channel_logout(const char *logout_param_value) {
return ((logout_param_value != NULL)
- && ((apr_strnatcmp(logout_param_value,
+ && ((_oidc_strcmp(logout_param_value,
OIDC_GET_STYLE_LOGOUT_PARAM_VALUE) == 0)
- || (apr_strnatcmp(logout_param_value,
+ || (_oidc_strcmp(logout_param_value,
OIDC_IMG_STYLE_LOGOUT_PARAM_VALUE) == 0)));
}
@@ -2694,7 +2695,7 @@ static int oidc_handle_logout_request(re
/* see if this is PF-PA style logout in which case we return a transparent pixel */
const char *accept = oidc_util_hdr_in_accept_get(r);
- if ((apr_strnatcmp(url, OIDC_IMG_STYLE_LOGOUT_PARAM_VALUE) == 0)
+ if ((_oidc_strcmp(url, OIDC_IMG_STYLE_LOGOUT_PARAM_VALUE) == 0)
|| ((accept) && strstr(accept, OIDC_CONTENT_TYPE_IMAGE_PNG))) {
return oidc_util_http_send(r,
(const char *) &oidc_transparent_pixel,
@@ -2737,7 +2738,7 @@ static int oidc_handle_logout(request_re
return oidc_handle_logout_request(r, c, session, url);
}
- if ((url == NULL) || (apr_strnatcmp(url, "") == 0)) {
+ if ((url == NULL) || (_oidc_strcmp(url, "") == 0)) {
url = c->default_slo_url;
@@ -2926,14 +2927,14 @@ static int oidc_handle_session_managemen
}
/* see if this is a local logout during session management */
- if (apr_strnatcmp("logout", cmd) == 0) {
+ if (_oidc_strcmp("logout", cmd) == 0) {
oidc_debug(r,
"[session=logout] calling oidc_handle_logout_request because of session mgmt local logout call.");
return oidc_handle_logout_request(r, c, session, c->default_slo_url);
}
/* see if this is a request for the OP iframe */
- if (apr_strnatcmp("iframe_op", cmd) == 0) {
+ if (_oidc_strcmp("iframe_op", cmd) == 0) {
check_session_iframe = oidc_session_get_check_session_iframe(r,
session);
if (check_session_iframe != NULL) {
@@ -2944,7 +2945,7 @@ static int oidc_handle_session_managemen
}
/* see if this is a request for the RP iframe */
- if (apr_strnatcmp("iframe_rp", cmd) == 0) {
+ if (_oidc_strcmp("iframe_rp", cmd) == 0) {
client_id = oidc_session_get_client_id(r, session);
check_session_iframe = oidc_session_get_check_session_iframe(r,
session);
@@ -2959,7 +2960,7 @@ static int oidc_handle_session_managemen
}
/* see if this is a request check the login state with the OP */
- if (apr_strnatcmp("check", cmd) == 0) {
+ if (_oidc_strcmp("check", cmd) == 0) {
id_token_hint = oidc_session_get_idtoken(r, session);
oidc_get_provider_from_session(r, c, session, &provider);
if ((session->remote_user != NULL) && (provider != NULL)) {
@@ -3037,7 +3038,7 @@ static int oidc_handle_refresh_token_req
}
/* compare the access_token parameter used for XSRF protection */
- if (apr_strnatcmp(s_access_token, r_access_token) != 0) {
+ if (_oidc_strcmp(s_access_token, r_access_token) != 0) {
oidc_error(r,
"access_token passed in refresh request does not match the one stored in the session");
error_code = "no_access_token_match";
@@ -3142,7 +3143,7 @@ static int oidc_handle_info_request(requ
OIDC_INFO_PARAM_ACCESS_TOKEN_REFRESH_INTERVAL, &s_interval);
/* see if this is a request for a format that is supported */
- if (apr_strnatcmp(OIDC_HOOK_INFO_FORMAT_JSON, s_format) != 0) {
+ if (_oidc_strcmp(OIDC_HOOK_INFO_FORMAT_JSON, s_format) != 0) {
oidc_warn(r, "request for unknown format: %s", s_format);
return HTTP_UNSUPPORTED_MEDIA_TYPE;
}
@@ -3354,7 +3355,7 @@ int oidc_handle_redirect_uri_request(req
/* set remote user, set headers/env-vars, update expiry, update userinfo + AT */
return oidc_handle_existing_session(r, c, session);
- } else if ((r->args == NULL) || (apr_strnatcmp(r->args, "") == 0)) {
+ } else if ((r->args == NULL) || (_oidc_strcmp(r->args, "") == 0)) {
/* this is a "bare" request to the redirect URI, indicating implicit flow using the fragment response_mode */
return oidc_proto_javascript_implicit(r, c);
Index: mod_auth_openidc-2.3.8/src/oauth.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/oauth.c
+++ mod_auth_openidc-2.3.8/src/oauth.c
@@ -58,6 +58,7 @@
#include "mod_auth_openidc.h"
#include "parse.h"
+#include "const.h"
apr_byte_t oidc_oauth_metadata_provider_retrieve(request_rec *r, oidc_cfg *cfg,
const char *issuer, const char *url, json_t **j_metadata,
@@ -161,7 +162,7 @@ static apr_byte_t oidc_oauth_validate_ac
const char *bearer_access_token_auth =
((c->oauth.introspection_client_auth_bearer_token != NULL)
- && strcmp(c->oauth.introspection_client_auth_bearer_token,
+ && _oidc_strcmp(c->oauth.introspection_client_auth_bearer_token,
"") == 0) ?
token : c->oauth.introspection_client_auth_bearer_token;
@@ -173,7 +174,7 @@ static apr_byte_t oidc_oauth_validate_ac
return FALSE;
/* call the endpoint with the constructed parameter set and return the resulting response */
- return apr_strnatcmp(c->oauth.introspection_endpoint_method,
+ return _oidc_strcmp(c->oauth.introspection_endpoint_method,
OIDC_INTROSPECTION_METHOD_GET) == 0 ?
oidc_util_http_get(r, c->oauth.introspection_endpoint_url, params,
basic_auth, bearer_auth, c->oauth.ssl_validate_server, response,
@@ -523,7 +524,7 @@ static apr_byte_t oidc_oauth_resolve_acc
if (oidc_oauth_parse_and_cache_token_expiry(r, c, result,
c->oauth.introspection_token_expiry_claim_name,
- apr_strnatcmp(
+ _oidc_strcmp(
c->oauth.introspection_token_expiry_claim_format,
OIDC_CLAIM_FORMAT_ABSOLUTE) == 0,
c->oauth.introspection_token_expiry_claim_required,
Index: mod_auth_openidc-2.3.8/src/parse.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/parse.c
+++ mod_auth_openidc-2.3.8/src/parse.c
@@ -55,6 +55,7 @@
#include "mod_auth_openidc.h"
#include "parse.h"
#include "jose.h"
+#include "const.h"
/*
* parse a URL according to one of two schemes (NULL for any)
@@ -73,8 +74,8 @@ static const char * oidc_valid_url_schem
"'%s' cannot be parsed as a URL (no scheme set)", arg);
}
- if ((scheme1 != NULL) && (apr_strnatcmp(uri.scheme, scheme1) != 0)) {
- if ((scheme2 != NULL) && (apr_strnatcmp(uri.scheme, scheme2) != 0)) {
+ if ((scheme1 != NULL) && (_oidc_strcmp(uri.scheme, scheme1) != 0)) {
+ if ((scheme2 != NULL) && (_oidc_strcmp(uri.scheme, scheme2) != 0)) {
return apr_psprintf(pool,
"'%s' cannot be parsed as a \"%s\" or \"%s\" URL (scheme == %s)!",
arg, scheme1, scheme2, uri.scheme);
@@ -250,7 +251,7 @@ static const char *oidc_valid_string_opt
char *options[]) {
int i = 0;
while (options[i] != NULL) {
- if (apr_strnatcmp(arg, options[i]) == 0)
+ if (_oidc_strcmp(arg, options[i]) == 0)
break;
i++;
}
@@ -284,14 +285,14 @@ const char *oidc_parse_cache_type(apr_po
if (rv != NULL)
return rv;
- if (apr_strnatcmp(arg, OIDC_CACHE_TYPE_SHM) == 0) {
+ if (_oidc_strcmp(arg, OIDC_CACHE_TYPE_SHM) == 0) {
*type = &oidc_cache_shm;
- } else if (apr_strnatcmp(arg, OIDC_CACHE_TYPE_MEMCACHE) == 0) {
+ } else if (_oidc_strcmp(arg, OIDC_CACHE_TYPE_MEMCACHE) == 0) {
*type = &oidc_cache_memcache;
- } else if (apr_strnatcmp(arg, OIDC_CACHE_TYPE_FILE) == 0) {
+ } else if (_oidc_strcmp(arg, OIDC_CACHE_TYPE_FILE) == 0) {
*type = &oidc_cache_file;
#ifdef USE_LIBHIREDIS
- } else if (apr_strnatcmp(arg, OIDC_CACHE_TYPE_REDIS) == 0) {
+ } else if (_oidc_strcmp(arg, OIDC_CACHE_TYPE_REDIS) == 0) {
*type = &oidc_cache_redis;
#endif
}
@@ -328,9 +329,9 @@ const char *oidc_parse_session_type(apr_
*p = '\0';
}
- if (apr_strnatcmp(s, OIDC_SESSION_TYPE_SERVER_CACHE_STR) == 0) {
+ if (_oidc_strcmp(s, OIDC_SESSION_TYPE_SERVER_CACHE_STR) == 0) {
*type = OIDC_SESSION_TYPE_SERVER_CACHE;
- } else if (apr_strnatcmp(s, OIDC_SESSION_TYPE_CLIENT_COOKIE_STR) == 0) {
+ } else if (_oidc_strcmp(s, OIDC_SESSION_TYPE_CLIENT_COOKIE_STR) == 0) {
*type = OIDC_SESSION_TYPE_CLIENT_COOKIE;
}
return NULL;
@@ -621,13 +622,13 @@ static const char *oidc_parse_key_value(
const char *rv = oidc_valid_string_option(pool, enc, options);
if (rv != NULL)
return rv;
- if (apr_strnatcmp(enc, OIDC_KEY_ENCODING_BASE64) == 0)
+ if (_oidc_strcmp(enc, OIDC_KEY_ENCODING_BASE64) == 0)
return oidc_parse_base64(pool, input, key, key_len);
- if (apr_strnatcmp(enc, OIDC_KEY_ENCODING_BASE64_URL) == 0)
+ if (_oidc_strcmp(enc, OIDC_KEY_ENCODING_BASE64_URL) == 0)
return oidc_parse_base64url(pool, input, key, key_len);
- if (apr_strnatcmp(enc, OIDC_KEY_ENCODING_HEX) == 0)
+ if (_oidc_strcmp(enc, OIDC_KEY_ENCODING_HEX) == 0)
return oidc_parse_hex(pool, input, key, key_len);
- if (apr_strnatcmp(enc, OIDC_KEY_ENCODING_PLAIN) == 0) {
+ if (_oidc_strcmp(enc, OIDC_KEY_ENCODING_PLAIN) == 0) {
*key = apr_pstrdup(pool, input);
*key_len = strlen(*key);
}
@@ -644,7 +645,7 @@ const char *oidc_parse_enc_kid_key_tuple
const char *rv = NULL;
char *s = NULL, *p = NULL, *q = NULL, *enc = NULL;
- if ((tuple == NULL) || (apr_strnatcmp(tuple, "") == 0))
+ if ((tuple == NULL) || (_oidc_strcmp(tuple, "") == 0))
return "tuple value not set";
s = apr_pstrdup(pool, tuple);
@@ -684,11 +685,11 @@ const char *oidc_parse_enc_kid_key_tuple
* convert a "pass id token as" value to an integer
*/
static int oidc_parse_pass_idtoken_as_str2int(const char *v) {
- if (apr_strnatcmp(v, OIDC_PASS_ID_TOKEN_AS_CLAIMS_STR) == 0)
+ if (_oidc_strcmp(v, OIDC_PASS_ID_TOKEN_AS_CLAIMS_STR) == 0)
return OIDC_PASS_IDTOKEN_AS_CLAIMS;
- if (apr_strnatcmp(v, OIDC_PASS_IDTOKEN_AS_PAYLOAD_STR) == 0)
+ if (_oidc_strcmp(v, OIDC_PASS_IDTOKEN_AS_PAYLOAD_STR) == 0)
return OIDC_PASS_IDTOKEN_AS_PAYLOAD;
- if (apr_strnatcmp(v, OIDC_PASS_IDTOKEN_AS_SERIALIZED_STR) == 0)
+ if (_oidc_strcmp(v, OIDC_PASS_IDTOKEN_AS_SERIALIZED_STR) == 0)
return OIDC_PASS_IDTOKEN_AS_SERIALIZED;
return -1;
}
@@ -736,11 +737,11 @@ const char *oidc_parse_pass_idtoken_as(a
* convert a "pass userinfo as" value to an integer
*/
static int oidc_parse_pass_userinfo_as_str2int(const char *v) {
- if (apr_strnatcmp(v, OIDC_PASS_USERINFO_AS_CLAIMS_STR) == 0)
+ if (_oidc_strcmp(v, OIDC_PASS_USERINFO_AS_CLAIMS_STR) == 0)
return OIDC_PASS_USERINFO_AS_CLAIMS;
- if (apr_strnatcmp(v, OIDC_PASS_USERINFO_AS_JSON_OBJECT_STR) == 0)
+ if (_oidc_strcmp(v, OIDC_PASS_USERINFO_AS_JSON_OBJECT_STR) == 0)
return OIDC_PASS_USERINFO_AS_JSON_OBJECT;
- if (apr_strnatcmp(v, OIDC_PASS_USERINFO_AS_JWT_STR) == 0)
+ if (_oidc_strcmp(v, OIDC_PASS_USERINFO_AS_JWT_STR) == 0)
return OIDC_PASS_USERINFO_AS_JWT;
return -1;
}
@@ -819,11 +820,11 @@ const char *oidc_accept_oauth_token_in2s
* convert an "accept OAuth 2.0 token in" value to an integer
*/
static apr_byte_t oidc_parse_oauth_accept_token_in_str2byte(const char *v) {
- if (apr_strnatcmp(v, OIDC_OAUTH_ACCEPT_TOKEN_IN_HEADER_STR) == 0)
+ if (_oidc_strcmp(v, OIDC_OAUTH_ACCEPT_TOKEN_IN_HEADER_STR) == 0)
return OIDC_OAUTH_ACCEPT_TOKEN_IN_HEADER;
- if (apr_strnatcmp(v, OIDC_OAUTH_ACCEPT_TOKEN_IN_POST_STR) == 0)
+ if (_oidc_strcmp(v, OIDC_OAUTH_ACCEPT_TOKEN_IN_POST_STR) == 0)
return OIDC_OAUTH_ACCEPT_TOKEN_IN_POST;
- if (apr_strnatcmp(v, OIDC_OAUTH_ACCEPT_TOKEN_IN_QUERY_STR) == 0)
+ if (_oidc_strcmp(v, OIDC_OAUTH_ACCEPT_TOKEN_IN_QUERY_STR) == 0)
return OIDC_OAUTH_ACCEPT_TOKEN_IN_QUERY;
if (strstr(v, OIDC_OAUTH_ACCEPT_TOKEN_IN_COOKIE_STR) == v)
return OIDC_OAUTH_ACCEPT_TOKEN_IN_COOKIE;
@@ -897,7 +898,7 @@ const char *oidc_parse_claim_required(ap
const char *rv = oidc_valid_string_option(pool, arg, options);
if (rv != NULL)
return rv;
- *is_required = (apr_strnatcmp(arg, OIDC_CLAIM_REQUIRED_MANDATORY) == 0);
+ *is_required = (_oidc_strcmp(arg, OIDC_CLAIM_REQUIRED_MANDATORY) == 0);
return NULL;
}
@@ -932,16 +933,16 @@ const char *oidc_parse_set_claims_as(apr
if (rv != NULL)
return rv;
- if (apr_strnatcmp(arg, OIDC_PASS_CLAIMS_AS_BOTH) == 0) {
+ if (_oidc_strcmp(arg, OIDC_PASS_CLAIMS_AS_BOTH) == 0) {
*in_headers = 1;
*in_env_vars = 1;
- } else if (apr_strnatcmp(arg, OIDC_PASS_CLAIMS_AS_HEADERS) == 0) {
+ } else if (_oidc_strcmp(arg, OIDC_PASS_CLAIMS_AS_HEADERS) == 0) {
*in_headers = 1;
*in_env_vars = 0;
- } else if (apr_strnatcmp(arg, OIDC_PASS_CLAIMS_AS_ENV) == 0) {
+ } else if (_oidc_strcmp(arg, OIDC_PASS_CLAIMS_AS_ENV) == 0) {
*in_headers = 0;
*in_env_vars = 1;
- } else if (apr_strnatcmp(arg, OIDC_PASS_CLAIMS_AS_NONE) == 0) {
+ } else if (_oidc_strcmp(arg, OIDC_PASS_CLAIMS_AS_NONE) == 0) {
*in_headers = 0;
*in_env_vars = 0;
}
@@ -969,13 +970,13 @@ const char *oidc_parse_unauth_action(apr
if (rv != NULL)
return rv;
- if (apr_strnatcmp(arg, OIDC_UNAUTH_ACTION_AUTH_STR) == 0)
+ if (_oidc_strcmp(arg, OIDC_UNAUTH_ACTION_AUTH_STR) == 0)
*action = OIDC_UNAUTH_AUTHENTICATE;
- else if (apr_strnatcmp(arg, OIDC_UNAUTH_ACTION_PASS_STR) == 0)
+ else if (_oidc_strcmp(arg, OIDC_UNAUTH_ACTION_PASS_STR) == 0)
*action = OIDC_UNAUTH_PASS;
- else if (apr_strnatcmp(arg, OIDC_UNAUTH_ACTION_401_STR) == 0)
+ else if (_oidc_strcmp(arg, OIDC_UNAUTH_ACTION_401_STR) == 0)
*action = OIDC_UNAUTH_RETURN401;
- else if (apr_strnatcmp(arg, OIDC_UNAUTH_ACTION_410_STR) == 0)
+ else if (_oidc_strcmp(arg, OIDC_UNAUTH_ACTION_410_STR) == 0)
*action = OIDC_UNAUTH_RETURN410;
return NULL;
@@ -999,11 +1000,11 @@ const char *oidc_parse_unautz_action(apr
if (rv != NULL)
return rv;
- if (apr_strnatcmp(arg, OIDC_UNAUTZ_ACTION_AUTH_STR) == 0)
+ if (_oidc_strcmp(arg, OIDC_UNAUTZ_ACTION_AUTH_STR) == 0)
*action = OIDC_UNAUTZ_AUTHENTICATE;
- else if (apr_strnatcmp(arg, OIDC_UNAUTZ_ACTION_401_STR) == 0)
+ else if (_oidc_strcmp(arg, OIDC_UNAUTZ_ACTION_401_STR) == 0)
*action = OIDC_UNAUTZ_RETURN401;
- else if (apr_strnatcmp(arg, OIDC_UNAUTZ_ACTION_403_STR) == 0)
+ else if (_oidc_strcmp(arg, OIDC_UNAUTZ_ACTION_403_STR) == 0)
*action = OIDC_UNAUTZ_RETURN403;
return NULL;
@@ -1127,9 +1128,9 @@ const char *oidc_parse_userinfo_token_me
if (rv != NULL)
return rv;
- if (apr_strnatcmp(arg, OIDC_USER_INFO_TOKEN_METHOD_HEADER_STR) == 0)
+ if (_oidc_strcmp(arg, OIDC_USER_INFO_TOKEN_METHOD_HEADER_STR) == 0)
*int_value = OIDC_USER_INFO_TOKEN_METHOD_HEADER;
- if (apr_strnatcmp(arg, OIDC_USER_INFO_TOKEN_METHOD_POST_STR) == 0)
+ if (_oidc_strcmp(arg, OIDC_USER_INFO_TOKEN_METHOD_POST_STR) == 0)
*int_value = OIDC_USER_INFO_TOKEN_METHOD_POST;
return NULL;
@@ -1198,13 +1199,13 @@ const char *oidc_parse_token_binding_pol
if (rv != NULL)
return rv;
- if (apr_strnatcmp(arg, OIDC_TOKEN_BINDING_POLICY_DISABLED_STR) == 0)
+ if (_oidc_strcmp(arg, OIDC_TOKEN_BINDING_POLICY_DISABLED_STR) == 0)
*policy = OIDC_TOKEN_BINDING_POLICY_DISABLED;
- else if (apr_strnatcmp(arg, OIDC_TOKEN_BINDING_POLICY_OPTIONAL_STR) == 0)
+ else if (_oidc_strcmp(arg, OIDC_TOKEN_BINDING_POLICY_OPTIONAL_STR) == 0)
*policy = OIDC_TOKEN_BINDING_POLICY_OPTIONAL;
- else if (apr_strnatcmp(arg, OIDC_TOKEN_BINDING_POLICY_REQUIRED_STR) == 0)
+ else if (_oidc_strcmp(arg, OIDC_TOKEN_BINDING_POLICY_REQUIRED_STR) == 0)
*policy = OIDC_TOKEN_BINDING_POLICY_REQUIRED;
- else if (apr_strnatcmp(arg, OIDC_TOKEN_BINDING_POLICY_ENFORCED_STR) == 0)
+ else if (_oidc_strcmp(arg, OIDC_TOKEN_BINDING_POLICY_ENFORCED_STR) == 0)
*policy = OIDC_TOKEN_BINDING_POLICY_ENFORCED;
return NULL;
@@ -1233,9 +1234,9 @@ const char *oidc_parse_auth_request_meth
if (rv != NULL)
return rv;
- if (apr_strnatcmp(arg, OIDC_AUTH_REQUEST_METHOD_GET_STR) == 0)
+ if (_oidc_strcmp(arg, OIDC_AUTH_REQUEST_METHOD_GET_STR) == 0)
*method = OIDC_AUTH_REQUEST_METHOD_GET;
- else if (apr_strnatcmp(arg, OIDC_AUTH_REQEUST_METHOD_POST_STR) == 0)
+ else if (_oidc_strcmp(arg, OIDC_AUTH_REQEUST_METHOD_POST_STR) == 0)
*method = OIDC_AUTH_REQUEST_METHOD_POST;
return NULL;
Index: mod_auth_openidc-2.3.8/src/proto.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/proto.c
+++ mod_auth_openidc-2.3.8/src/proto.c
@@ -56,6 +56,7 @@
#include "mod_auth_openidc.h"
#include "parse.h"
+#include "const.h"
#include <openssl/opensslconf.h>
#include <openssl/opensslv.h>
@@ -95,7 +96,7 @@ static apr_byte_t oidc_proto_param_needs
while (index < json_array_size(copy_from_request)) {
json_t *value = json_array_get(copy_from_request, index);
if ((json_is_string(value))
- && (apr_strnatcmp(json_string_value(value), parameter_name) == 0)) {
+ && (_oidc_strcmp(json_string_value(value), parameter_name) == 0)) {
return TRUE;
}
index++;
@@ -202,7 +203,7 @@ apr_byte_t oidc_proto_get_encryption_jwk
const char *use = json_string_value(
json_object_get(elem, OIDC_JWK_USE));
- if ((use != NULL) && (strcmp(use, OIDC_JWK_ENC) != 0)) {
+ if ((use != NULL) && (_oidc_strcmp(use, OIDC_JWK_ENC) != 0)) {
oidc_debug(r, "skipping key because of non-matching \"%s\": \"%s\"",
OIDC_JWK_USE, use);
continue;
@@ -280,7 +281,7 @@ char *oidc_proto_create_request_object(r
&request_object->header.alg, "none");
/* see if we need to sign the request object */
- if (strcmp(request_object->header.alg, "none") != 0) {
+ if (_oidc_strcmp(request_object->header.alg, "none") != 0) {
oidc_jwk_t *jwk = NULL;
int jwk_needs_destroy = 0;
@@ -477,9 +478,9 @@ static void oidc_proto_add_request_param
}
/* ensure parameter variable to have a valid value */
- if (strcmp(request_object_type_str, OIDC_PROTO_REQUEST_OBJECT) == 0) {
+ if (_oidc_strcmp(request_object_type_str, OIDC_PROTO_REQUEST_OBJECT) == 0) {
parameter = OIDC_PROTO_REQUEST_OBJECT;
- } else if (strcmp(request_object_type_str, OIDC_PROTO_REQUEST_URI)
+ } else if (_oidc_strcmp(request_object_type_str, OIDC_PROTO_REQUEST_URI)
!= 0) {
oidc_error(r, "Bad request_object_type in config: %s",
request_object_type_str);
@@ -489,7 +490,7 @@ static void oidc_proto_add_request_param
/* create request value */
char * value = NULL;
- if (strcmp(parameter, OIDC_PROTO_REQUEST_URI) == 0) {
+ if (_oidc_strcmp(parameter, OIDC_PROTO_REQUEST_URI) == 0) {
/* parameter is "request_uri" */
value = oidc_proto_create_request_uri(r, provider,
request_object_config, redirect_uri, params);
@@ -575,7 +576,7 @@ int oidc_proto_authorization_request(req
/* concat the per-path scopes with the per-provider scopes */
const char *scope = provider->scope;
if (path_scope != NULL)
- scope = ((scope != NULL) && (apr_strnatcmp(scope, "") != 0)) ?
+ scope = ((scope != NULL) && (_oidc_strcmp(scope, "") != 0)) ?
apr_pstrcat(r->pool, scope, OIDC_STR_SPACE, path_scope, NULL) :
path_scope;
@@ -1026,7 +1027,7 @@ apr_byte_t oidc_proto_validate_nonce(req
}
/* see if the nonce in the id_token matches the one that we sent in the authorization request */
- if (apr_strnatcmp(nonce, j_nonce) != 0) {
+ if (_oidc_strcmp(nonce, j_nonce) != 0) {
oidc_error(r,
"the nonce value (%s) in the id_token did not match the one stored in the browser session (%s)",
j_nonce, nonce);
@@ -1067,7 +1068,7 @@ static apr_byte_t oidc_proto_validate_au
* is different than the authorized party; it MAY be included even when the authorized party is
* the same as the sole audience.
*/
- if ((azp != NULL) && (apr_strnatcmp(azp, provider->client_id) != 0)) {
+ if ((azp != NULL) && (_oidc_strcmp(azp, provider->client_id) != 0)) {
oidc_error(r,
"the \"%s\" claim (%s) is present in the id_token, but is not equal to the configured client_id (%s)",
OIDC_CLAIM_AZP, azp, provider->client_id);
@@ -1082,7 +1083,7 @@ static apr_byte_t oidc_proto_validate_au
if (json_is_string(aud)) {
/* a single-valued audience must be equal to our client_id */
- if (apr_strnatcmp(json_string_value(aud), provider->client_id)
+ if (_oidc_strcmp(json_string_value(aud), provider->client_id)
!= 0) {
oidc_error(r,
"the configured client_id (%s) did not match the \"%s\" claim value (%s) in the id_token",
@@ -1421,7 +1422,7 @@ static apr_byte_t oidc_proto_get_key_fro
if ((jwt->header.kid == NULL) && (x5t == NULL)) {
const char *use = json_string_value(
json_object_get(elem, OIDC_JWK_USE));
- if ((use != NULL) && (strcmp(use, OIDC_JWK_SIG) != 0)) {
+ if ((use != NULL) && (_oidc_strcmp(use, OIDC_JWK_SIG) != 0)) {
oidc_debug(r,
"skipping key because of non-matching \"%s\": \"%s\"",
OIDC_JWK_USE, use);
@@ -1445,7 +1446,7 @@ static apr_byte_t oidc_proto_get_key_fro
/* we are looking for a specific kid, get the kid from the current element */
/* compare the requested kid against the current element */
if ((jwt->header.kid != NULL) && (jwk->kid != NULL)
- && (apr_strnatcmp(jwt->header.kid, jwk->kid) == 0)) {
+ && (_oidc_strcmp(jwt->header.kid, jwk->kid) == 0)) {
oidc_jwk_to_json(r->pool, jwk, &jwk_json, &err);
oidc_debug(r, "found matching kid: \"%s\" for jwk: %s",
jwt->header.kid, jwk_json);
@@ -1458,7 +1459,7 @@ static apr_byte_t oidc_proto_get_key_fro
oidc_json_object_get_string(r->pool, elem, OIDC_JWK_X5T, &s_x5t, NULL);
/* compare the requested thumbprint against the current element */
if ((s_x5t != NULL) && (x5t != NULL)
- && (apr_strnatcmp(x5t, s_x5t) == 0)) {
+ && (_oidc_strcmp(x5t, s_x5t) == 0)) {
oidc_jwk_to_json(r->pool, jwk, &jwk_json, &err);
oidc_debug(r, "found matching %s: \"%s\" for jwk: %s", OIDC_JWK_X5T,
x5t, jwk_json);
@@ -1631,7 +1632,7 @@ apr_byte_t oidc_proto_parse_idtoken(requ
(*jwt)->header.value.str, (*jwt)->payload.value.str);
// make signature validation exception for 'code' flow and the algorithm NONE
- if (is_code_flow == FALSE || strcmp((*jwt)->header.alg, "none") != 0) {
+ if (is_code_flow == FALSE || _oidc_strcmp((*jwt)->header.alg, "none") != 0) {
jwk = NULL;
if (oidc_util_create_symmetric_key(r, provider->client_secret, 0,
@@ -1887,40 +1888,40 @@ apr_byte_t oidc_proto_token_endpoint_aut
if ((token_endpoint_auth == NULL) && (client_secret != NULL))
token_endpoint_auth = OIDC_PROTO_CLIENT_SECRET_BASIC;
- if ((token_endpoint_auth == NULL) || (apr_strnatcmp(token_endpoint_auth,
+ if ((token_endpoint_auth == NULL) || (_oidc_strcmp(token_endpoint_auth,
OIDC_PROTO_ENDPOINT_AUTH_NONE) == 0))
return oidc_proto_endpoint_auth_none(r, client_id, params);
// if no client_secret is set and we don't authenticate using private_key_jwt,
// we can only be a public client since the other methods require a client_secret
- if ((client_secret == NULL) && (apr_strnatcmp(token_endpoint_auth,
+ if ((client_secret == NULL) && (_oidc_strcmp(token_endpoint_auth,
OIDC_PROTO_PRIVATE_KEY_JWT) != 0)) {
oidc_debug(r,
"no client secret set and not using private_key_jwt, assume we are a public client");
return oidc_proto_endpoint_auth_none(r, client_id, params);
}
- if (apr_strnatcmp(token_endpoint_auth,
+ if (_oidc_strcmp(token_endpoint_auth,
OIDC_PROTO_CLIENT_SECRET_BASIC) == 0)
return oidc_proto_endpoint_auth_basic(r, client_id, client_secret,
basic_auth_str);
- if (apr_strnatcmp(token_endpoint_auth,
+ if (_oidc_strcmp(token_endpoint_auth,
OIDC_PROTO_CLIENT_SECRET_POST) == 0)
return oidc_proto_endpoint_auth_post(r, client_id, client_secret,
params);
- if (apr_strnatcmp(token_endpoint_auth,
+ if (_oidc_strcmp(token_endpoint_auth,
OIDC_PROTO_CLIENT_SECRET_JWT) == 0)
return oidc_proto_endpoint_auth_client_secret_jwt(r, client_id,
client_secret, audience, params);
- if (apr_strnatcmp(token_endpoint_auth,
+ if (_oidc_strcmp(token_endpoint_auth,
OIDC_PROTO_PRIVATE_KEY_JWT) == 0)
return oidc_proto_endpoint_auth_private_key_jwt(r, cfg, client_id,
audience, params);
- if (apr_strnatcmp(token_endpoint_auth,
+ if (_oidc_strcmp(token_endpoint_auth,
OIDC_PROTO_BEARER_ACCESS_TOKEN) == 0) {
return oidc_proto_endpoint_access_token_bearer(r, cfg, bearer_access_token, bearer_auth_str);
}
@@ -2202,7 +2203,7 @@ static apr_byte_t oidc_proto_resolve_com
NULL, NULL);
}
}
- if ((s_json != NULL) && (strcmp(s_json, "") != 0)) {
+ if ((s_json != NULL) && (_oidc_strcmp(s_json, "") != 0)) {
oidc_jwt_t *jwt = NULL;
if (oidc_jwt_parse(r->pool, s_json, &jwt,
oidc_util_merge_symmetric_key(r->pool,
@@ -2298,7 +2299,7 @@ apr_byte_t oidc_proto_resolve_userinfo(r
user_info_sub);
if ((id_token_sub != NULL) && (user_info_sub != NULL)) {
- if (apr_strnatcmp(id_token_sub, user_info_sub) != 0) {
+ if (_oidc_strcmp(id_token_sub, user_info_sub) != 0) {
oidc_error(r,
"\"%s\" claim (\"%s\") returned from userinfo endpoint does not match the one in the id_token (\"%s\")",
OIDC_CLAIM_SUB, user_info_sub, id_token_sub);
@@ -2748,7 +2749,7 @@ static apr_byte_t oidc_proto_validate_re
if (requested_response_mode == NULL)
requested_response_mode = default_response_mode;
- if (apr_strnatcmp(requested_response_mode, response_mode) != 0) {
+ if (_oidc_strcmp(requested_response_mode, response_mode) != 0) {
oidc_error(r,
"requested response mode (%s) does not match the response mode used by the OP (%s)",
requested_response_mode, response_mode);
@@ -2766,7 +2767,7 @@ static apr_byte_t oidc_proto_validate_is
const char *configured_client_id, const char *response_client_id) {
if (response_issuer != NULL) {
- if (apr_strnatcmp(configured_issuer, response_issuer) != 0) {
+ if (_oidc_strcmp(configured_issuer, response_issuer) != 0) {
oidc_error(r,
"configured issuer (%s) does not match the issuer provided in the response by the OP (%s)",
configured_issuer, response_issuer);
@@ -2775,7 +2776,7 @@ static apr_byte_t oidc_proto_validate_is
}
if (response_client_id != NULL) {
- if (apr_strnatcmp(configured_client_id, response_client_id) != 0) {
+ if (_oidc_strcmp(configured_client_id, response_client_id) != 0) {
oidc_error(r,
"configured client_id (%s) does not match the client_id provided in the response by the OP (%s)",
configured_client_id, response_client_id);
Index: mod_auth_openidc-2.3.8/src/session.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/session.c
+++ mod_auth_openidc-2.3.8/src/session.c
@@ -58,6 +58,7 @@
#include <http_log.h>
#include "mod_auth_openidc.h"
+#include "const.h"
extern module AP_MODULE_DECLARE_DATA auth_openidc_module;
@@ -148,7 +149,7 @@ static apr_byte_t oidc_session_load_cach
/* compare the session id in the cache value so it allows us to detect cache corruption */
oidc_session_get(r, z, OIDC_SESSION_SESSION_ID, &stored_uuid);
if ((stored_uuid == NULL)
- || (apr_strnatcmp(stored_uuid, uuid) != 0)) {
+ || (_oidc_strcmp(stored_uuid, uuid) != 0)) {
oidc_error(r,
"cache corruption detected: stored session id (%s) is not equal to requested session id (%s)",
stored_uuid, uuid);
@@ -183,7 +184,7 @@ static apr_byte_t oidc_session_save_cach
if (z->state != NULL) {
- if (apr_strnatcmp(z->uuid, "") == 0) {
+ if (_oidc_strcmp(z->uuid, "") == 0) {
/* get a new uuid for this session */
oidc_session_uuid_new(r, z);
/* store the session id in the cache value so it allows us to detect cache corruption */
@@ -298,7 +299,7 @@ apr_byte_t oidc_session_load(request_rec
if (ses_p_tb_id != NULL) {
env_p_tb_id = oidc_util_get_provided_token_binding_id(r);
if ((env_p_tb_id == NULL)
- || (apr_strnatcmp(env_p_tb_id, ses_p_tb_id) != 0)) {
+ || (_oidc_strcmp(env_p_tb_id, ses_p_tb_id) != 0)) {
oidc_error(r,
"the Provided Token Binding ID stored in the session doesn't match the one presented by the user agent");
oidc_session_clear(r, z);
Index: mod_auth_openidc-2.3.8/src/util.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/src/util.c
+++ mod_auth_openidc-2.3.8/src/util.c
@@ -62,6 +62,7 @@
#include <curl/curl.h>
#include "mod_auth_openidc.h"
+#include "const.h"
#include <pcre.h>
#include "pcre_subst.h"
@@ -483,8 +484,8 @@ static const char *oidc_get_current_url_
#endif
}
if ((scheme_str == NULL)
- || ((apr_strnatcmp(scheme_str, "http") != 0)
- && (apr_strnatcmp(scheme_str, "https") != 0))) {
+ || ((_oidc_strcmp(scheme_str, "http") != 0)
+ && (_oidc_strcmp(scheme_str, "https") != 0))) {
oidc_warn(r,
"detected HTTP scheme \"%s\" is not \"http\" nor \"https\"; perhaps your reverse proxy passes a wrongly configured \"%s\" header: falling back to default \"https\"",
scheme_str, OIDC_HTTP_HDR_X_FORWARDED_PROTO);
@@ -544,9 +545,9 @@ static const char *oidc_get_current_url_
* determine the port locally and don't print it when it's the default for the protocol
*/
const apr_port_t port = r->connection->local_addr->port;
- if ((apr_strnatcmp(scheme_str, "https") == 0) && port == 443)
+ if ((_oidc_strcmp(scheme_str, "https") == 0) && port == 443)
return NULL;
- else if ((apr_strnatcmp(scheme_str, "http") == 0) && port == 80)
+ else if ((_oidc_strcmp(scheme_str, "http") == 0) && port == 80)
return NULL;
port_str = apr_psprintf(r->pool, "%u", port);
@@ -991,7 +992,7 @@ static char *oidc_util_get_cookie_path(r
char *rv = NULL, *requestPath = oidc_util_get_path(r);
char *cookie_path = oidc_cfg_dir_cookie_path(r);
if (cookie_path != NULL) {
- if (strncmp(cookie_path, requestPath, strlen(cookie_path)) == 0)
+ if (_oidc_strncmp(cookie_path, requestPath, strlen(cookie_path)) == 0)
rv = cookie_path;
else {
oidc_warn(r,
@@ -1024,7 +1025,7 @@ void oidc_util_set_cookie(request_rec *r
char *headerString, *expiresString = NULL;
/* see if we need to clear the cookie */
- if (apr_strnatcmp(cookieValue, "") == 0)
+ if (_oidc_strcmp(cookieValue, "") == 0)
expires = 0;
/* construct the expire value */
@@ -1091,7 +1092,7 @@ char *oidc_util_get_cookie(request_rec *
cookie++;
/* see if we've found the cookie that we're looking for */
- if ((strncmp(cookie, cookieName, strlen(cookieName)) == 0)
+ if ((_oidc_strncmp(cookie, cookieName, strlen(cookieName)) == 0)
&& (cookie[strlen(cookieName)] == OIDC_CHAR_EQUAL)) {
/* skip to the meat of the parameter (the value after the '=') */
@@ -1262,7 +1263,7 @@ apr_byte_t oidc_util_request_matches_url
oidc_debug(r, "comparing \"%s\"==\"%s\"", r->parsed_uri.path, uri.path);
if ((r->parsed_uri.path == NULL) || (uri.path == NULL))
return (r->parsed_uri.path == uri.path);
- return (apr_strnatcmp(r->parsed_uri.path, uri.path) == 0);
+ return (_oidc_strcmp(r->parsed_uri.path, uri.path) == 0);
}
/*
@@ -1296,7 +1297,7 @@ apr_byte_t oidc_util_get_request_paramet
p = apr_strtok(args, OIDC_STR_AMP, &tokenizer_ctx);
do {
- if (p && strncmp(p, k_param, k_param_sz) == 0) {
+ if (p && _oidc_strncmp(p, k_param, k_param_sz) == 0) {
*value = apr_pstrdup(r->pool, p + k_param_sz);
*value = oidc_util_unescape_string(r, *value);
}
@@ -1722,7 +1723,7 @@ apr_byte_t oidc_util_file_write(request_
apr_byte_t oidc_util_issuer_match(const char *a, const char *b) {
/* check the "issuer" value against the one configure for the provider we got this id_token from */
- if (apr_strnatcmp(a, b) != 0) {
+ if (_oidc_strcmp(a, b) != 0) {
/* no strict match, but we are going to accept if the difference is only a trailing slash */
int n1 = strlen(a);
@@ -1731,7 +1732,7 @@ apr_byte_t oidc_util_issuer_match(const
n2 :
(((n2 == n1 + 1) && (b[n2 - 1] == OIDC_CHAR_FORWARD_SLASH)) ?
n1 : 0);
- if ((n == 0) || (strncmp(a, b, n) != 0))
+ if ((n == 0) || (_oidc_strncmp(a, b, n) != 0))
return FALSE;
}
@@ -1755,7 +1756,7 @@ apr_byte_t oidc_util_json_array_has_valu
elem->type);
continue;
}
- if (apr_strnatcmp(json_string_value(elem), needle) == 0) {
+ if (_oidc_strcmp(json_string_value(elem), needle) == 0) {
break;
}
}
@@ -1888,7 +1889,7 @@ void oidc_util_set_app_infos(request_rec
/* concatenate the string to the s_concat value using the configured separator char */
// TODO: escape the delimiter in the values (maybe reuse/extract url-formatted code from oidc_session_identity_encode)
- if (apr_strnatcmp(s_concat, "") != 0) {
+ if (_oidc_strcmp(s_concat, "") != 0) {
s_concat = apr_psprintf(r->pool, "%s%s%s", s_concat,
claim_delimiter, json_string_value(elem));
} else {
@@ -1898,7 +1899,7 @@ void oidc_util_set_app_infos(request_rec
} else if (json_is_boolean(elem)) {
- if (apr_strnatcmp(s_concat, "") != 0) {
+ if (_oidc_strcmp(s_concat, "") != 0) {
s_concat = apr_psprintf(r->pool, "%s%s%s", s_concat,
claim_delimiter,
json_is_true(elem) ? "1" : "0");
@@ -2303,7 +2304,7 @@ int oidc_util_cookie_domain_valid(const
} else {
p = strstr(hostname, check_cookie);
}
- if ((p == NULL) || (apr_strnatcmp(check_cookie, p) != 0)) {
+ if ((p == NULL) || (_oidc_strcmp(check_cookie, p) != 0)) {
return FALSE;
}
return TRUE;
@@ -2336,7 +2337,7 @@ static apr_byte_t oidc_util_hdr_in_conta
while (elem != NULL) {
while (*elem == OIDC_CHAR_SPACE)
elem++;
- if ((strncmp(elem, needle, strlen(needle)) == 0)
+ if ((_oidc_strncmp(elem, needle, strlen(needle)) == 0)
&& ((elem[strlen(needle)] == '\0')
|| (elem[strlen(needle)] == postfix_separator))) {
rc = TRUE;
Index: mod_auth_openidc-2.3.8/test/test.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/test/test.c
+++ mod_auth_openidc-2.3.8/test/test.c
@@ -63,6 +63,7 @@
#include "apr_base64.h"
#include "mod_auth_openidc.h"
+#include "const.h"
extern module AP_MODULE_DECLARE_DATA auth_openidc_module;
@@ -95,14 +96,14 @@ static int TST_RC;
}
#define TST_ASSERT_STR(message, result, expected) \
- TST_RC = (result && expected) ? (apr_strnatcmp(result, expected) != 0) : ((result != NULL) || (expected != NULL)); \
+ TST_RC = (result && expected) ? (_oidc_strcmp(result, expected) != 0) : ((result != NULL) || (expected != NULL)); \
if (TST_RC) { \
sprintf(TST_ERR_MSG, TST_FORMAT("%s"), __FUNCTION__, message, result ? result : "(null)", expected ? expected : "(null)"); \
return TST_ERR_MSG; \
}
#define TST_ASSERT_STRN(message, result, expected, len) \
- TST_RC = (result && expected) ? (strncmp(result, expected, len) != 0) : ((result != NULL) || (expected != NULL)); \
+ TST_RC = (result && expected) ? (_oidc_strncmp(result, expected, len) != 0) : ((result != NULL) || (expected != NULL)); \
if (TST_RC) { \
sprintf(TST_ERR_MSG, TST_FORMAT("%s"), __FUNCTION__, message, result ? result : "(null)", expected ? expected : "(null)"); \
return TST_ERR_MSG; \
Index: mod_auth_openidc-2.3.8/test/test-cmd.c
===================================================================
--- mod_auth_openidc-2.3.8.orig/test/test-cmd.c
+++ mod_auth_openidc-2.3.8/test/test-cmd.c
@@ -63,6 +63,7 @@
#include <cjose/jws.h>
#include <mod_auth_openidc.h>
+#include <const.h>
int usage(int argc, char **argv, const char *msg) {
fprintf(stderr, "Usage: %s %s\n", argv[0],
@@ -531,28 +532,28 @@ int main(int argc, char **argv, char **e
apr_pool_t *pool = NULL;
apr_pool_create(&pool, NULL);
- if (strcmp(argv[1], "sign") == 0)
+ if (_oidc_strcmp(argv[1], "sign") == 0)
return sign(argc, argv, pool);
- if (strcmp(argv[1], "verify") == 0)
+ if (_oidc_strcmp(argv[1], "verify") == 0)
return verify(argc, argv, pool);
- if (strcmp(argv[1], "jwk2cert") == 0)
+ if (_oidc_strcmp(argv[1], "jwk2cert") == 0)
return jwk2cert(argc, argv, pool);
- if (strcmp(argv[1], "cert2jwk") == 0)
+ if (_oidc_strcmp(argv[1], "cert2jwk") == 0)
return cert2jwk(argc, argv, pool);
- if (strcmp(argv[1], "enckey") == 0)
+ if (_oidc_strcmp(argv[1], "enckey") == 0)
return enckey(argc, argv, pool);
- if (strcmp(argv[1], "hash_base64url") == 0)
+ if (_oidc_strcmp(argv[1], "hash_base64url") == 0)
return hash_base64url(argc, argv, pool);
- if (strcmp(argv[1], "timestamp") == 0)
+ if (_oidc_strcmp(argv[1], "timestamp") == 0)
return timestamp(argc, argv, pool);
- if (strcmp(argv[1], "uuid") == 0)
+ if (_oidc_strcmp(argv[1], "uuid") == 0)
return uuid(argc, argv, pool);
apr_pool_destroy(pool);
Index: mod_auth_openidc-2.3.8/src/const.h
===================================================================
--- /dev/null
+++ mod_auth_openidc-2.3.8/src/const.h
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/***************************************************************************
+ * Copyright (C) 2017-2025 ZmartZone Holding BV
+ * Copyright (C) 2013-2017 Ping Identity Corporation
+ * All rights reserved.
+ *
+ * DISCLAIMER OF WARRANTIES:
+ *
+ * THE SOFTWARE PROVIDED HEREUNDER IS PROVIDED ON AN "AS IS" BASIS, WITHOUT
+ * ANY WARRANTIES OR REPRESENTATIONS EXPRESS, IMPLIED OR STATUTORY; INCLUDING,
+ * WITHOUT LIMITATION, WARRANTIES OF QUALITY, PERFORMANCE, NONINFRINGEMENT,
+ * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE. NOR ARE THERE ANY
+ * WARRANTIES CREATED BY A COURSE OR DEALING, COURSE OF PERFORMANCE OR TRADE
+ * USAGE. FURTHERMORE, THERE ARE NO WARRANTIES THAT THE SOFTWARE WILL MEET
+ * YOUR NEEDS OR BE FREE FROM ERRORS, OR THAT THE OPERATION OF THE SOFTWARE
+ * WILL BE UNINTERRUPTED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES HOWEVER CAUSED AND ON ANY THEORY OF
+ * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * @Author: Hans Zandbelt - hans.zandbelt@openidc.com
+ */
+
+#ifndef _MOD_AUTH_OPENIDC_CONST_H_
+#define _MOD_AUTH_OPENIDC_CONST_H_
+
+#include <string.h>
+#include <apr_strings.h>
+
+static inline int _oidc_strcmp(const char *a, const char *b) {
+ return ((a && b) ? apr_strnatcmp(a, b) : -1);
+}
+static inline int _oidc_strncmp(const char *a, const char *b, size_t n) {
+ return ((a && b) ? strncmp(a, b, n) : -1);
+}
+#endif /* _MOD_AUTH_OPENIDC_CONST_H_ */
