File 3_5_BRANCH_612786.diff of Package kdelibs3

------------------------------------------------------------------------
r612786 | mueller | 2006-12-12 17:24:40 +0100 (Tue, 12 Dec 2006) | 3 lines

fix crash race on various sites with popup ads, e.g. pvponline.com
(bnc:226099)

------------------------------------------------------------------------
Index: khtml/html/html_objectimpl.cpp
===================================================================
--- khtml/html/html_objectimpl.cpp	(revision 612785)
+++ khtml/html/html_objectimpl.cpp	(revision 612786)
@@ -141,8 +141,9 @@ void HTMLObjectBaseElementImpl::renderAl
 
 void HTMLObjectBaseElementImpl::slotRenderAlternative()
 {
-    // an unbelievable hack. FIXME!!
-    if ( m_renderAlternative ) return;
+    // the singleshot timer might have fired after we're removed
+    // from the document, but not yet deleted due to references
+    if ( !inDocument() || m_renderAlternative ) return;
 
     // ### there can be a m_render if this is called from our attach indirectly
     if ( attached() || m_render)