File cpupower-Add-cpuid-cap-flag-for-MSR_AMD_HWCR-support.patch of Package cpupower.22252
From: Nathan Fontenot <nathan.fontenot@amd.com>
Subject: cpupower: Add cpuid cap flag for MSR_AMD_HWCR support
References: jsc#SLE-17797
Patch-Mainline: v5.12-rc1-dontuse
Git-commit: 3a3ecfdb605cc8d98988012a4f88c34b4d220c21
Remove the family check for accessing the MSR_AMD_HWCR MSR and replace
it with a cpupower cap flag.
This update also allows for the removal of the local cpupower_cpu_info
variable in cpufreq_has_boost_support() since we no longer need it to
check the family.
Signed-off-by: Nathan Fontenot <nathan.fontenot@amd.com>
Reviewed-by: Robert Richter <rrichter@amd.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: <trenn@suse.com>
---
utils/helpers/cpuid.c | 6 +++++-
utils/helpers/helpers.h | 1 +
utils/helpers/misc.c | 7 +------
3 files changed, 7 insertions(+), 7 deletions(-)
--- a/utils/helpers/cpuid.c
+++ b/utils/helpers/cpuid.c
@@ -129,9 +129,13 @@
if (cpu_info->vendor == X86_VENDOR_AMD ||
cpu_info->vendor == X86_VENDOR_HYGON) {
if (ext_cpuid_level >= 0x80000007) {
- if (cpuid_edx(0x80000007) & (1 << 9))
+ if (cpuid_edx(0x80000007) & (1 << 9)) {
cpu_info->caps |= CPUPOWER_CAP_AMD_CPB;
+ if (cpu_info->family >= 0x17)
+ cpu_info->caps |= CPUPOWER_CAP_AMD_CPB_MSR;
+ }
+
if ((cpuid_edx(0x80000007) & (1 << 7)) &&
cpu_info->family != 0x14) {
/* HW pstate was not implemented in family 0x14 */
--- a/utils/helpers/helpers.h
+++ b/utils/helpers/helpers.h
@@ -72,6 +72,7 @@
#define CPUPOWER_CAP_AMD_RDPRU 0x00000080
#define CPUPOWER_CAP_AMD_HW_PSTATE 0x00000100
#define CPUPOWER_CAP_AMD_PSTATEDEF 0x00000200
+#define CPUPOWER_CAP_AMD_CPB_MSR 0x00000400
#define CPUPOWER_AMD_CPBDIS 0x02000000
--- a/utils/helpers/misc.c
+++ b/utils/helpers/misc.c
@@ -8,16 +8,11 @@
int cpufreq_has_boost_support(unsigned int cpu, int *support, int *active,
int *states)
{
- struct cpupower_cpu_info cpu_info;
int ret;
unsigned long long val;
*support = *active = *states = 0;
- ret = get_cpu_info(&cpu_info);
- if (ret)
- return ret;
-
if (cpupower_cpu_info.caps & CPUPOWER_CAP_AMD_CPB) {
*support = 1;
@@ -26,7 +21,7 @@
* has Hardware determined variable increments instead.
*/
- if (cpu_info.family == 0x17 || cpu_info.family == 0x18) {
+ if (cpupower_cpu_info.caps & CPUPOWER_CAP_AMD_CPB_MSR) {
if (!read_msr(cpu, MSR_AMD_HWCR, &val)) {
if (!(val & CPUPOWER_AMD_CPBDIS))
*active = 1;