File CVE-2014-4616-json-bounds-check.patch of Package python.openSUSE_12.3_Update
# HG changeset patch
# User Benjamin Peterson <benjamin@python.org>
# Date 1397441438 14400
# Node ID 50c07ed1743da9cd4540d83de0c30bd17aeb41b0
# Parent 218e28a935ab4494d05215c243e2129625a71893
in scan_once, prevent the reading of arbitrary memory when passed a negative index
Bug reported by Guido Vranken.
Index: Python-2.7.3/Lib/json/tests/test_decode.py
===================================================================
--- Python-2.7.3.orig/Lib/json/tests/test_decode.py 2014-06-26 18:44:30.487527112 +0200
+++ Python-2.7.3/Lib/json/tests/test_decode.py 2014-06-26 18:44:38.322565108 +0200
@@ -46,5 +46,10 @@
OrderedDict(p))
+ def test_negative_index(self):
+ d = self.json.JSONDecoder()
+ self.assertRaises(ValueError, d.raw_decode, 'a'*42, -50000)
+ self.assertRaises(ValueError, d.raw_decode, u'a'*42, -50000)
+
class TestPyDecode(TestDecode, PyTest): pass
class TestCDecode(TestDecode, CTest): pass
Index: Python-2.7.3/Misc/ACKS
===================================================================
--- Python-2.7.3.orig/Misc/ACKS 2014-06-26 18:44:38.322565108 +0200
+++ Python-2.7.3/Misc/ACKS 2014-06-26 18:45:16.218748917 +0200
@@ -879,6 +879,7 @@
Kurt Vile
Norman Vine
Frank Visser
+Guido Vranen
Niki W. Waibel
Wojtek Walczak
Charles Waldman
Index: Python-2.7.3/Modules/_json.c
===================================================================
--- Python-2.7.3.orig/Modules/_json.c 2014-06-26 18:44:30.488527117 +0200
+++ Python-2.7.3/Modules/_json.c 2014-06-26 18:44:38.322565108 +0200
@@ -1491,7 +1491,10 @@
PyObject *res;
char *str = PyString_AS_STRING(pystr);
Py_ssize_t length = PyString_GET_SIZE(pystr);
- if (idx >= length) {
+ if (idx < 0)
+ /* Compatibility with the Python version. */
+ idx += length;
+ if (idx < 0 || idx >= length) {
PyErr_SetNone(PyExc_StopIteration);
return NULL;
}
@@ -1578,7 +1581,10 @@
PyObject *res;
Py_UNICODE *str = PyUnicode_AS_UNICODE(pystr);
Py_ssize_t length = PyUnicode_GET_SIZE(pystr);
- if (idx >= length) {
+ if (idx < 0)
+ /* Compatibility with Python version. */
+ idx += length;
+ if (idx < 0 || idx >= length) {
PyErr_SetNone(PyExc_StopIteration);
return NULL;
}