Adding to what @yecril71pl said. Now it's strncpy(charb, "'", 1). Which is not much better than strncpy(charb, "'", 7). The last argument to strncpy is supposed to be size of the target buffer (fewer is possible - but raises eyebrows as it did). Since you are explicitly adding the \0 byte anyway at a fixed location without checking sizeof(charb), why even go to the hassle of using strncpy, just write strcpy(charb, "'") and strcpy(charb, """), since you seem to be fine assuming charb is 7 or larger anyway.

Dr. Werner Fink (WernerFink) - over 1 year ago

author source maintainer

Thew size of charb is well defined:

bash/bash> grep TINY_STR_MAX ./bash-5.1/support/man2html.c
#define TINY_STR_MAX  10
static char charb[TINY_STR_MAX];

and the code is choosen to look like the surrounding code as well. Otherwise I would simply memset the buffer charb with zeros and use charb[0] = (char)39

An other approach would be to require groff-full at build time and use roff2html or groff -Thtml

Dr. Werner Fink (WernerFink) - over 1 year ago

author source maintainer

roff2html seems to have very similar result as man2html

Christopher Yeleighton (yecril71pl) - over 1 year ago

• -Thtml is hopelessly broken and must be reimplemented from scratch; my proof of concept was completely ignored by upstream :-(

• -Tdvi would be better for reliability and readability but it requires a graphic display to be read, which does not fly for a base package.

• We could also just %exclude the result altogether and hope that man bash will do the right thing.

Also, slpitting