Request History
sndirsch created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
RBrownFactory set openSUSE:Factory:Staging:H as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:H"
RBrownFactory accepted review
Picked "openSUSE:Factory:Staging:H"
licensedigger accepted review
ok
RBrownFactory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
RBrownFactory accepted review
Unstaged from project "openSUSE:Factory:Staging:H"
RBrownFactory set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
RBrownFactory accepted review
Picked "openSUSE:Factory:Staging:E"
dimstar accepted review
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:E"
dimstar_suse set openSUSE:Factory:Staging:L as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:L"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:L"
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:L"
dimstar_suse set openSUSE:Factory:Staging:M as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:M"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:M"
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:M"
dimstar_suse set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:E got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:E got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:E got accepted.
With this,
kbdno longer generatesca-multi. That results in a missing entry in systemd'skbd-model-mapand yast2-country's test suite fails:Failures: 1) Keyboards .all_keyboards returns a list with all valid models from systemd Failure/Error: expect(valid_codes).to include(code) expected ["#", "#", "sg", "nl", "mk-utf", "trq", "uk", "is-latin1", "de", "la-latin1", "us", "ko", "ro-std", "...c", "cn-latin1", "cz-lat2-us", "es-cp850", "ir", "korean", "lt.std", "no-latin1", "ruwin_alt-UTF-8"] to include "ca-multi" # ./keyboard/test/keyboards_spec.rb:28:in `block (4 levels) in <top (required)>' # ./keyboard/test/keyboards_spec.rb:26:in `each' # ./keyboard/test/keyboards_spec.rb:26:in `block (3 levels) in <top (required)>'Is it intentional that
ca-multino longer exists?Seems so, yes. https://github.com/freedesktop/xkeyboard-config/commit/d46d0f40afb8cb7842959bdd15dfccbc9c041493 I guess we need to replace 'ca-multi' with 'ca-multix'.
Something for yast to fix: https://github.com/yast/yast-country/blob/794367058652f8b7f13ee675074cf52d70bc12cf/keyboard/src/lib/y2keyboard/keyboards.rb#L109
Needs yast2-country fix
Thanks @favogt I opened a pull request now. https://github.com/yast/yast-country/pull/298
@favogt Interested in doing a review of this trivial patch?
My review won't mean anything, the yast team needs to have a look...
Ok. I had hoped for an automatic merge that way. : "Merging is blocked - Merging can be performed automatically with 1 approving review."
Ok. Probably you don't have write access to this repository ...
Unignored: returned to active backlog.
Meanwhile YaST guys made a new release, which includes the needed change. https://bugzilla.suse.com/show_bug.cgi?id=1204573