Is this meant to stay there?

Roger Zhou (zzhou) - 11 months ago

It looks me the better place is

https://github.com/ClusterLabs/crmsh/issues

Comparing the resulting .rpm, it looks %doc contrib/* is a bit aggressive, and installs unneeded files:

/usr/share/doc/packages/crmsh/bash_completion.sh /usr/share/doc/packages/crmsh/git-hook-pre-commit

/usr/share/doc/packages/crmsh/pygments_crmsh_lexers /usr/share/doc/packages/crmsh/pygments_crmsh_lexers/init.py /usr/share/doc/packages/crmsh/pygments_crmsh_lexers/ansiclr.py /usr/share/doc/packages/crmsh/pygments_crmsh_lexers/crmsh.py /usr/share/doc/packages/crmsh/setup.py

@XinLiang, @nicholasyang, @shapbot: review reminder

Thanks! Most of the changes look great, except:

• Missing /usr/share/man/man8/profiles.8.gz
• Missing /usr/share/crmsh/crm.8.adoc, which crmsh needs to parse

Matej Cepl (mcepl) - 11 months ago

author

1. profiles.8

Except it never worked, see the logs from your current packages:

[   76s] make[1]: Circular doc/profiles.adoc <- doc/profiles.adoc dependency dropped.
...
[   76s]  /usr/bin/install -c -m 644 'doc/profiles.adoc' '/home/abuild/rpmbuild/BUILDROOT/crmsh-4.5.0+20230517.b2cb988b-734.1.x86_64/usr/share/man/man8/profiles.8'

This installs asciidoc unconverted file in the man directory and pretends it to be a manpage. It isn’t.

Source document is wrong and it breaks the generator:

(your package):

[   66s] asciidoc: WARNING: profiles.adoc: line 1: section title out of sequence: expected level 1, got level 2

in my package

[   30s] + a2x -f manpage doc/profiles.adoc
[   30s] asciidoc: FAILED: manpage document title is mandatory

1. crm.8.adoc fixed.

It is great to keep up with the latest build system. The change log should be more accuracy. Without a pyproject.toml, setuptools is the default backend and setup.py is still in used.