Overview

Request 1077258 accepted

Update to 6.5.0


Fabian Vogt's avatar
author target maintainer

Do the = %{real_version} reflect what the CMake code does?


Christophe Marin's avatar
source maintainer target maintainer

Yes, Qt itself requires the exact version and the CMake stuff does the same


Fabian Vogt's avatar
author target maintainer

qt6-location.changes has a duplicate -


Fabian Vogt's avatar
author target maintainer

# Broken and obsolete translations

Why are they upstream still?


Christophe Marin's avatar
source maintainer target maintainer

I suspect they don't care. They're community translations IIRC


Fabian Vogt's avatar
author target maintainer

I wonder whether the qt6-translations split is really worth it. qtbase is the vast majority of its size, then only the designer files are really noticable. The others don't really matter much.


Christophe Marin's avatar
source maintainer target maintainer

I suspect they're not for libraries. I'm not even sure qdebug / qcdebug can use translations if present


Fabian Vogt's avatar
author target maintainer

How are the translation packages meant to be pulled in?


Christophe Marin's avatar
source maintainer target maintainer

That's the same %package header as what %lang_package creates


Christophe Marin's avatar
source maintainer target maintainer

so if qt6-tools-designer is installed, the matching translation package is installed


Fabian Vogt's avatar
author target maintainer

Did you verify this? With lang packages, the magic actually happens in the dependency generators, which convert e.g. /usr/share/locale/kf5/de/LC_MESSAGES/kcm_autostart.mo into Provides: locale(plasma5-workspace:de)


Christophe Marin's avatar
source maintainer target maintainer

ok, my theory didn't work. I'll change back to the monolithic thing


Fabian Vogt's avatar
author target maintainer

LGTM otherwise

Request History
Fabian Vogt's avatar

Vogtinator created request

Update to 6.5.0


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop accepted review


Christophe Marin's avatar

krop approved review


Christophe Marin's avatar

krop accepted request

Thanks for the review, I'll make the final changes in KDE:Qt6 directly

openSUSE Build Service is sponsored by