Overview

Request 1086887 superseded

Context:

https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/I7GFWHUIX46M767GBXP5V5L6XUZXCSLM/

tldr: The goldendict shipped by openSUSE is in fact a fork, and now the fork is renamed.

This will replace the current goldendict package after getting accepted by the factory.


slb's avatar
author source maintainer

Please also assign me as this package's maintainer.



Atri Bhattacharya's avatar

Thanks for taking this up. Here are my comments about some minor issues:

  • Let us treat this as a new package, which it is. There is no need to copy over the changelog entries from another existing package (goldendict).
  • The Obsoletes should refer to the current version of goldendict in Factory, i.e. something like Obsoletes: goldendict < 1.5.1. This is so that we can get rid of the Obsoletes/Provides some time after the older goldendict has disappeared from Factory.
  • git init (Line number 83 in specfile) is probably unnecessary, otherwise please leave a comment in the specfile as to why it is needed. Likewise, the git BuildRequires should also be unnecessary.
  • Recommend running spec-cleaner over the specfile. If you want to preserve sections in BuildRequires, you may use section comments like the following:
# Section ffmpeg6
BuildRequires: foo1
BuildRequires: foo2
# /Section

Please consider superseding this sr with the above fixes.


slb's avatar
author source maintainer

Thanks for reviewing.

I have sent a request that supersedes this one with all the problems you mentioned fixed.

Request History
slb's avatar

slbtongying created request

Context:

https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/I7GFWHUIX46M767GBXP5V5L6XUZXCSLM/

tldr: The goldendict shipped by openSUSE is in fact a fork, and now the fork is renamed.

This will replace the current goldendict package after getting accepted by the factory.


openSUSE Build Service is sponsored by