This request is superseded by
request 1087745
(Show diff)
Overview
Request 1086887 superseded
Context:
https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/I7GFWHUIX46M767GBXP5V5L6XUZXCSLM/
tldr: The goldendict shipped by openSUSE is in fact a fork, and now the fork is renamed.
This will replace the current goldendict package after getting accepted by the factory.
- Created by slbtongying
- In state superseded
- Superseded by 1087745
Loading...
Request History
slbtongying created request
Context:
https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/I7GFWHUIX46M767GBXP5V5L6XUZXCSLM/
tldr: The goldendict shipped by openSUSE is in fact a fork, and now the fork is renamed.
This will replace the current goldendict package after getting accepted by the factory.
Please also assign me as this package's maintainer.
@MargueriteSu, @Thruth, @badshah400, @behrisch, @computersalat, @dbalentine, @fabio_s, @fschuett, @fsgaston, @gallochri, @glunardi, @grayswandir12, @kkirill, @lrupp, @lumnis, @maw, @mnhauke, @mpmiranda, @mseben, @repabuild, @vlj, @worldcitizen: review reminder
Thanks for taking this up. Here are my comments about some minor issues:
Obsoletes: goldendict < 1.5.1
. This is so that we can get rid of the Obsoletes/Provides some time after the older goldendict has disappeared from Factory.git init
(Line number 83 in specfile) is probably unnecessary, otherwise please leave a comment in the specfile as to why it is needed. Likewise, thegit
BuildRequires should also be unnecessary.spec-cleaner
over the specfile. If you want to preserve sections in BuildRequires, you may use section comments like the following:Please consider superseding this sr with the above fixes.
Thanks for reviewing.
I have sent a request that supersedes this one with all the problems you mentioned fixed.