Overview
Request 1102041 accepted
- update to 1.2.0:
* Added PDF text selection tools
* Added Setsquare Tool and Compass Tool
* Many more changes; for the full list, see
https://github.com/xournalpp/xournalpp/blob/release-1.2/CHANGELOG.md
- remove xournalpp-include.patch, fixed upstream
- Add xournalpp-return.patch: Fix control reaches end of non-void function
- Created by ithod
- In state accepted
-
Package maintainer:
badshah400
- Supersedes 1101894
Looks good, many thanks, except I would prefer if this "error: control reaches end of non-void function" were fixed with a patch and sent upstream instead of being ignored using cflags.
In src/core/pdf/popplerapi/PopplerGlibPage.cpp:113 it is just a g_assert which exits the code anyway - I felt a patch is not really required here...
Agree, but in case there is a more serious error somewhere else whereby the code reaches an end of non-void function without returning, your cflag will end up hiding it still. Much better to patch this rather in my opinion.
Request History
ithod created request
- update to 1.2.0:
* Added PDF text selection tools
* Added Setsquare Tool and Compass Tool
* Many more changes; for the full list, see
https://github.com/xournalpp/xournalpp/blob/release-1.2/CHANGELOG.md
- remove xournalpp-include.patch, fixed upstream
- Add xournalpp-return.patch: Fix control reaches end of non-void function
badshah400 accepted request
Many thanks.
