Overview

Request 1120043 accepted

- Import commit b53f364c264cd598d4210b64285a55d362b47b89
b53f364c26 test: install af_packet kernel module on openSUSE
86b7521a3c shared/wall: use logind if build without utmp support
65aac5858f errno-util: allow ERRNO_IS_* to accept types wider than int
8f93b89db4 basic/errno-util: add wrappers which only accept negative errno
1b815b3e76 Introduce RET_GATHER and use it in src/shared/

- Drop 0001-conf-parser-introduce-early-drop-ins.patch
The usage of drop-ins is now the official way for configuring systemd and its
various daemons on Factory/ALP.
See: https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/KWRBTAVQ6MGHVAHKDZZ6GIRX4RMHKHQ6/

- Ship the main configuration files in /usr/lib/
Besides the fact that shipping files in /etc is not recommended anymore, this
change will hopefully encourage users to customize the defaults via the mean
of drop-ins hence removing the risk of conflicts with downstream
customization.
In contrary, shipping empty directories *.conf.d/ in /etc is not a concern and
should suggest users to create drop-ins (bsc#1207056).

- systemd.spec: add files.portable and files.journal-remote

- Don't include entries listed in kbd-model-map.xkb-generated (provided by kbd
package) in kbd-model-map anymore. Yast, the only user of these entries,
directly parses kbd-model-map.xkb-generated now (bsc#1211104).

- tmpfiles-suse.conf: drop entries for /run/lock and /var/log/wtmp
/run/lock is now defined by filesystem package and wtmp has been replaced by
wtmpdb on TW.

Loading...

Ana Guerrero's avatar

@fbui hi!

There is an issue triggered by openQA test year_2038_detection. At some moment this test run:

utmpdump /var/log/wtmp

And this fails, see https://openqa.opensuse.org/tests/3674852#step/year_2038_detection/26


Ana Guerrero's avatar

FTR this comes from this change: "tmpfiles-suse.conf: drop entries for /run/lock and /var/log/wtmp", but we need to decide if we want to push this change now and ask for updating the test or not yet.


Franck Bui's avatar
author source maintainer

@kukuk can you please have a look ?


Thorsten Kukuk's avatar

The test is invalid. As announced, we stopped using /var/log/wtmp already month ago. There is no guarantee that this file contains sane data anymore already today.

Same is true for utmpdump /run/utmp, this will stop working shortly, too. Since it looks like the output is not used, I'm asking for what this test should be good.


Thorsten Kukuk's avatar

Yeah: "record_soft_failure('bsc#1188626 uttmpdump shows incorrect year for 2038 and beyond') if ($utmp_output !~ m/2038/sx || $wtmp_output !~ m/2038/sx);" This soft failure will never be fixed, as utmpdump depends on struct utmp, which is not fixable. So the full test is useless and should be removed.


Request History
Franck Bui's avatar

fbui created request

- Import commit b53f364c264cd598d4210b64285a55d362b47b89
b53f364c26 test: install af_packet kernel module on openSUSE
86b7521a3c shared/wall: use logind if build without utmp support
65aac5858f errno-util: allow ERRNO_IS_* to accept types wider than int
8f93b89db4 basic/errno-util: add wrappers which only accept negative errno
1b815b3e76 Introduce RET_GATHER and use it in src/shared/

- Drop 0001-conf-parser-introduce-early-drop-ins.patch
The usage of drop-ins is now the official way for configuring systemd and its
various daemons on Factory/ALP.
See: https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/KWRBTAVQ6MGHVAHKDZZ6GIRX4RMHKHQ6/

- Ship the main configuration files in /usr/lib/
Besides the fact that shipping files in /etc is not recommended anymore, this
change will hopefully encourage users to customize the defaults via the mean
of drop-ins hence removing the risk of conflicts with downstream
customization.
In contrary, shipping empty directories *.conf.d/ in /etc is not a concern and
should suggest users to create drop-ins (bsc#1207056).

- systemd.spec: add files.portable and files.journal-remote

- Don't include entries listed in kbd-model-map.xkb-generated (provided by kbd
package) in kbd-model-map anymore. Yast, the only user of these entries,
directly parses kbd-model-map.xkb-generated now (bsc#1211104).

- tmpfiles-suse.conf: drop entries for /run/lock and /var/log/wtmp
/run/lock is now defined by filesystem package and wtmp has been replaced by
wtmpdb on TW.


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Ana Guerrero's avatar

anag+factory set openSUSE:Factory:Staging:J as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:J"


Ana Guerrero's avatar

anag+factory accepted review

Picked "openSUSE:Factory:Staging:J"


Marcus Rueckert's avatar

darix accepted review

Accepted review for by_group opensuse-review-team request 1120043 from user anag+factory


Ana Guerrero's avatar

anag+factory accepted review

Staging Project openSUSE:Factory:Staging:J got accepted.


Ana Guerrero's avatar

anag+factory approved review

Staging Project openSUSE:Factory:Staging:J got accepted.


Ana Guerrero's avatar

anag+factory accepted request

Staging Project openSUSE:Factory:Staging:J got accepted.

openSUSE Build Service is sponsored by