Request 1132932 (accepted)

This request supersedes: request 1132897 (Show diff)

Overview

Request 1132932 accepted

- Modernize python-rpm.spec to stop using deprecated macros
(%python_build and %python_install).

- update to rpm-4.19.1

- fix Source url to match what is listed on https://rpm.org/download.html

- disable sysusers handling for now

- update to rpm-4.19.1
* new spec snippet support for dynamic spec generation
* new sysusers.d integration for automated user and group handling
* new CMake build system
* removal of various deprecated and/or unused APIs
* various internal code cleanups
- refreshed patches:
* brp-compress-no-img.patch
* brp.diff
* brpcompress.diff
* build.diff
* enable-postin-scripts-error.diff
* fileattrs.diff
* findlang.diff
* findsupplements.diff
* langnoc.diff
* macrosin.diff
* platformin.diff
* posttrans.diff
* refreshtestarch.diff
* rpm-findlang-inject-metainfo.patch

Created by dirkmueller 5 months ago
In state accepted
Supersedes 1132897

Submit rpm

Comments for request 1132932 13
Comments for request 1132897 1

Ana Guerrero (anag+factory) - 5 months ago

reviewer

A draft list of user/group that need fixing:

haclient
hacluster
openvswitch SR#1133086
ceph
cephadm
pcp SR#1133028
coroqnetd
fluidsynth
sanlock
munin
salt

Benjamin Greiner (bnavigator) - 4 months ago

11+--- python/setup.py.in.orig        2023-10-11 14:55:17.769593923 +0000
12++++ python/setup.py.in        2023-10-11 14:58:39.401200867 +0000
13+@@ -0,0 +1,52 @@
14++#!/usr/bin/env python
15++
16++from distutils.core import setup, Extension
17++import subprocess

It's 2024. Don't use distutils. It does not work with python312

Ana Guerrero (anag+factory) - 4 months ago

reviewer

Blocker for this 2024-01-10:

FTBFS llvm17 on i586 https://bugzilla.opensuse.org/show_bug.cgi?id=1218701
waiting users/groups update: pacemaker, resource-agents and libdlm: fixed with cluster-glue update: https://build.opensuse.org/request/show/1137062

Ana Guerrero (anag+factory) - 4 months ago

reviewer

waiting for llvm17/cluster-glue

Benjamin Greiner (bnavigator) - 4 months ago

What's the timeline for this? Do we need to backport sr#1137171 to rpm 4.18 with automake (https://github.com/rpm-software-management/rpm/pull/2341) so that the python312 build can go through earlier?

Ana Guerrero (anag+factory) - 4 months ago

reviewer

if the backport isn't very hard to do, I believe is the best option. This can take still some days because even if everything builds, we could discover new issues when running openQA tests.

Benjamin Greiner (bnavigator) - 4 months ago

@mls, where to submit to a backport for 4.18?

Benjamin Greiner (bnavigator) - 4 months ago

Worth noting that the python312 enablement is also still several days out. I don't expect the wxPython fix to be accepted anytime soon.

Ana Guerrero (anag+factory) - 4 months ago

reviewer

The fix for RPM/LLVM17 is ready so wait a bit, no need of backporting.

Ana Guerrero (anag+factory) - 4 months ago

reviewer

Now everything builds, the next step:

cycle:

Package rhash appears in cycle rpm/rhash/zlib/libdb-4_8/m4
Package libuv appears in cycle rpm/libuv/libdb-4_8/m4
Package cmake:mini appears in cycle rpm/cmake:mini/crypto-policies/python-rpm-macros
Package cmake appears in cycle rpm/cmake/crypto-policies/python-rpm-macros

user/groups, too long to copy summary:

nothing provides user and group(ceph) 
nothing provides user and group(cephadm)
nothing provides group(cockpit-wsinstance)
nothing provides user and group(coroqnetd) 
nothing provides user(fluidsynth)
nothing provides user and group(munin) 
nothing provides user and group(salt)

Dominique Leuenberger (dimstar) - 4 months ago

reviewer

For fluidsynth I created https://bugzilla.opensuse.org/show_bug.cgi?id=1219124 - that user is never actually created by the package (not anymore... was in the past)

Dominique Leuenberger (dimstar) - 4 months ago

reviewer

munin has been fixed: https://build.opensuse.org/request/show/1140564

Ana Guerrero (anag+factory) - 4 months ago

reviewer

cycle / user&groups

Dominique Leuenberger (dimstar) - 5 months ago

Source URLs are not valid. Try `osc service runall download_files`. ERROR: Failed to download "https://ftp.rpm.org/releases/rpm-4.19.x/rpm-4.19.1.tar.bz2"