Request 1152118 (accepted)

This request supersedes: request 1150086 (Show diff)

Overview

Request 1152118 accepted

- Fix syntax required for OBS source validator

- Upgrade to v255.3 (commit 96edf7ad1866172b994cafb4df49e27d68ce8e87)
See https://github.com/openSUSE/systemd/blob/SUSE/v255/NEWS for details.
- This includes the following bug fixes:
- commit 6e10405aa25fe5e76b740d9ec59730e3f4470c7a (bsc#1219766)
- The following patches have been rebased:
- 0002-rc-local-fix-ordering-startup-for-etc-init.d-boot.lo.patch
- 0008-sysv-generator-translate-Required-Start-into-a-Wants.patch
- 0009-pid1-handle-console-specificities-weirdness-for-s390.patch
- 5001-Revert-udev-update-devlink-with-the-newer-device-nod.patch
- 5002-Revert-udev-revert-workarounds-for-issues-caused-by-.patch
- The following patches have been removed since they're part of v255:
- 5003-cgroup-rename-TasksMax-structure-to-CGroupTasksMax.patch
- 5004-bus-print-properties-ignore-CGROUP_LIMIT_MAX-for-Mem.patch
- 5005-bus-print-properties-prettify-more-unset-properties.patch
- systemd-boot has been added to the list of the dependencies of the
systemd-testsuite package as the installation of the bootloader is now
tested.
- the following patches have been backported on top of v255.3:
96edf7ad18 service: Demote log level of NotifyAccess= messages to debug (bsc#1210113 jsc#PED-6214)
fdde7f26d6 vconsole-setup: don't fail if the only found vc is already used by plymouth (bsc#1218618)
f96c587d41 rules: set up tty permissions and group for /dev/hvc* nodes (bsc#1218137)
63a41b8899 vconsole-setup: remember the correct error value when open_terminal() fails
f51a2e038c vconsole-setup: handle the case where the vc is in KD_GRAPHICS mode more gracefully (bsc#1215282)
15025a04c4 test: make sure to install the filesystem package in the test image on SUSE
06fecfb635 test: make sure that sd-boot is installed before testing bootctl
1e8788ea68 test: install systemd-boot in openSUSE test images
6e2875ad43 test/test-shutdown.py: optionally display the test I/Os in a dedicated log file
4be1a801b4 test-69: send SIGTERM to ask systemd-nspawn to properly stop the container

Created by tsaupe 2 months ago
In state accepted
Supersedes 1150086

Submit systemd

Comments for request 1152118 8

Jan Engelhardt (jengelh) - 2 months ago

reviewer

The introduction of net-tools-deprecated looks wrong to me. I compared the %prep-ed non-built sources of the existing openSUSE:Factory/systemd(-254) to Base:System/systemd(-255) and found no new use or even mention of ifconfig, netstat, route, arp, ipmaddr or iptunnel in said diff, i.e.

osc co openSUSE:Factory/systemd; cd openSUSE/Factory/systemd; quilt setup -v systemd.spec; cd systemd-254-...; quilt pu -a;

(repeated with Base:System/systemd, then diff -dpru'd the two)

Thomas Blume (tsaupe) - 2 months ago

author source maintainer

The dependency comes from the systemd-testsuite package that is using the route command in the testsuite runs (see the DEBUGTOOLS parameter in test/test-functions in the systemd sources). We could replace that with 'ip route' but that would create a Requires to the iproute2 package.

Still the systemd-testsuite package is for our internal testing and rather not for the public. So, we could probably find another internal solution instead of this dependency.

So, should we remove it or is it ok to keep it when we only use the systemd-testsuite package internally?

Jan Engelhardt (jengelh) - 2 months ago

reviewer

Filed https://github.com/systemd/systemd/pull/31513 now. it's not in DEBUGTOOLS, it's in BASICTOOLS. And all it does it copy it around or something. All the test/test-network/systemd-networkd-tests.py test/units/testsuite-71.sh, and so on already use iproute, and unconditionally so.

Jan Engelhardt (jengelh) - 2 months ago

reviewer

patch accepted upstream, so starting with systemd-256, route is definitely not going to be needed anymore

Dominique Leuenberger (dimstar) - 2 months ago

reviewer

sec-review: https://bugzilla.suse.com/show_bug.cgi?id=1220249

Ana Guerrero (anag+factory) - 2 months ago

reviewer

waiting boo#1220249

Dominique Leuenberger (dimstar_suse) - 2 months ago

reviewer target maintainer

Unignored: returned to active backlog.

Dominique Leuenberger (dimstar) - about 2 months ago

reviewer

the now-building systemd:mini made things explode:

[    3s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -M pc,accel=kvm,usb=off,dump-guest-core=off,vmport=off -sandbox on -bios /usr/share/qemu/qboot.rom -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /var/cache/obs/worker/root_9/.mount/boot/kernel -initrd /var/cache/obs/worker/root_9/.mount/boot/initrd -append root=/dev/disk/by-id/virtio-0 rootfstype=ext4 rootflags=noatime elevator=noop nmi_watchdog=0 rw ia32_emulation=1 oops=panic panic=1 quiet console=hvc0 init=/.build/build -m 16384 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe,aio=io_uring -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe,aio=io_uring -device virtio-blk-pci,drive=swap,serial=1 -device virtio-serial,max_ports=2 -device virtconsole,chardev=virtiocon0 -chardev stdio,mux=on,id=virtiocon0 -mon chardev=virtiocon0 -chardev socket,id=monitor,server=on,wait=off,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4
[    4s] [    0.855340][    T1] systemd[1]: Failed to start Virtual Console Setup.
[    4s] [[0;1;31mFAILED[0m] Failed to start [0;1;39mVirtual Console Setup[0m.

[    4s] [    1.109064] dracut-pre-udev[312]: sh: line 1: /usr/lib/module-init-tools/unblacklist: No such file or directory
[    5s] [[0;1;31mFAILED[0m] Failed to start [0;1;39mVirtual Console Setup[0m.

[    5s] [[0;1;31mFAILED[0m] Failed to start [0;1;39mSwitch Root[0m.

[    6s] 
[    6s] Generating "/run/initramfs/rdsosreport.txt"
[    6s] 
[    6s] 
[    6s] Entering emergency mode. Exit the shell to continue.
[    6s] Type "journalctl" to view system logs.
[    6s] You might want to save "/run/initramfs/rdsosreport.txt" to a USB stick or /boot
[    6s] after mounting them and attach it to a bug report.
[    6s]

Request History

tsaupe created request 2 months ago

- Fix syntax required for OBS source validator

factory-auto added opensuse-review-team as a reviewer 2 months ago

Please review sources

factory-auto accepted review 2 months ago

Check script succeeded

anag+factory set openSUSE:Factory:Staging:M as a staging project 2 months ago

Being evaluated by staging project "openSUSE:Factory:Staging:M"

anag+factory accepted review 2 months ago

Picked "openSUSE:Factory:Staging:M"

licensedigger accepted review 2 months ago

jengelh added jengelh as a reviewer 2 months ago

net-tools-deprecated looks suspicious

jengelh declined review 2 months ago

Could not find evidence of net-tools-deprecated being needed; if it does, please let me knwo

jengelh declined request 2 months ago

Could not find evidence of net-tools-deprecated being needed; if it does, please let me knwo

dimstar_suse reopened request 2 months ago

Reopened via staging workflow.

dimstar_suse added factory-staging as a reviewer 2 months ago

Being evaluated by group "factory-staging"

dimstar_suse accepted review 2 months ago

Unstaged from project "openSUSE:Factory:Staging:M"

dimstar_suse declined request 2 months ago

Declined via staging workflow.

tsaupe reopened request 2 months ago

The reason for net-tools-deprecated is the route command that is used in the systemd-testsuite subpackage.
We could change that to 'ip route' but that would create a Requires to iproute2 then.

Still, the systemd-testsuite package is for our team internal testing and rather not for the public.
So we can probably find another internal solution.

So, can we keep t hat dependency in the systemd-testsuite package or should we remove it?

anag+factory set openSUSE:Factory:Staging:D as a staging project 2 months ago

Being evaluated by staging project "openSUSE:Factory:Staging:D"

anag+factory accepted review 2 months ago

Picked "openSUSE:Factory:Staging:D"

anag+factory added factory-staging as a reviewer 2 months ago

Being evaluated by group "factory-staging"

anag+factory accepted review 2 months ago

Unstaged from project "openSUSE:Factory:Staging:D"

anag+factory set openSUSE:Factory:Staging:G as a staging project 2 months ago

Being evaluated by staging project "openSUSE:Factory:Staging:G"

anag+factory accepted review 2 months ago