Overview
Request 398997 revoked
A command-line grep-like utility written in Java. It supports Java regular expressions, RE2J, POSIX options (excluding -E and -G), most GNU grep(1) options, options -O, -2 and -8. Read more at https://lists.opensuse.org/opensuse-factory/2016-05/msg00479.html
Project because of mk-configure with rpm macros, so this SR requires SR#398808.
- Created by DarkSS
- In state revoked
- Supersedes 398994
- Open review for legal-team
- Open review for openSUSE:Factory:Staging:adi:18
Request History
DarkSS created request
A command-line grep-like utility written in Java. It supports Java regular expressions, RE2J, POSIX options (excluding -E and -G), most GNU grep(1) options, options -O, -2 and -8. Read more at https://lists.opensuse.org/opensuse-factory/2016-05/msg00479.html
Project because of mk-configure with rpm macros, so this SR requires SR#398808.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger added legal-team as a reviewer
new_package: 0.6.0
licensedigger accepted review
factory-repo-checker accepted review
Builds for repo devel:tools:building/openSUSE_Factory
dimstar_suse added openSUSE:Factory:Staging:adi:18 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:18"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:adi:18
AndreasStieger declined review
Bundled binary downloaded jars.
Alternatives: ag (the_silver_searcher), ack
Not a build tool, wrong devel project?
AndreasStieger declined request
Bundled binary downloaded jars.
Alternatives: ag (the_silver_searcher), ack
Not a build tool, wrong devel project?
DarkSS reopened request
Jar isn't downloaded, it is locally created, see jrep-jar-howto.txt.
Sorry, I failed not find ag (too short name?) but ack is completely different.
devel:tools:building was chosen because of mk-configure-rpm-macros available.
AndreasStieger declined review
@DarkSS Uhm... It *is* downloaded:
mkcmake nodeps-all-jar
[INFO] Scanning for projects...
Downloading: https://repo.maven.apache.org/[...]
I see this as very problematic for on-going maintenance. As per https://en.opensuse.org/openSUSE:Packaging_guidelines#Bundling_of_multiple_projects I do not see that every effort was made to package these dependencies separately. Yes java/maven packaging is hard, and openSUSE does not have a good position here. But having packages like this in the distribution would only entrench this situation.
Based on that it's a no from me, both from review side and from security.
AndreasStieger declined request
@DarkSS Uhm... It *is* downloaded:
mkcmake nodeps-all-jar
[INFO] Scanning for projects...
Downloading: https://repo.maven.apache.org/[...]
I see this as very problematic for on-going maintenance. As per https://en.opensuse.org/openSUSE:Packaging_guidelines#Bundling_of_multiple_projects I do not see that every effort was made to package these dependencies separately. Yes java/maven packaging is hard, and openSUSE does not have a good position here. But having packages like this in the distribution would only entrench this situation.
Based on that it's a no from me, both from review side and from security.
DarkSS revoked request
Ok, thank you for the review.