Overview

Request 453490 accepted

now with patch changes in the file.

Dominique Leuenberger's avatar
Dominique Leuenberger (dimstar) -
reviewer target maintainer

Now with a bot enabled that checks for most basic issues (like patches not mentioned in .changes :P )

Tobias Mueller's avatar
Tobias Mueller (tobiasmue) -
author

"Review got accepted" is a good sign, right? :) If not, I'm happy to fix things up.

Dominique Leuenberger's avatar
Dominique Leuenberger (dimstar) -
reviewer target maintainer

At least the bot was happy; that does not mean that I will be happy... But in your favor I will let it pass and fix it up to our style...

The most important changes will be:

  • Replace '*' with '+'; * is 'fun' in some ways that it tries to mess up indenting rules in rpm. I hate it ;)
  • Re-order the .changes entry: First comes the 'Update to version blabla' with all the things it brings, followed by changes done to the package.
Request History
Tobias Mueller's avatar

tobiasmue created request

now with patch changes in the file.

Dominique Leuenberger's avatar

dimstar added gnome-review-bot as a reviewer

GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded

Dominique Leuenberger's avatar

dimstar accepted review

Dominique Leuenberger's avatar

dimstar approved review

Dominique Leuenberger's avatar

dimstar accepted request

xin-

openSUSE Build Service is sponsored by
Places