Overview
Request 481647 accepted
- Update to sanlock 3.4.0
- Enable fence_sanlockd so that lvm2 can use the new lvmlocked
feature in cluster environment
* fix unpackaged file - /usr/sbin/rcfence_sanlockd
* refresh suse-no-date-time.patch to cover the same issue
in fence_sanlockd
* adjust fence_sanlockd.init and suse-systemd.patch
- Enable sanlk-reset subpackage
- Fix "undefined symbol to io_suspend" at runtime, bsc#1030060
suse-fix-link-errors.patch
I have several comments, suggestions, and nits for this request.
changelog: Please add the "Update to sanlock 3.4.0" entry after kukuk's entry on Mar 11. Factory already contains kukuk's change, so we cant reorder the changelog enrites. Also, include "suse-fix-link-errors.patch" in the last changelog entry. E.g.
- Enable sanlk-reset subpackage
- Fix "undefined symbol to io_suspend" at runtime, bsc#1030060 suse-fix-link-errors.patch
spec file:
+install -D -m 0755 %SOURCE5 $RPM_BUILD_ROOT/usr/lib/systemd/systemd-fence_sanlockd
Is it necessary to call this "helper" from the systemd service file? Is it possible to just invoke fence_sanlockd directly. E.g. from the fence_sanlockd.service file
+EnvironmentFile=-/etc/sysconfig/fence_sanlockd +ExecStart=/usr/sbin/fence_sanlockd start $FENCESANLOCKDOPTS +ExecStop=/bin/kill -TERM $MAINPID +ExecReload=/bin/kill -HUP $MAINPID
Maybe the helper is needed to deal with steps in the 'stop' action?
fence_sanlockd.init: -# Required-Start: $time $syslog $remote_fs +# Required-Start: $time $syslog
Are you sure remote_fs is not needed? E.g. is there a need to have a network fs available before starting fence_sanlockd?
- echo -n "cannot stop while fence_sanlock $agent_pid is running"
- rc_failed 1
- rc_status -v
- rc_exit
- echo -n "cannot stop while $agent $agent_pid is running"
- rc_failed
- exit
You should maintain the rc_* stuff here, e.g.
- echo -n "cannot stop while $agent $agent_pid is running"
- rc_failed 1
- rc_status -v
- rc_exit
Same comment in a few other places as well. Can you fixup these nits and submit another request? We can talk via email or IRC if you have questions about my comments. Thanks!
Request History
ZRen created request
- Update to sanlock 3.4.0
- Enable fence_sanlockd so that lvm2 can use the new lvmlocked
feature in cluster environment
* fix unpackaged file - /usr/sbin/rcfence_sanlockd
* refresh suse-no-date-time.patch to cover the same issue
in fence_sanlockd
* adjust fence_sanlockd.init and suse-systemd.patch
- Enable sanlk-reset subpackage
- Fix "undefined symbol to io_suspend" at runtime, bsc#1030060
suse-fix-link-errors.patch
jfehlig accepted request
It's a big change, but mostly related to fence-sanlock, so ACK. I'll defer forwarding the request to Factory, giving time for any cutting-edge sanlock users to report issues :-).
We can let the auto-submit bot grab it.