Overview
Request 497321 superseded
test commit which might workaround the gcc7 issue in staging
- only optimize with -O2 for openSUSE > 13.2/Leap 42 (gcc7)
(boo#1040105)
- Created by wrosenauer
- In state superseded
- Superseded by 498015
-
Open review for
opensuse-review-team
- Open review for openSUSE:Factory:Staging:C
Request History
wrosenauer created request
test commit which might workaround the gcc7 issue in staging
- only optimize with -O2 for openSUSE > 13.2/Leap 42 (gcc7)
(boo#1040105)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
dimstar_suse set openSUSE:Factory:Staging:C as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:C"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:C
dimstar_suse accepted review
Removing from openSUSE:Factory:Staging:C, re-evaluation needed
dimstar_suse added factory-staging as a reviewer
Requesting new staging review
factory-repo-checker accepted review
Builds for repo mozilla:Factory/openSUSE_Factory
dimstar_suse set openSUSE:Factory:Staging:C as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:C"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:C
licensedigger accepted review
ok
superseded by 498015
Based on the comments in boo#1040105 - will r590 be submitted too or is there more work needed? (currently we have r589 in Staging:C, which fails for UI errors)
r590 could be submitted but I would rather try to remove the first workaround and see what happens.
Because currently I think we just have doubled the thing:
export CFLAGS="%{optflags} -fno-strict-aliasing" . . .
gcc7 (boo#1040105)
%if 0%{?suse_version} > 1320 ac_add_options --enable-optimize="-g -O2" %endif
Is it ok to do one more trial w/o the latter if it works?
yes, sure - in the end I would not want a submission which you as maintainer cannot support in good faith