Overview
Request 514739 superseded
- Created by Mailaender
- In state superseded
- Supersedes 514713
- Superseded by 526471
- Open review for openSUSE:Factory:Staging:adi:319
Request History
Mailaender created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:319"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:319
factory-repo-checker accepted review
Builds for repo games/openSUSE_Tumbleweed
licensedigger accepted review
ok
dimstar_suse added repo-checker as a reviewer
Please recheck
repo-checker accepted review
cycle and install check passed
namtrac declined review
Rejecting with alarrosa's comments:
"Would it be possible to specify all the files in the %files section instead of using wildcards? Note that in the case of %{_libdir}/%{name}/* Since it's creating a directory just for this package, it's enough to replace it with %{_libdir}/%{name} (so it includes the directory and all its contents recursively). In the other cases, the directories should not be owned by this package, so all filenames should be specified."
Also please run spec-cleaner and use make -j1 instead of plain make.
namtrac declined request
Rejecting with alarrosa's comments:
"Would it be possible to specify all the files in the %files section instead of using wildcards? Note that in the case of %{_libdir}/%{name}/* Since it's creating a directory just for this package, it's enough to replace it with %{_libdir}/%{name} (so it includes the directory and all its contents recursively). In the other cases, the directories should not be owned by this package, so all filenames should be specified."
Also please run spec-cleaner and use make -j1 instead of plain make.
Would it be possible to specify all the files in the %files section instead of using wildcards? Note that in the case of %{_libdir}/%{name}/* Since it's creating a directory just for this package, it's enough to replace it with %{_libdir}/%{name} (so it includes the directory and all its contents recursively). In the other cases, the directories should not be owned by this package, so all filenames should be specified.
@alarrosa: just a notice: @Mailaender has OBS comment notifications disabled and never sees them. The best course if to decline a request if you expect a reply from him