Request 517276 (superseded)

This request is superseded by request 533408 (Show diff)

Overview

Request 517276 superseded

- Add new package robinhood.

Created by eeich over 6 years ago
In state superseded
Superseded by 533408
Open review for repo-checker
Open review for openSUSE:Factory:Staging:adi:76

Submit robinhood

Comments for request 517276 8

mrdocs - over 6 years ago

robinhood.x86_64: E: devel-file-in-non-devel-package (Badness: 50) /usr/lib64/robinhood/librbh_mod_alerter.so robinhood.x86_64: E: devel-file-in-non-devel-package (Badness: 50) /usr/lib64/robinhood/librbh_mod_checker.so robinhood.x86_64: E: devel-file-in-non-devel-package (Badness: 50) /usr/lib64/robinhood/librbh_mod_common.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package.

robinhood-tests.x86_64: E: arch-dependent-file-in-usr-share (Badness: 590) /usr/share/robinhood/tests/create-random This package installs an ELF binary in the /usr/share hierarchy, which is reserved for architecture-independent files.

These really should be fixed. Thanks.

Egbert Eich (eeich) - over 6 years ago

author source maintainer

The devel-file-in-non-devel-package is BS - one of the false positives that rpmlint likes to generate. The files in /usr/lib64/robinhood/ are modules, no development libraries. Have a look at /usr/lib<64>/xorg/modules/ same thing. One could create an rpmlintrc to paper over the incapabilities of rpmlint. The 2nd issue should be fixed: this should really use the %_libexec path.

Dominique Leuenberger (dimstar) - over 6 years ago

reviewer

rpmlint actually only reports it if the .so files are links - which would be an indication of error in a modules directory to start with (modules should be build with -module,-avoid-version autoconf paramters)

Dominique Leuenberger (dimstar) - over 6 years ago

reviewer

lrwxrwxrwx 1 dimstar users    27 Aug 28 17:27 librbh_mod_alerter.so -> librbh_mod_alerter.so.0.0.0*
lrwxrwxrwx 1 dimstar users    27 Aug 28 17:27 librbh_mod_alerter.so.0 -> librbh_mod_alerter.so.0.0.0*
-rwxr-xr-x 1 dimstar users 19184 Aug 25 23:35 librbh_mod_alerter.so.0.0.0*
lrwxrwxrwx 1 dimstar users    27 Aug 28 17:27 librbh_mod_checker.so -> librbh_mod_checker.so.0.0.0*
lrwxrwxrwx 1 dimstar users    27 Aug 28 17:27 librbh_mod_checker.so.0 -> librbh_mod_checker.so.0.0.0*
-rwxr-xr-x 1 dimstar users 19216 Aug 25 23:35 librbh_mod_checker.so.0.0.0*
lrwxrwxrwx 1 dimstar users    26 Aug 28 17:27 librbh_mod_common.so -> librbh_mod_common.so.0.0.0*
lrwxrwxrwx 1 dimstar users    26 Aug 28 17:27 librbh_mod_common.so.0 -> librbh_mod_common.so.0.0.0*
-rwxr-xr-x 1 dimstar users 18864 Aug 25 23:35 librbh_mod_common.so.0.0.0*

definitively not a correct directory layout for modules/plugins - rpmlint is once again right

Bernhard Wiedemann (bmwiedemann) - over 6 years ago

Note: binaries differ for each build from an embedded date like

Build: 2017-08-26 20:37:49

proposing a fix upstream: https://github.com/cea-hpc/robinhood/pull/83

Dominique Leuenberger (dimstar) - over 6 years ago

reviewer

Index: robinhood-3.0/src/modules/Makefile.am
===================================================================
--- robinhood-3.0.orig/src/modules/Makefile.am
+++ robinhood-3.0/src/modules/Makefile.am
@@ -4,32 +4,32 @@ pkglib_LTLIBRARIES=

 pkglib_LTLIBRARIES+=librbh_mod_common.la
 librbh_mod_common_la_SOURCES=common.c mod_internal.c mod_internal.h
-librbh_mod_common_la_LDFLAGS=-version-info 0:0:0
+librbh_mod_common_la_LDFLAGS=-avoid-version
 librbh_mod_common_la_LIBADD=-lz

 pkglib_LTLIBRARIES+=librbh_mod_alerter.la
 librbh_mod_alerter_la_SOURCES=alerter.c mod_internal.c mod_internal.h
-librbh_mod_alerter_la_LDFLAGS=-version-info 0:0:0
+librbh_mod_alerter_la_LDFLAGS=-avoid-version

 pkglib_LTLIBRARIES+=librbh_mod_checker.la
 librbh_mod_checker_la_SOURCES=checker.c mod_internal.c mod_internal.h
-librbh_mod_checker_la_LDFLAGS=-version-info 0:0:0
+librbh_mod_checker_la_LDFLAGS=-avoid-version

 if LUSTRE_HSM
 pkglib_LTLIBRARIES+=librbh_mod_lhsm.la
 librbh_mod_lhsm_la_SOURCES=lhsm.c mod_internal.h
-librbh_mod_lhsm_la_LDFLAGS=-version-info 0:0:0
+librbh_mod_lhsm_la_LDFLAGS=-avoid-version
 librbh_mod_lhsm_la_LIBADD=-llustreapi [@LIBUUID_LIBS](https://build.opensuse.org/users/LIBUUID_LIBS)@
 endif
 if HSM_LITE
 pkglib_LTLIBRARIES+=librbh_mod_backup.la
 librbh_mod_backup_la_SOURCES=backup.c mod_internal.c mod_internal.h
 librbh_mod_backup_la_CFLAGS=$(AM_CFLAGS) -D_HSM_LITE
-librbh_mod_backup_la_LDFLAGS=-version-info 0:0:0
+librbh_mod_backup_la_LDFLAGS=-avoid-version
 endif
 if SHOOK
 pkglib_LTLIBRARIES+=librbh_mod_shook.la
 librbh_mod_shook_la_SOURCES=shook.c backup.c mod_internal.h
 librbh_mod_shook_la_CFLAGS=$(AM_CFLAGS) -DHAVE_SHOOK
-librbh_mod_shook_la_LDFLAGS=-version-info 0:0:0
+librbh_mod_shook_la_LDFLAGS=-avoid-version
 endif

would fix the devel-files-in-non-devel-package errors

Egbert Eich (eeich) - over 6 years ago

author source maintainer

You're right. Thanks!

Egbert Eich (eeich) - over 6 years ago

author source maintainer

Neither /etc/apache2 nor /srv/www should be provided by this package. Instead, these directories should be supplied by packages that are required. The lines: %dir %{_sysconfdir}/%{confdir_www} and %dir %{installdir_www} should probably be deleted. All files and directory in /etc/apach2.d should probably be owned by root:root.