Overview
Request 517313 accepted
- go-race: add compiler-rt TSAN binary, necessary for the race detector builds
to work. This requires building compiler-rt from source (becuase upstream Go
stores precompiled binaries in the tree, and we cannot use them). In
addition, a %check was added purely to ensure that we don't install the wrong
version of compiler-rt. boo#1052528
- go-rpmlintrc: add some entries to address the .syso additions.
great catch with the binaries that we shipped, we shipped them even for windows and other non-linux distros, which is really useless
also creating a separate package makes sense to me
lgtm
Shouldn't there be an ifarch %{tsan_arch} block around line 83 and 126?
It's not necessary because the source is provided in both cases, regardless of arch. But maybe we should just %ifarch it out. My concern is that the %setup flags might break, but I can give it a shot.
Request History
cyphar created request
- go-race: add compiler-rt TSAN binary, necessary for the race detector builds
to work. This requires building compiler-rt from source (becuase upstream Go
stores precompiled binaries in the tree, and we cannot use them). In
addition, a %check was added purely to ensure that we don't install the wrong
version of compiler-rt. boo#1052528
- go-rpmlintrc: add some entries to address the .syso additions.
jordimassaguerpla accepted request
this LGTM, but I have not tested it. I will trust Aleksa on that.
@MargueriteSu: review reminder
Why you changed the license for the doc package?
I didn't change it, I added the same license as the main package? Or should I not include that (is it by default inherited from the main package)?
In that case is ok.
A part from the doc package license, this looks good.