Overview
Request 526186 superseded
- Fix prerequirement of groups tty and uuidd (boo#1057937).
- Update to version 2.30.1:
Bugfix release, more details at:
https://www.kernel.org/pub/linux/utils/util-linux/v2.30/v2.30.1-ReleaseNotes
- Drop upstreamed patch
util-linux-lscpu-cleanup-DMI-detection-return-codes.patch
- Make sure group tty is defined
- Created by sbrabec
- In state superseded
- Supersedes 511932 526078
- Superseded by 546087
-
Open review for
opensuse-review-team
Request History
sbrabec created request
- Fix prerequirement of groups tty and uuidd (boo#1057937).
- Update to version 2.30.1:
Bugfix release, more details at:
https://www.kernel.org/pub/linux/utils/util-linux/v2.30/v2.30.1-ReleaseNotes
- Drop upstreamed patch
util-linux-lscpu-cleanup-DMI-detection-return-codes.patch
- Make sure group tty is defined
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse set openSUSE:Factory:Staging:B as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:B"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:B
repo-checker accepted review
cycle and install check passed
dimstar_suse declined review
Replaced by sr#528604
dimstar_suse declined request
Replaced by sr#528604
dirkmueller superseded request
superseded by 546087
+%if 0%{?suse_version} >= 1330 +%pre -n uuidd +%else +%pre -n uuiddDo I miss something? :) would probably have been cleaener to move the condition below %pre and actually 'just do`:
%pre -n uuidd %if 0%{?suse_version} < 1330 /usr/sbin/groupadd -r uuidd 2>/dev/null || : /usr/sbin/useradd -r -g uuidd -c "User for uuidd" \ -d /var/run/uuidd uuidd 2>/dev/null || : %endif %{service_add_pre uuidd.socket uuidd.service}It somewhat looks more readable to me.
Also note that ignoring errors from useradd (or other tools) in %pre is a very bad idea.