Summary: aa? You may as well bump the dpdk version since we don't have 16.XX anymore This does not look right 'export CONFIG_RTE_MAJOR_ABI=17.08' What if the user bumps dpdk later on? Why are you exporting it? And why are you using it like this? Maybe simply set it to 1 if upstream does not provide a proper soname? Extra whitespace in like 73? Why have empty %post, %postun? make -j is really bad. This will use infinite threads. Better use the %{?_smp_mflags} macro

Nirmoy I think I understand what you're thinking of doing with the MAJOR_ABI stuff but I don't believe that's required. This tool/package links against DPDK and I believe we do not care of shipping multiple versions of the libs produced by this package, do we? Those libs (e.g. librte_lua.so) are used by this app only... All you need to make sure - as mentioned by Markos already - is to have the correct BuildRequires to use the DPDK version we currently ship in factory (17.08).

Also, another suggestion, looking at your patch. Why don't you suggest a fix upstream to adopt the ?= operator rather than the := in the Makefile? In that way you won't need to ship your patch (fixing the paths) rather setting and exporting the variables used to your preferred path.

Example: This: COMMON_LIB := $(COMMON_PRE)/$(RTE_TARGET) Would become: COMMON_LIB ?= $(COMMON_PRE)/$(RTE_TARGET)

And in the .spec you could do: export COMMON_LIB=$(COMMON_PRE)/$(RTE_TARGET)/lib

any suggestions on how to move forward with this?

The request is clear candidate for decline. Expecting that the submitter will fix following problems and create new request that will supersede this one.

Needs fix: - Invalid summary. - No description. - And minor style problems: * Text formatting of spec file (needs spec-cleaner) * Empty %post and %postun make no sense.

@EGDFree, @Fisiu, @Ignotusp, @anicka, @azouhr, @darix, @dirkmueller, @hreinecke, @jbohac, @jmcdough, @joachimwerner, @kukuk, @lrupp, @markoschandras, @mkudlvasr, @mpmiranda, @mrdocs, @mseben, @msmeissn, @mtomaschewski, @mvarlese, @namtrac, @ndas, @nemysis, @olh, @prusnak, @psmt, @rhafer, @rmax, @sax2, @sbrabec, @seife, @varkoly: review reminder