Overview

Request 542489 accepted

- Add create_32bit-patterns_file.pl as source
- guard some sle specifics with %is_opensuse

- Ensure openSUSE patterns aren't provided / obsoletes when
building for SLE.
- Add Recommend to enhanced_base: OpenIPMI bash-completion cpp
cryptconfig expect ipmitool lvm2 m4 make mksh mutt quota
supportutils sysfsutils tcsh w3m lsof psmisc sudo.
- Add grub2-branding-SLE recommends on enhanced_base on SLE.
- Fix description of minimal_base on SLE.

- Remove salt-minion from base [bsc#1064266]

- minimal_base doesn't need to be visable in yast
- Basesystem and Documentation don't need 32bit patterns
- Regenerate 32bit patterns

- Move tar to minimal pattern, too many low level tools assume
tar is installed by default

- Recommend glibc-locale from minimal_base not enhanced_base,
we install in en_US, so we need a locale one way or the other.
Requiring it from enhanced_base now to make sure it's part of
regular installations (but can be disabled for e.g. chroots
with C locale - bsc#1057377)

- base pattern now obsoletes and provides Minimal to make
SLES-12 upgrades smoother (bsc#1062164)
- x11_enhanced pattern now obsoletes and provides Minimal to make
SLED-12 upgrades smoother (bsc#1062164)


Leap Reviewbot's avatar

home:lnussel/patterns-base@1 -> openSUSE:Leap:15.0/patterns-base

expected origin is 'openSUSE:Factory' (changed)

Package is in SUSE:SLE-15:GA/patterns-base

the submitted sources are NOT in Factory

NOTE: if you think the automated review was wrong here, please talk to the release team before reopening the request


Dominique Leuenberger's avatar
+- Add Recommend to enhanced_base: OpenIPMI bash-completion cpp
+  cryptconfig expect ipmitool lvm2 m4 make mksh mutt quota
+  supportutils sysfsutils tcsh w3m lsof psmisc sudo.

Really? enhanced_base is what we install on a default setup. Do we really want to put all those tools onto a standard oS install?

  • make/m4/cpp are definitively 'devel tools' - and not 'base system tools'
  • lsof, sudo and psmisc are already recommended by enhanced_base as far as I can see
  • openipmi and ipmitool I have to admit I don't know if it makes sense on openSUSE
  • cryptconfig and sysfsutils probably make sense
  • w3m on every machine?

  • +- minimal_base doesn't need to be visable in yast -> you will reintroduce boo#1049997


Dominique Leuenberger's avatar

+- Rename xterm-bin back to xterm, we still have xterm.rpm

Yes, we still have an xterm.rpm, but it is only a launcher around xterm (the .desktop file); advanced users simply do not ever run xterm from a DE laucnher like GNOME (which is why xterm-bin is split from xterm)


Ludwig Nussel's avatar
author source maintainer

those changes come from SLE. can we merge this please and unify again? This blocks me with firewalld atm.

@simotek?

Request History
Ludwig Nussel's avatar

lnussel created request

- Add create_32bit-patterns_file.pl as source
- guard some sle specifics with %is_opensuse

- Ensure openSUSE patterns aren't provided / obsoletes when
building for SLE.
- Add Recommend to enhanced_base: OpenIPMI bash-completion cpp
cryptconfig expect ipmitool lvm2 m4 make mksh mutt quota
supportutils sysfsutils tcsh w3m lsof psmisc sudo.
- Add grub2-branding-SLE recommends on enhanced_base on SLE.
- Fix description of minimal_base on SLE.

- Remove salt-minion from base [bsc#1064266]

- minimal_base doesn't need to be visable in yast
- Basesystem and Documentation don't need 32bit patterns
- Regenerate 32bit patterns

- Move tar to minimal pattern, too many low level tools assume
tar is installed by default

- Recommend glibc-locale from minimal_base not enhanced_base,
we install in en_US, so we need a locale one way or the other.
Requiring it from enhanced_base now to make sure it's part of
regular installations (but can be disabled for e.g. chroots
with C locale - bsc#1057377)

- base pattern now obsoletes and provides Minimal to make
SLES-12 upgrades smoother (bsc#1062164)
- x11_enhanced pattern now obsoletes and provides Minimal to make
SLED-12 upgrades smoother (bsc#1062164)


Ludwig Nussel's avatar

lnussel_factory added openSUSE:Leap:15.0:Staging:B as a reviewer

Being evaluated by staging project "openSUSE:Leap:15.0:Staging:B"


Ludwig Nussel's avatar

lnussel_factory accepted review

Picked openSUSE:Leap:15.0:Staging:B


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Leap Reviewbot's avatar

leaper added patterns-base as a reviewer

Submission for patterns-base by someone who is not maintainer in the devel project (system:install:head). Please review


Leap Reviewbot's avatar

leaper added opensuse-review-team as a reviewer


Leap Reviewbot's avatar

leaper added legal-auto as a reviewer


Leap Reviewbot's avatar

leaper declined review

review failed


Leap Reviewbot's avatar

leaper declined request

review failed


Ludwig Nussel's avatar

lnussel reopened request

reopen


Leap Reviewbot's avatar

leaper accepted review

manual override


Saul Goodman's avatar

licensedigger accepted review

ok


Ludwig Nussel's avatar

lnussel accepted review


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Dominique Leuenberger's avatar

dimstar accepted review


Ludwig Nussel's avatar

lnussel_factory accepted review

ready to accept


Ludwig Nussel's avatar

lnussel_factory approved review

ready to accept


Ludwig Nussel's avatar

lnussel_factory accepted request

Accept to openSUSE:Leap:15.0

openSUSE Build Service is sponsored by