Overview

Request 557687 accepted

No description set
Loading...

Dominique Leuenberger's avatar

okular fails to build

[   67s] CMake Error in generators/spectre/CMakeLists.txt:
[   67s]   Cannot find source file:
[   67s] 
[   67s]     MODULE
[   67s] 
[   67s]   Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
[   67s]   .hxx .in .txx

not guaranteed to be cmake related, but chances are high

CC @luca_b @Vogtinator @alarrosa @wolfi323 @cgiboudeaux



Dominique Leuenberger's avatar

Needs KDE Applications 17.12 to land


Dominique Leuenberger's avatar

Unignored: returned to active backlog.


Dominique Leuenberger's avatar

Likely also related to the failure of libkollab-qt5:

[   64s] -- Detecting CXX compile features - done
[   64s] CMake Deprecation Warning at /usr/share/cmake/Modules/FeatureSummary.cmake:671 (message):
[   64s]   SET_PACKAGE_INFO is deprecated.  Use SET_PACKAGE_PROPERTIES instead.
[   64s] Call Stack (most recent call first):
[   64s]   cmake/modules/MacroLogFeature.cmake:96 (SET_PACKAGE_INFO)
[   64s]   CMakeLists.txt:61 (macro_log_feature)
[   64s] 
[   64s] 
[   64s] -- Boost version: 1.65.1
[   64s] CMake Error at cmake/modules/FindSWIG.cmake:4 (find_package_handle_standard_args):
[   64s]   Unknown CMake command "find_package_handle_standard_args".
[   64s] Call Stack (most recent call first):
[   64s]   CMakeLists.txt:80 (find_package)
[   64s] 
[   64s] 

Christophe Giboudeaux's avatar

there's a DR for libkolab-qt5. SR#555251


Wolfgang Bauer's avatar

And the libkolab-qt5 build failure is rather related to the KDE Applications update AFAICT (kcalcore in particular).

It already fails with cmake 3.9.5 (and even 3.5.2 on Leap 42.x) in KDE:Applications.


Luca Beltrame's avatar

libkolab-qt5 will no longer be needed with Applications 17.12. Once I file them for submission, I'll also file a DR for libkolab-qt5.


Wolfgang Bauer's avatar

Fixing this cmake error will just result in compile failures later on anyway because of the API changes in kcalcore.



Wolfgang Bauer's avatar

Everywhere. kcalcore has been ported from KTimeZone to QTimeZone, KDateTime to QDateTime, and so on. And that's reflected in the API.

The fix for this cmake error in libkolab-qt5 would be easy btw: sed -i '1 a include(FindPackageHandleStandardArgs)' cmake/modules/FindSWIG.cmake

But it would still be necessary to port it to the new API, which is far from easy...



Christophe Giboudeaux's avatar

I'm afraid this discussion is getting nowhere. There's no need to fix something we're removing from factory nor fix some code nothing uses.


Wolfgang Bauer's avatar

Well, I just replied to your question... ;-)


Christophe Giboudeaux's avatar

That's (one of) the reason(s) why upstream ships a libkolab copy within kdepim-runtime. Contributing to libkolab is a pain for various reasons.

Request History
Martin Pluskal's avatar

pluskalm created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:N as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:N"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:N


Dominique Leuenberger's avatar

dimstar accepted review


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by