Overview
Request 559388 revoked
- Use spaces instead of tabs in the patches (as does the original
source code) to avoid confusion.
- n_If-auth-with-credentials-for-hostname-fails-retry-with-XAUTHLOCALHOSTNAME.patch
* If authentication (with *stage == 0) failed and the variable
XAUTHLOCALHOSTNAME wasn't set, we were never getting to stage 2
in the original patch, causing calls to xcb_connect_to_display
to be stuck in an infinite loop.
Now we also go to stage 2 if the variable isn't set.
- Created by aaronpuchert
- In state revoked
- 4 package maintainers
Request History
aaronpuchert created request
- Use spaces instead of tabs in the patches (as does the original
source code) to avoid confusion.
- n_If-auth-with-credentials-for-hostname-fails-retry-with-XAUTHLOCALHOSTNAME.patch
* If authentication (with *stage == 0) failed and the variable
XAUTHLOCALHOSTNAME wasn't set, we were never getting to stage 2
in the original patch, causing calls to xcb_connect_to_display
to be stuck in an infinite loop.
Now we also go to stage 2 if the variable isn't set.
michalsrb declined request
Thank you for the fix. I've added fix for the non-local address case on top of it and submitted it in: https://build.opensuse.org/request/show/561848
aaronpuchert revoked request
The source package 'libxcb' has been removed
If anyone is wondering, this fixes a (quite serious) problem with boinc-client, which uses the X screen saver extension to determine whether the computer is "in use". However, in OpenSUSE the standard configuration is that the boinc-client daemon doesn't have access to the X server, meaning that the call to XOpenDisplay should fail. With the changes in request 556398 however, the call never returns. As a result, the daemon becomes unresponsive and spams the system log with tens of thousands of messages per second.
@eeich, @michalsrb, @mstaudt, @sndirsch: review reminder
It sounds like this would fix https://bugzilla.opensuse.org/show_bug.cgi?id=1073996 as well.
I will review and test it as soon as I can!
Actually it still goes into infinite loop if the DISPLAY is a non-local address. The code should just proceed to stage 2 no matter what.