Overview

Request 571262 accepted

- Fix almost-empty SRPM description.
- Fix faulty leading whitespace in descriptions.
- Reduce size of %if..%endif blocks to minimum.
- Remove pkgconfig requires that are already automatically detected.
- kronosnet-1.0 is available now(bsc#1077702)
Added: kronosnet-1.0.tar.gz
kronosnet.spec
kronosnet.changes

Loading...

Bin Liu's avatar

Please do not push this package to SLE15, it is just for corosync-3, which should be in SLE15 SP1 or later


Bin Liu's avatar

Hi, is there anything blocking this request?


mrdocs's avatar

Looks ok, but please fix the wrong rpm group warnings and the spec file capitalization warnings. Thanks!


Jan Engelhardt's avatar

rpmlint is clueless and wrong here; ignore.


Bin Liu's avatar

@jengelh I did not quite understand what you mean, could you explain more. thanks:)


Jan Engelhardt's avatar

rpmlint complains about things like "bzip2", but "bzip2" is in fact the spelling chosen for the brand/product. Do not change to "Bzip2". The same holds true for "zlib", and, for example, "openSUSE".

On the other hand, lz4 and lz4hc's branding seems to be LZ4 and LZ4HC, judging from their web pages.


Bin Liu's avatar

@jengelh, thanks, by the way, is there anyting else I need to fix except lz4/lz4hc -> LZ4/LZ4HC, mrdocs pointed that the group is wrong. But I donot know which one.


Jan Engelhardt's avatar

rpmlint complains about "Productivity/Networking/HA" because rpmlint only knows the classic 50 RPM categories from 20 years ago. I say: ignore --- because there are a number of other packages that also have P./Networking/HA and they, all together, make an acceptable "HA" group in the yast2 software tree.


Bin Liu's avatar

@mrdocs, I did not find the wrong rpm group warnings. Just fixed the spec file capitalization warnings. Could you help to point out where is the wrong rpm group warnings in the rpmlint

Request History
Bin Liu's avatar

BinLiu created request

- Fix almost-empty SRPM description.
- Fix faulty leading whitespace in descriptions.
- Reduce size of %if..%endif blocks to minimum.
- Remove pkgconfig requires that are already automatically detected.
- kronosnet-1.0 is available now(bsc#1077702)
Added: kronosnet-1.0.tar.gz
kronosnet.spec
kronosnet.changes


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:1 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:1"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:adi:1


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Jan Engelhardt's avatar

jengelh accepted review


Staging Bot's avatar

staging-bot accepted review

ready to accept


Staging Bot's avatar

staging-bot approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by