Overview

Request 573296 accepted

No description set
Loading...

Dominique Leuenberger's avatar

@RBrownSUSE I think you will get back into /var/adm/fillup-templates mood soon.

rsyslog post script for example is:

    PNAME=syslog 
    DEF_VAL="no" 
    DEL_TEMPL=/usr/share/fillup-templates/$PNAME.del 
    # If template not in new location, fallback to old location 
    if [ ! -f $DEL_TEMPL ] ; then 
        DEL_TEMPL=/var/adm/fillup-templates/$PNAME.del 
    fi 
    rm -f $DEL_TEMPL 
    for var in SYSLOG_DAEMON SYSLOG_REQUIRES_NETWORK ; do 
        echo -e "#\n$var=$DEF_VAL\n" >> $DEL_TEMPL 
    done 
…

So, no package should ship $PNAME.del ( i hope, as we delete it in this script.. that would be evil)

The fall back to /var/adm/ seems wrong in this case - especially with the latest filesystem now dropping the template directory /var/adm/fillup-templates, we try to write to a file that does not exist/cannot be created, as the directory no longer exists.

See sample of a relevant build failure: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:B/rsyslog/standard/x86_64


Dominique Leuenberger's avatar

Of course, rsyslog uses the appropriate macros, like %remove_and_set and so on..


Dominique Leuenberger's avatar

created sr#573617 for rpm - fixing the rpm macros used in those packages failing; the change in the macros was done too mechanic, introducing this minor glitch that stayed unnoticed, as the path still was valid and could be written to.

Request History
Ruediger Oertel's avatar

oertel created request


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:B as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:B"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked openSUSE:Factory:Staging:B


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by