Overview

Request 581016 accepted

- [bnc#1075670] changed to provide createrepo as update-alternative
because createrepo_c will replace createrepo because of switch to
python3
- also provide createrepo-implementation

- Disable tests on SLE12 due to the python-nose requirements

- Switch to singlespec buidling of python bindings
- Make sure to use cmake macros to have it easier to gork what is
happending by overriding %__builddir
- Sort out with spec-cleaner
- Fix embedding of date and time to documentation

Loading...

Ludwig Nussel's avatar

In Leap I see already

found conflict of createrepo-0.10.4-lp150.1.1.x86_64 with createrepo_c-0.10.0.git20170131.04828e6-lp150.1.1.x86_64: - /etc/alternatives/createrepo [mode mismatch: g l777 root:root, g -644 root:root] - /etc/alternatives/createrepo.8.gz [mode mismatch: g l777 root:root, g -644 root:root] - /etc/alternatives/mergerepo [mode mismatch: g l777 root:root, g -644 root:root] - /etc/alternatives/modifyrepo [mode mismatch: g l777 root:root, g -644 root:root]


Ludwig Nussel's avatar

so looks like file modes in createrepo and createrepo_c need to get aligned


Frank Schreiner's avatar
author source maintainer

Sorry for my missing knowledge, but could you explain, where you see this?

Which this patch I to fix this inconsistency and when I compare the binaries manually, I see no difference in the modes:

rpm -q --qf "[%-15{=NAME} %-36{FILENAMES} %{FILEMODES:perms}\n]" -p createrepo_c-0.10.0.git20170131.04828e6-21.1.x86_64.rpm warning: createrepo_c-0.10.0.git20170131.04828e6-21.1.x86_64.rpm: Header V3 DSA/SHA1 Signature, key ID 96a17ffc: NOKEY createrepo_c /etc/alternatives/createrepo lrwxrwxrwx createrepo_c /etc/alternatives/createrepo.8.gz lrwxrwxrwx createrepo_c /etc/alternatives/mergerepo lrwxrwxrwx createrepo_c /etc/alternatives/mergerepo.8.gz lrwxrwxrwx createrepo_c /etc/alternatives/modifyrepo lrwxrwxrwx createrepo_c /etc/alternatives/modifyrepo.8.gz lrwxrwxrwx

rpm -q --qf "[%-15{=NAME} %-36{FILENAMES} %{FILEMODES:perms}\n]" -p createrepo-0.10.4-72.1.x86_64.rpm warning: createrepo-0.10.4-72.1.x86_64.rpm: Header V3 DSA/SHA1 Signature, key ID 96a17ffc: NOKEY createrepo /etc/alternatives/createrepo lrwxrwxrwx createrepo /etc/alternatives/createrepo.8.gz lrwxrwxrwx createrepo /etc/alternatives/mergerepo lrwxrwxrwx createrepo /etc/alternatives/mergerepo.1.gz lrwxrwxrwx createrepo /etc/alternatives/modifyrepo lrwxrwxrwx createrepo /etc/alternatives/modifyrepo.1.gz lrwxrwxrwx


Dominique Leuenberger's avatar

From what I gather, that's because SLE accepted the wrong one while @M0ses and me were busy fixing the package. The one submitted here should be fine (it has a small diff compared to what is in SLE)

osc rdiff SUSE:SLE-15:GA/createrepo_c@aa463ee4708e83524e6f229f67140cf3 system:packagemanager

 mkdir -p %{buildroot}%{_sysconfdir}/alternatives
-ln -s -f %{_sysconfdir}/alternatives/createrepo %{buildroot}%{_bindir}/createrepo
-ln -s -f %{_sysconfdir}/alternatives/mergerepo %{buildroot}%{_bindir}/mergerepo
-ln -s -f %{_sysconfdir}/alternatives/modifyrepo %{buildroot}%{_bindir}/modifyrepo
-ln -s -f %{_sysconfdir}/alternatives/sqliterepo %{buildroot}%{_bindir}/sqliterepo
-ln -s -f %{_sysconfdir}/alternatives/createrepo.8.gz %{buildroot}%{_mandir}/man8/createrepo.8.gz
-ln -s -f %{_sysconfdir}/alternatives/mergerepo.8.gz  %{buildroot}%{_mandir}/man8/mergerepo.8.gz
-ln -s -f %{_sysconfdir}/alternatives/modifyrepo.8.gz %{buildroot}%{_mandir}/man8/modifyrepo.8.gz
-ln -s -f %{_sysconfdir}/alternatives/sqliterepo.8.gz %{buildroot}%{_mandir}/man8/sqliterepo.8.gz
+for i in createrepo mergerepo modifyrepo sqliterepo;do
+  ln -s %{_bindir}/$i\_c %{buildroot}%{_sysconfdir}/alternatives/$i
+  ln -s %{_sysconfdir}/alternatives/$i %{buildroot}%{_bindir}/$i
+  ln -s %{_mandir}/man8/$i\_c.8.gz %{buildroot}%{_sysconfdir}/alternatives/$i\.8.gz
+  ln -s %{_sysconfdir}/alternatives/$i\.8.gz %{buildroot}%{_mandir}/man8/$i\.8.gz
+done
Request History
Frank Schreiner's avatar

M0ses created request

- [bnc#1075670] changed to provide createrepo as update-alternative
because createrepo_c will replace createrepo because of switch to
python3
- also provide createrepo-implementation

- Disable tests on SLE12 due to the python-nose requirements

- Switch to singlespec buidling of python bindings
- Make sure to use cmake macros to have it easier to gork what is
happending by overriding %__builddir
- Sort out with spec-cleaner
- Fix embedding of date and time to documentation


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded

Output of check script (non-fatal):
Unknown license 'GPL-2.0-or-later'


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:F as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:F"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:F


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Dominique Leuenberger's avatar

dimstar_suse changed priority to moderate => important

raising priority for openSUSE:Factory:Staging:F


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by