Overview

Request 597794 superseded

- Add --with-dtrace for systemtap instrumentation bsc#1088716

- As we run in main python package do not generate the pre_checkin
from both now

- Move the tests from base to generic package wrt bsc#1088573
* We still fail the whole distro if python3 is not build
* The other archs than x86_64 took couple of hours to unblock
build of other software, this way we work around the issue
- Some tests are still run in -base for the LTO tweaking, but at
least it is not run twice
- Add --with-dtrace for systemtap instrumentation bsc#1088716

- As we run in main python package do not generate the pre_checkin
from both now

- Move the tests from base to generic package wrt bsc#1088573
* We still fail the whole distro if python3 is not build
* The other archs than x86_64 took couple of hours to unblock
build of other software, this way we work around the issue

Loading...

Dominique Leuenberger's avatar

Produces a build cycle, python3-base requires python3-base to build (the cycle is even larger)

libpsl, meson, ninja, publicsuffix, python3, python3-base, systemd, systemd-mini, systemtap


Tomáš Chvátal's avatar

Can't do much, I need the dtrace binary:

https://github.com/python/cpython/blob/master/Makefile.pre.in#L909


Dominique Leuenberger's avatar

python3-base even requires python3-base to build. this can't be serious. That's exactly why we have the split of python3-base from python3, so we can bootstrap the thing


Tomáš Chvátal's avatar

Well the dtrace binary is just a C app so it should be doable to be put in the headers...


Dominique Leuenberger's avatar

osc buildinfo devel:languages:python:Factory python3-base openSUSE_Tumbleweed x86_64 | grep python3-base

 

Dominique Leuenberger's avatar

added python3-base@devel:languages:python:Factory/openSUSE_Tumbleweed because of systemtap-sdt-devel:/usr/bin/python3


Tomáš Chvátal's avatar

Ah /me is blind, it is python3 app the dtrace call...


Tomáš Chvátal's avatar

What are options then, I can create another python-mini that is 1:1 python-base just without the SDT stuff, or I can bundle the python dtrace command with python3 (actually sounds more sane)...


Dominique Leuenberger's avatar

That sounds somewhat sane, but we will need a way to have ensure the sources don't drift apart (leading source would still be in systemtap, right?)


Tomáš Chvátal's avatar

Yep, but that won't work in the end either, just tested. So I will have to create yet another python subpkg probably called python-buildonly, or any name preference?


Dominique Leuenberger's avatar

That would then be a package only used inside OBS, not meant for usage outside of OBS. as such, this should follow the usual -mini approach, with the relevant Requires: this-is-only-for-buildenv (see systemd-mini)

Not even sure that will really work: /usr/bin/python3 is defined to come from python3-base (by means of prjconf); changing that to -mini makes no sense, as otherwise everything in OBS would be using the -mini, which is likely not what we want. not changing it would mean that dtrace still requires /usr/bin/python3, and thus python3-base


Tomáš Chvátal's avatar

Override requires there, another option would be to make it use python2 and ask upstream to write it in something else

Request History
Tomáš Chvátal's avatar

scarabeus_iv created request

- Add --with-dtrace for systemtap instrumentation bsc#1088716

- As we run in main python package do not generate the pre_checkin
from both now

- Move the tests from base to generic package wrt bsc#1088573
* We still fail the whole distro if python3 is not build
* The other archs than x86_64 took couple of hours to unblock
build of other software, this way we work around the issue
- Some tests are still run in -base for the LTO tweaking, but at
least it is not run twice
- Add --with-dtrace for systemtap instrumentation bsc#1088716

- As we run in main python package do not generate the pre_checkin
from both now

- Move the tests from base to generic package wrt bsc#1088573
* We still fail the whole distro if python3 is not build
* The other archs than x86_64 took couple of hours to unblock
build of other software, this way we work around the issue


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Yuchen Lin's avatar

maxlin_factory set openSUSE:Factory:Staging:H as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:H"


Yuchen Lin's avatar

maxlin_factory accepted review

Picked openSUSE:Factory:Staging:H


Marco Strigl's avatar

mstrigl accepted review

LGTM


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Dominique Leuenberger's avatar

dimstar declined review

Introduces a build cycle

libpsl, meson, ninja, publicsuffix, python3, python3-base, systemd, systemd-mini, systemtap


Dominique Leuenberger's avatar

dimstar declined request

Introduces a build cycle

libpsl, meson, ninja, publicsuffix, python3, python3-base, systemd, systemd-mini, systemtap


Tomáš Chvátal's avatar

scarabeus_iv reopened request

We will probably have to live with the cycle unless dtrace binary can be moved to the systemtap-headers too


Dominique Leuenberger's avatar

dimstar_suse accepted review

Re-evaluation needed


Dominique Leuenberger's avatar

dimstar_suse approved review

Re-evaluation needed


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Requesting new staging review


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:E as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:E"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:E


openSUSE Build Service is sponsored by