Overview
Request 606261 revoked
- Switch from wxWidgets 3.1 GUI to Qt5 GUI which is now the default one
* https://dolphin-emu.org/blog/2018/05/02/legend-dolphin-lens-between-worlds/
- Add GCC8_workaround.patch
* GCC 8 compilation fix until https://bugs.dolphin-emu.org/issues/11047
is properly resolved.
Request History
KAMiKAZOW created request
- Switch from wxWidgets 3.1 GUI to Qt5 GUI which is now the default one
* https://dolphin-emu.org/blog/2018/05/02/legend-dolphin-lens-between-worlds/
- Add GCC8_workaround.patch
* GCC 8 compilation fix until https://bugs.dolphin-emu.org/issues/11047
is properly resolved.
namtrac declined request
Please don't change copyright headers, just add yours.
KAMiKAZOW reopened request
Dude, did you not read what you replied to? I did not change a copyright header, I overwrote your specfile with mine. I don't add a SUSE copyright to MY package because SUSE does not own any copyright of MY package. I just had the courtesy to contribute MY package to Emulators because your package is broken.
namtrac declined request
I'll merge your changes manually.
KAMiKAZOW revoked request
Whatever
Saw the Dolphin package in Emulators was outdated (wx GUI) and not building under Leap 42.3. This SR is based on my packaging effort of Dolphin I do mainly for myself. With the exception of the netplay version check lines that I adapted, my package very different – that explains the relatively large changeset.
Please don't change copyright headers, just add yours.
Dude, did you not read what you replied to? I did not change a copyright header, I overwrote your specfile with mine. I don't add a SUSE copyright to MY package because SUSE does not own any copyright of MY package. I just had the courtesy to contribute MY package to Emulators because your package is broken.
Please do send incremental changes, there is no need to rewrite the spec file. This is not some software needing a rewrite.
Why would I port my packaging to your specfile (which I maintain since 2014 in different forms) if all that'll be left is SUSE's copyright header and different indentation?
I use the same template for both my own Dolphin package as well as my two Ishiiruka packages. Unlike you I'm not paid by SUSE. I contribute in my own free time and I take steps to minimize my workload.
I'm already quite annoyed by how responses are handled in the Emulators project. My SRs don't get responses for days, sometimes even weeks, I'm not even maintainer of packages I contributed (Ishiiruka and mGBA), and now you just have proved that you don't even read what my SR says.
I thought it would be a good thing for the community if the semi-official Dolphin package was updated to a more current release and worked on 42.3 again.
If you disagree, fine. Update you package yourself. Heck, feel free to even take some of my specfile and add it to yours. It's free under GPL-2.0+ anyway (no MIT loophole or SUSE copyright assignment, though). I'll keep maintaining my packages in home:KAMiKAZOW:Emulators for the foreseeable future.
So take it as is or leave it and never get any contributions by me again. Given the bad shape of the current Dolphin package, I don't see dozens of contributors lining up...
I'll merge your changes manually. Thank you.
Still not building under Leap 42.3. You should reconsider simply using my package.
@linuxrecon, @namtrac, @seilerphilipp: review reminder