Overview
Request 617546 accepted
- fix build for Tumbleweed (add silencebadsnprintfcheck.patch)
In my opinion the check is wrong. snprintf already checks target buffer overflow. Why test if the amount of possible outputs of individual components exceeds the target buffer. That's common practice. With this check defining a large intermediate buffer leads to an error, using short intermediate buffers has no error, but is more dangerous - That makes no sense!
Request History
dstoecker created request
- fix build for Tumbleweed (add silencebadsnprintfcheck.patch)
In my opinion the check is wrong. snprintf already checks target buffer overflow. Why test if the amount of possible outputs of individual components exceeds the target buffer. That's common practice. With this check defining a large intermediate buffer leads to an error, using short intermediate buffers has no error, but is more dangerous - That makes no sense!
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot added openSUSE:Factory:Staging:adi:80 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:80"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:80
repo-checker accepted review
cycle and install check passed
namtrac accepted review
staging-bot accepted review
ready to accept
staging-bot approved review
ready to accept
maxlin_factory accepted request
Accept to openSUSE:Factory