Overview

Request 617546 accepted

- fix build for Tumbleweed (add silencebadsnprintfcheck.patch)

In my opinion the check is wrong. snprintf already checks target buffer overflow. Why test if the amount of possible outputs of individual components exceeds the target buffer. That's common practice. With this check defining a large intermediate buffer leads to an error, using short intermediate buffers has no error, but is more dangerous - That makes no sense!

Request History
Dirk Stoecker's avatar

dstoecker created request

- fix build for Tumbleweed (add silencebadsnprintfcheck.patch)

In my opinion the check is wrong. snprintf already checks target buffer overflow. Why test if the amount of possible outputs of individual components exceeds the target buffer. That's common practice. With this check defining a large intermediate buffer leads to an error, using short intermediate buffers has no error, but is more dangerous - That makes no sense!


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:80 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:80"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:adi:80


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Ismail Dönmez's avatar

namtrac accepted review


Staging Bot's avatar

staging-bot accepted review

ready to accept


Staging Bot's avatar

staging-bot approved review

ready to accept


Yuchen Lin's avatar

maxlin_factory accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by