Overview
Request 637060 revoked
Added fix for boo#1096328, printer settings not remembered
- Created by msalle
- In state revoked
- Open review for openSUSE:Factory
Loading...
Request History
msalle created request
Added fix for boo#1096328, printer settings not remembered
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
maintbot added openSUSE:Factory as a reviewer
Submission for None by someone who is not maintainer in the devel project (openSUSE:Factory). Please review
maintbot accepted review
ok
AndreasStieger declined request
Will come in via SLE maintenance
msalle revoked request
The source project 'home:msalle:branches:openSUSE:Leap:15.0:Update' has been removed
home:msalle:branches:openSUSE:Leap:15.0:Update/libqt5-qtbase@78deda81438b607891e2890ce117134a -> openSUSE:Leap:15.0:Update/libqt5-qtbase
expected origin is 'SUSE:SLE-15:GA' (changed)
no devel project found for openSUSE:Leap:15.0:Update/libqt5-qtbase
@msalle: The patch policy requires that all patches include the full header. You can get it easily by using git format-patch from the upstream patch. Please submit to KDE:Qt:5.9 instead, from there we can submit it to SLE.
Hi, I needed to adapt the patch a bit (upstream was already further than Leap15's 5.9.4). I can re-adapt the patch to apply to a different tag or branch, and then do a git format-patch from my own new patch, but then need to know exactly which branch or tag to use. Also KDE:Qt:5.9 is currently at 5.9.6. Finally, would you want me to work against the clean upstream 5.9.6 or 5.9.6 including the patches in KDE:Qt:5.9?
There shouldn't be a huge difference between our 5.9.4 and 5.9.6, if you just add proper headers to this patch it should work.
AFAICT the commit is not in the upstream 5.9 branch, so the current place after "# patches 2000-3000 and above from upstream 5.10/dev branch #" is correct.
Ok, I've now submitted https://build.opensuse.org/request/show/638428 Hope this one is ok?
See <a href='https://build.opensuse.org/request/show/638734'>SR#638734</a> for 5.11