Overview

Request 637060 revoked

Added fix for boo#1096328, printer settings not remembered


Leap Reviewbot's avatar

home:msalle:branches:openSUSE:Leap:15.0:Update/libqt5-qtbase@78deda81438b607891e2890ce117134a -> openSUSE:Leap:15.0:Update/libqt5-qtbase

expected origin is 'SUSE:SLE-15:GA' (changed)

no devel project found for openSUSE:Leap:15.0:Update/libqt5-qtbase


Fabian Vogt's avatar

@msalle: The patch policy requires that all patches include the full header. You can get it easily by using git format-patch from the upstream patch. Please submit to KDE:Qt:5.9 instead, from there we can submit it to SLE.


Mischa Salle's avatar

Hi, I needed to adapt the patch a bit (upstream was already further than Leap15's 5.9.4). I can re-adapt the patch to apply to a different tag or branch, and then do a git format-patch from my own new patch, but then need to know exactly which branch or tag to use. Also KDE:Qt:5.9 is currently at 5.9.6. Finally, would you want me to work against the clean upstream 5.9.6 or 5.9.6 including the patches in KDE:Qt:5.9?


Fabian Vogt's avatar

There shouldn't be a huge difference between our 5.9.4 and 5.9.6, if you just add proper headers to this patch it should work.

AFAICT the commit is not in the upstream 5.9 branch, so the current place after "# patches 2000-3000 and above from upstream 5.10/dev branch #" is correct.



Request History
Mischa Salle's avatar

msalle created request

Added fix for boo#1096328, printer settings not remembered


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Maintenance Bot's avatar

maintbot added openSUSE:Factory as a reviewer

Submission for None by someone who is not maintainer in the devel project (openSUSE:Factory). Please review


Maintenance Bot's avatar

maintbot accepted review

ok


Andreas Stieger's avatar

AndreasStieger declined request

Will come in via SLE maintenance


Mischa Salle's avatar

msalle revoked request

The source project 'home:msalle:branches:openSUSE:Leap:15.0:Update' has been removed

openSUSE Build Service is sponsored by