Request 637639 (accepted)

Overview

Request 637639 accepted

No description set

Created by michalsrb over 5 years ago
In state accepted

Submit llvm

Comments for request 637639 16

Michal Srb (michalsrb) - over 5 years ago

author

The llvm7 package this requires was submitted in https://build.opensuse.org/request/show/637636.

Dominique Leuenberger (dimstar_suse) - over 5 years ago

reviewer target maintainer

Waiting for llvm7

Dominique Leuenberger (dimstar_suse) - over 5 years ago

reviewer target maintainer

Unignored: returned to active backlog.

Dominique Leuenberger (dimstar) - over 5 years ago

reviewer

libclc needs adjustments for llvm7:

build log excerpt:

[   35s] /usr/bin/clang -MMD -MF nvptx64--nvidiacl/lib/cl_khr_int64_base_atomics/atom_add.cl.bc.d -target nvptx64--nvidiacl -I`dirname ./generic/lib/cl_khr_int64_base_atomics/atom_add.cl` -I./generic/include -fno-builtin -D__CLC_INTERNAL -emit-llvm -c -o nvptx64--nvidiacl/lib/cl_khr_int64_base_atomics/atom_add.cl.bc ./generic/lib/cl_khr_int64_base_atomics/atom_add.cl
[   35s] [1m./utils/prepare-builtins.cpp:108:3: [0m[0;1;31merror: [0m[1mno matching function for call to 'WriteBitcodeToFile'[0m
[   35s]   WriteBitcodeToFile(M, Out->os());
[   35s] [0;1;32m  ^~~~~~~~~~~~~~~~~~
[   35s] [0m[1m/usr/include/llvm/Bitcode/BitcodeWriter.h:129:8: [0m[0;1;30mnote: [0mcandidate function not viable: no known conversion from 'llvm::Module *' to 'const llvm::Module' for 1st argument; dereference the argument with *[0m
[   35s]   void WriteBitcodeToFile(const Module &M, raw_ostream &Out,
[   35s] [0;1;32m       ^
[   35s] [0mLLVM-CC nvptx64--nvidiacl/lib/cl_khr_int64_base_atomics/atom_cmpxchg.cl.bc

CC @boombatower

Michal Srb (michalsrb) - over 5 years ago

author

It was fixed in libclc upstream in commit 35540536.

Jimmy Berry (boombatower) - over 5 years ago

Updated to latest in request#641351.

Jimmy Berry (boombatower) - over 5 years ago

I staged in K and seems to have solved build problem.

Dominique Leuenberger (dimstar) - over 5 years ago

reviewer

Next failure candidate: MEsa-drivers:

[  755s] <command-line>: note: this is the location of the previous definition
[  758s] llvm/codegen/native.cpp: In function 'std::vector<char> {anonymous}::emit_code(llvm::Module&, const clover::llvm::target&, llvm::TargetMachine::CodeGenFileType, std::__cxx11::string&)':
[  758s] llvm/codegen/native.cpp:135:49: error: no matching function for call to 'llvm::TargetMachine::addPassesToEmitFile(clover::llvm::compat::pass_manager&, llvm::raw_svector_ostream&, llvm::TargetMachine::CodeGenFileType&)'
[  758s]           if (tm->addPassesToEmitFile(pm, fos, ft))
[  758s]                                                  ^
[  758s] In file included from ./llvm/compat.hpp:50,
[  758s]                  from llvm/codegen/native.cpp:31:
[  758s] /usr/include/llvm/Target/TargetMachine.h:260:16: note: candidate: 'virtual bool llvm::TargetMachine::addPassesToEmitFile(llvm::legacy::PassManagerBase&, llvm::raw_pwrite_stream&, llvm::raw_pwrite_stream*, llvm::TargetMachine::CodeGenFileType, bool, llvm::MachineModuleInfo*)'
[  758s]    virtual bool addPassesToEmitFile(PassManagerBase &, raw_pwrite_stream &,
[  758s]                 ^~~~~~~~~~~~~~~~~~~
[  758s] /usr/include/llvm/Target/TargetMachine.h:260:16: note:   candidate expects 6 arguments, 3 provided
[  759s] llvm/codegen/bitcode.cpp:54:4: warning: 'std::map<std::__cxx11::basic_string<char>, unsigned int> {anonymous}::get_symbol_offsets(const llvm::Module&)' defined but not used [-Wunused-function]
[  759s]     get_symbol_offsets(const ::llvm::Module &mod) {
[  759s]     ^~~~~~~~~~~~~~~~~~

CC @sndirsch - MEsa-drivers fails to build with llvm7

Dominique Leuenberger (dimstar) - over 5 years ago

reviewer

[  755s] command-line: note: this is the location of the previous definition
[  758s] llvm/codegen/native.cpp: In function 'std::vector char {anonymous}::emit_code(llvm::Module&, const clover::llvm::target&, llvm::TargetMachine::CodeGenFileType, std::__cxx11::string&)':
[  758s] llvm/codegen/native.cpp:135:49: error: no matching function for call to 'llvm::TargetMachine::addPassesToEmitFile(clover::llvm::compat::pass_manager&, llvm::raw_svector_ostream&, llvm::TargetMachine::CodeGenFileType&)'
[  758s]           if (tm->addPassesToEmitFile(pm, fos, ft))
[  758s]                                                  ^
[  758s] In file included from ./llvm/compat.hpp:50,
[  758s]                  from llvm/codegen/native.cpp:31:
[  758s] /usr/include/llvm/Target/TargetMachine.h:260:16: note: candidate: 'virtual bool llvm::TargetMachine::addPassesToEmitFile(llvm::legacy::PassManagerBase&, llvm::raw_pwrite_stream&, llvm::raw_pwrite_stream*, llvm::TargetMachine::CodeGenFileType, bool, llvm::MachineModuleInfo*)'
[  758s]    virtual bool addPassesToEmitFile(PassManagerBase &, raw_pwrite_stream &,
[  758s]                 ^~~~~~~~~~~~~~~~~~~
[  758s] /usr/include/llvm/Target/TargetMachine.h:260:16: note:   candidate expects 6 arguments, 3 provided
[  759s] llvm/codegen/bitcode.cpp:54:4: warning: 'std::map std::__cxx11::basic_string char , unsigned int {anonymous}::get_symbol_offsets(const llvm::Module&)' defined but not used [-Wunused-function]
[  759s]     get_symbol_offsets(const ::llvm::Module &mod) {
[  759s]     ^~~~~~~~~~~~~~~~~~

Michal Srb (michalsrb) - over 5 years ago

author

This is already fixed in Mesa 18.2.2 (maybe even earlier), there is update in sr#640388.

Staging Bot (staging-bot) - over 5 years ago

reviewer

@dimstar_suse, @factory-repo-checker: review reminder

Dominique Leuenberger (dimstar) - over 5 years ago

reviewer

Rust fails to build in this staging, most likely also the llvm update.

https://build.opensuse.org/build/openSUSE:Factory:Staging:K/standard/x86_64/rust/_log

(the issue is likely introduced recently with rust 0.30)

CC @luke_nukem

Dominique Leuenberger (dimstar_suse) - over 5 years ago

reviewer target maintainer

Breaks rust - let's baclog that for now, and hopefully move on with Mesa

Aaron Puchert (aaronpuchert) - over 5 years ago

source maintainer

Issue seems to be known: https://github.com/rust-lang/rust/issues/56505. If I understand correctly, it's a known ABI mismatch between GCC and Clang: https://bugs.llvm.org/show_bug.cgi?id=39427. It's not clear if this will land in LLVM 7.0.1. We could downport the patch (should not be an issue since the unpatched 7.0.0 never made it into Factory) or build rustc with Clang as well. I think patching is the easier way, if it still compiles.

Michal Srb (michalsrb) - over 5 years ago

author

https://bugzilla.opensuse.org/show_bug.cgi?id=1119092

The patch to fix the ABI incompatibility was submitted to both Factory and SLE15 SP1.

Aaron Puchert (aaronpuchert) - over 5 years ago

source maintainer

Nice. So can this get staged again?