Request 640959 (superseded)

This request is superseded by request 641764 (Show diff)

Overview

Request 640959 superseded

- fix boo1111323 transmission-qt try to load translations from /usr/bin
* in qt/Application.cc, upstream is Windows/OS X oriented to load
translations from application executable directory which is
/usr/bin/translations on Linux. that doesn't make sense, so we
append QLibraryInfo::TranslationsPath (standard Qt translations
directory) to application's appQmDirs variable.
* add patch transmission-qt-load-translations-from-standard-dir.patch
- mark COPYING with %license tag instead of %doc tag

Created by MargueriteSu over 5 years ago
In state superseded
Superseded by 641764
Open review for gnome-maintainers

Submit transmission

Comments for request 640959 1

Luciano Santos (luc14n0) - over 5 years ago

reviewer target maintainer

Hi there!

+- fix boo1111323 transmission-qt try to load translations from /usr/bin

You're missing the '#' character here and the colon, the visual clue for second level indentations.

+  * in qt/Application.cc, upstream is Windows/OS X oriented to load
+    translations from application executable directory which is
+    /usr/bin/translations on Linux. that doesn't make sense, so we
+    append QLibraryInfo::TranslationsPath (standard Qt translations
+    directory) to application's appQmDirs variable.

As you can see back in the file history, the second level indentation used in this package is a '+', stick to the convention please. And there's a trailing white space after the period.

+  * add patch transmission-qt-load-translations-from-standard-dir.patch

And please don't shortcut here, add the reasoning for the patch. It's good to have a context.

Request History

MargueriteSu created request over 5 years ago

gnome-review-bot accepted review over 5 years ago

Check script succeeded

MargueriteSu superseded request over 5 years ago

Places

Overview