Overview

Request 646694 superseded

- Made changes requested in comments for request 646211.
1. Sustituted /usr/lib/python3.7/site-packages/ => %python3_sitelib
2. Reverted change that eliminated use of %{_tmppath}/SITE_FILES for Python 3.6
3. As vboxapisetup.py in Python 3.7 no longer accepts the --record-rpm switch,
SITE_FILES does not exist, and the individual files must still be listed.

- Make necessary updates so that VirtualBox will build with Python 3.7 - boo#1113894
Change kernel module code to build against the API changes in kernel 4.20 - This change
adds file "fixes_for_4.20.patch".

- Require(pre) virtualbox by the -qt package: otherewise it might
happen that virtualbox-qt is installed before virtualbox, which
then results in files being assigned to group 'root' instead of
'vboxusers', as the group is only created later.

- Version bump to 5.2.20 (released October 16 2018 by Oracle)
This is a maintenance release. The following items were fixed and/or added:
VMM: fixed task switches triggered by INTn instruction (bug #17979)
Storage: fixed connecting to certain iSCSI targets (bug #17507)
Storage: fixed handling of flush requests when configured to be ignored when the host I/O cache is used (bug #17573)
Drag and drop: implemented support for UNC paths (bug #17146)
Drag and drop: fixed resuming operation when restoring from a saved state (bug #17649)
Drag and drop: fixed copying files with long file names (> 248 characters) from guests to Windows hosts (bug #17447)
Drag and drop: fixed handling files with Unicode names on Windows guests (bug #15501)
Drag and drop: fixed copying empty (0-byte) files to / from guests (bugs #14863 + #17443)
Drag and drop: fixed copying over files from hosts to Linux guests (bug #16025)
Networking: restore connectivity for guests bridged to host adapters that were unavailable temporarily (Windows hosts, bug #17090)
Guest Control: fixed hang when using --wait-stdout and/or --wait-stderr (bug #17386). Needs updating Guest Additions
Video recording: fixed starting video recording on VM power up (bug #17307)
Linux Additions: various build fixes for kernel modules on recent distributions, and made sure modules end up in initramfs files

Loading...

Dominique Leuenberger's avatar

I'll send you an SR fixing up the issues seen; this should help you get going. currently just building in my branch to make sure I did not miss somsething


Dominique Leuenberger's avatar
can't install virtualbox-devel-5.2.20-426.1.i586:
  nothing provides python3-virtualbox = 5.2.20 needed by virtualbox-devel-5.2.20-426.1.i586

Dominique Leuenberger's avatar

-%files -n python3-%{name} -f %{_tmppath}/SITE_FILES

So you merged the files section into the previous files list


Larry Finger's avatar
author source maintainer

Yes. In Python 3.7, vboxapisetup.py no longer accepts the --record-rpm switch, and SITE_FILES does not exist. The individual files must still be listed. I have reverted this change for 3.6.


Larry Finger's avatar
author source maintainer

I have no idea why this happened.


Dominique Leuenberger's avatar

you meant to keep the %files -n python3-%{name} part, but only delete the -f %{_tmppath}/SITE_FILES


Larry Finger's avatar
author source maintainer

I just created request id 646694 to supersede this one. The basic problem is that vboxapisetup.py in Python 3.7 no longer accepts the --record-rpm switch, thus SITE_FILES does not exist, and the individual files must still be listed. For 3.6, that part of the spec is now unchanged.


Dominique Leuenberger's avatar

/usr/lib/python3.7/site-packages/ => %python3_sitelib

That's the right macro to use here


Larry Finger's avatar
author source maintainer

Thanks. The new version uses this macro.

Request History
Larry Finger's avatar

lwfinger created request

- Made changes requested in comments for request 646211.
1. Sustituted /usr/lib/python3.7/site-packages/ => %python3_sitelib
2. Reverted change that eliminated use of %{_tmppath}/SITE_FILES for Python 3.6
3. As vboxapisetup.py in Python 3.7 no longer accepts the --record-rpm switch,
SITE_FILES does not exist, and the individual files must still be listed.

- Make necessary updates so that VirtualBox will build with Python 3.7 - boo#1113894
Change kernel module code to build against the API changes in kernel 4.20 - This change
adds file "fixes_for_4.20.patch".

- Require(pre) virtualbox by the -qt package: otherewise it might
happen that virtualbox-qt is installed before virtualbox, which
then results in files being assigned to group 'root' instead of
'vboxusers', as the group is only created later.

- Version bump to 5.2.20 (released October 16 2018 by Oracle)
This is a maintenance release. The following items were fixed and/or added:
VMM: fixed task switches triggered by INTn instruction (bug #17979)
Storage: fixed connecting to certain iSCSI targets (bug #17507)
Storage: fixed handling of flush requests when configured to be ignored when the host I/O cache is used (bug #17573)
Drag and drop: implemented support for UNC paths (bug #17146)
Drag and drop: fixed resuming operation when restoring from a saved state (bug #17649)
Drag and drop: fixed copying files with long file names (> 248 characters) from guests to Windows hosts (bug #17447)
Drag and drop: fixed handling files with Unicode names on Windows guests (bug #15501)
Drag and drop: fixed copying empty (0-byte) files to / from guests (bugs #14863 + #17443)
Drag and drop: fixed copying over files from hosts to Linux guests (bug #16025)
Networking: restore connectivity for guests bridged to host adapters that were unavailable temporarily (Windows hosts, bug #17090)
Guest Control: fixed hang when using --wait-stdout and/or --wait-stderr (bug #17386). Needs updating Guest Additions
Video recording: fixed starting video recording on VM power up (bug #17307)
Linux Additions: various build fixes for kernel modules on recent distributions, and made sure modules end up in initramfs files


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:B as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:B"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked openSUSE:Factory:Staging:B


Dominique Leuenberger's avatar

dimstar declined review

+%if %python3_version_nodots == 36
%files -n python3-%{name} -f %{_tmppath}/SITE_FILES
+%endif

You only create the pythonu-virtualbox in case of python3_version_nodots == 36; this is not intentional and will break with python 3.7 again (as there will no longer be a python3-virtualbox package and all python-related files will be squashed into a different package)


Dominique Leuenberger's avatar

dimstar declined request

+%if %python3_version_nodots == 36
%files -n python3-%{name} -f %{_tmppath}/SITE_FILES
+%endif

You only create the pythonu-virtualbox in case of python3_version_nodots == 36; this is not intentional and will break with python 3.7 again (as there will no longer be a python3-virtualbox package and all python-related files will be squashed into a different package)


Larry Finger's avatar

lwfinger superseded request

superseded by 652201

openSUSE Build Service is sponsored by