Overview

Request 670473 accepted

- Update to version 15.1.0 (git 6b07b88):
* 50-blacklist.conf is not added in Leap before 15.1.
fix conditionals and bump version accordingly.

- Update to version 15.0.20 (git 1396df5):
- Fix driver-check.sh (boo#1123697, boo#1123704)
- add /etc/modprobe.d/50-blacklist.conf from sysconfig package
(boo#1107611)
- Remove hard dependency on mkinitrd (boo#1123721)
- Make sure code works also without kmod-compat
- Replace file dependency on /sbin/depmod by weak package dependency

- Move "weak-modules" script to -legacy subpackage to avoid
dependency on binutils (bsc#1116665)

- Require mkinitrd (provided also by dracut) directly instead of
file requires. This is fixing image build failures


Martin Wilck's avatar
author source maintainer

IMPORTANT: Please also accept https://build.opensuse.org/request/show/670420, otherwise the "modsign-verify" tool will be missing. The two packages (suse-module-tools and pesign-obs-integration) should hit Factory at the same time.

(Well it'd not be catastrophic if "modsign-verify" was missing for a few days, but it'd be good to avoid that anyway).


Dominique Leuenberger's avatar
+%if 0%{?suse_version} >= 1550 || 0%{?sle_version} >= 150100
+%config(noreplace) %{_sysconfdir}/modprobe.d/50-blacklist.conf
+%endif

What about the approach of having the package provided blacklist in /usr/lib and having override files in /etc? The same system is used in systemd/udev and is quite well understood (to disable a complete backlist you could symlink tghe file in /etc/modprobe.d to /dev/null for example, as long as it has the same name)

This would allow the package to bring pristine files, and the user overriding the rules easily (the comment in the files posted in /usr/lib should probably explain how to disable the blacklist then via a file in /etc)


Martin Wilck's avatar
author source maintainer

Note that this is not what we've been discussion on the factory ML lately (about filesystem blacklisting). It's just a file which used to be in the sysconfig package and has been moved to suse-module-tools.

I'm not against moving it to /lib, but this whole entangled mess is already bad enough; I'd like to do it in a separate step.

Note also that for filesystem blacklisting, it's better to put the files in /etc then /lib (https://lists.opensuse.org/opensuse-factory/2019-02/msg00004.html)


Martin Wilck's avatar
author source maintainer

Can we move on with this one please? Is the issue about /lib and /etc worth holding it back, given that the file used to be under /etc while it was part of the sysconfig package?

If this is really critical, please indicate so, and I'll resubmit once more. But it'd be important to make progress, as the next change (the file system blacklist discussed on the opensuse-factory ML lately) is waiting to be submitted, too.


Stephan Kulow's avatar

I can't accept B anyway without a fix for sysconfig migrating resolv.conf to a symlink.


Stephan Kulow's avatar

ok, I changed my mind. I would still accept it - but wouldn't release TW snapshots (they would fail in QA and we know it)


Martin Wilck's avatar
author source maintainer

This request doesn't depend on the sysconfig request. It'd rather be the other way around.

We just migrated the 50-blacklist.conf file from sysconfig to suse-module-tools, taking care that the files are identical, so there'll be no file conflict.


Martin Wilck's avatar
author source maintainer

IMPORTANT: Please also accept https://build.opensuse.org/request/show/670420, otherwise the "modsign-verify" tool will be missing. The two packages (suse-module-tools and pesign-obs-integration) should hit Factory at the same time.

Request History
Martin Wilck's avatar

mwilck created request

- Update to version 15.1.0 (git 6b07b88):
* 50-blacklist.conf is not added in Leap before 15.1.
fix conditionals and bump version accordingly.

- Update to version 15.0.20 (git 1396df5):
- Fix driver-check.sh (boo#1123697, boo#1123704)
- add /etc/modprobe.d/50-blacklist.conf from sysconfig package
(boo#1107611)
- Remove hard dependency on mkinitrd (boo#1123721)
- Make sure code works also without kmod-compat
- Replace file dependency on /sbin/depmod by weak package dependency

- Move "weak-modules" script to -legacy subpackage to avoid
dependency on binutils (bsc#1116665)

- Require mkinitrd (provided also by dracut) directly instead of
file requires. This is fixing image build failures


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:B as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:B"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:B


Dominique Leuenberger's avatar

dimstar_suse changed priority to moderate => important

raising priority for openSUSE:Factory:Staging:B


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Ismail Dönmez's avatar

namtrac accepted review


Stephan Kulow's avatar

coolo accepted review

ready to accept


Stephan Kulow's avatar

coolo approved review

ready to accept


Stephan Kulow's avatar

coolo accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by