Overview
Request 678097 accepted
- Now that IBM has the package on github, use a full source URL.
- Change Pre-Req to Requires(pre) and (post), and remove dracut.
- Changed the group for the hmcdrvfs package from Base:System to
Base/Filesystems
- Institute the %autosetup macro.
- Remove erroneous %dir entry for %_unitdir
- Change bash-specific "==" tests in scriptlets with a more
generic "=".
- Modified the spec file to add a group named cpacfstats
(bsc#1123730)
If there is an error in getent (or any other portion), the administrator should be made aware of it, it should not be hidden IMO.
A fix is in 676375, that SR also fixes other present issues, such as sh compat (alternative: /bin/bash markup), which seems reasonably favored by others on the ML.
So 676356 should not pass until those low hanging fruit are addressed.
If getent fails for any reason, the groupadd command will be executed. Any error from that will be displayed. The package has been this way for aeons, and nobody has complained. I see no reason to hold this request. Please proceed.
"we always did it this way" is not a very good argument.
There are 400 getent calls in Factory, only 22 of which have 2>
, and that is mostly remnants that have not been noticed yet, that is to say, I point out the 94% conformance of the rest.
Oh well. Find a real problem and I'll consider fixing it.
Request History
markkp created request
- Now that IBM has the package on github, use a full source URL.
- Change Pre-Req to Requires(pre) and (post), and remove dracut.
- Changed the group for the hmcdrvfs package from Base:System to
Base/Filesystems
- Institute the %autosetup macro.
- Remove erroneous %dir entry for %_unitdir
- Change bash-specific "==" tests in scriptlets with a more
generic "=".
- Modified the spec file to add a group named cpacfstats
(bsc#1123730)
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
coolo set openSUSE:Factory:Staging:A as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:A"
coolo accepted review
Picked openSUSE:Factory:Staging:A
dimstar accepted review
repo-checker accepted review
Accepted as part of openSUSE:Factory:Staging:A
dimstar_suse accepted review
ready to accept
dimstar_suse approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory