Overview
Request 681723 accepted
- Fix vfs_ceph ftruncate and fallocate handling; (bso#13807); (bsc#1127153).
- Fix update-apparmor-samba-profile script after apparmor switched
to using named profiles. The change is backwards compatible;
(bsc#1126377);
- LoadParm().load_default() fails with "Unable to load default file";
(bsc#1089758);
- Abide by load_printers smb.conf parameter; (bso#13766); (bsc#1124223);
Summary: Samba MIT ADDC
Please reduce the acronyms.
While we're there, I think we should probably also change "Active Directory Domain Controller" to "Active Directory compatible domain controller"
%package -n libsamba-policy0-python3 +Provides: libsamba-policy0
I do not see the purpose of this. No other package requires the name libsamba-policy0
. Likewise, it seems rather strange to masquerade the py3 library like the py2 one - they are still different libs.
Samba python code is written to be py2/py3 compatible, so pulling in either one version or the other does make perfect sense (especially when the py2 code is deprecated).
-%postun -n libsamba-policy0 -p /sbin/ldconfig +%post -n libsamba-policy0-python -p /sbin/ldconfig
And I'm not convinced this should be done either. The library filename has not changed, so there is no good reason to deviate from SLPP.
Speaking of rename, if you really want to do it, then a bunch of Obsoletes
are missing.
I get that the obsoletes are missing, but what's wrong with renaming the package? Currently libsamba-policy0 contains a mix of python2 and python3 libraries, which it should not. I think it makes perfect sense to split it in two and rename them both.
@jengelh How about this? https://build.opensuse.org/package/rdiff/home:dmulder:branches:openSUSE:Factory/samba?opackage=samba&oproject=openSUSE%3AFactory&rev=2 These changes remove the package name change, etc.
Request History
dmdiss created request
- Fix vfs_ceph ftruncate and fallocate handling; (bso#13807); (bsc#1127153).
- Fix update-apparmor-samba-profile script after apparmor switched
to using named profiles. The change is backwards compatible;
(bsc#1126377);
- LoadParm().load_default() fails with "Unable to load default file";
(bsc#1089758);
- Abide by load_printers smb.conf parameter; (bso#13766); (bsc#1124223);
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
namtrac accepted review
dimstar_suse set openSUSE:Factory:Staging:F as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:F"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:F
repo-checker accepted review
Accepted as part of openSUSE:Factory:Staging:F
dimstar_suse accepted review
ready to accept
dimstar_suse approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory