Overview

Request 681723 accepted

- Fix vfs_ceph ftruncate and fallocate handling; (bso#13807); (bsc#1127153).

- Fix update-apparmor-samba-profile script after apparmor switched
to using named profiles. The change is backwards compatible;
(bsc#1126377);

- LoadParm().load_default() fails with "Unable to load default file";
(bsc#1089758);

- Abide by load_printers smb.conf parameter; (bso#13766); (bsc#1124223);

Loading...

Jan Engelhardt's avatar

Summary: Samba MIT ADDC

Please reduce the acronyms.


David Disseldorp's avatar

While we're there, I think we should probably also change "Active Directory Domain Controller" to "Active Directory compatible domain controller"


Jan Engelhardt's avatar

%package -n libsamba-policy0-python3 +Provides: libsamba-policy0

I do not see the purpose of this. No other package requires the name libsamba-policy0. Likewise, it seems rather strange to masquerade the py3 library like the py2 one - they are still different libs.


David Mulder's avatar

Samba python code is written to be py2/py3 compatible, so pulling in either one version or the other does make perfect sense (especially when the py2 code is deprecated).


Jan Engelhardt's avatar
-%postun -n libsamba-policy0 -p /sbin/ldconfig
+%post   -n libsamba-policy0-python -p /sbin/ldconfig

And I'm not convinced this should be done either. The library filename has not changed, so there is no good reason to deviate from SLPP.

Speaking of rename, if you really want to do it, then a bunch of Obsoletes are missing.


David Mulder's avatar

I get that the obsoletes are missing, but what's wrong with renaming the package? Currently libsamba-policy0 contains a mix of python2 and python3 libraries, which it should not. I think it makes perfect sense to split it in two and rename them both.


Request History
David Disseldorp's avatar

dmdiss created request

- Fix vfs_ceph ftruncate and fallocate handling; (bso#13807); (bsc#1127153).

- Fix update-apparmor-samba-profile script after apparmor switched
to using named profiles. The change is backwards compatible;
(bsc#1126377);

- LoadParm().load_default() fails with "Unable to load default file";
(bsc#1089758);

- Abide by load_printers smb.conf parameter; (bso#13766); (bsc#1124223);


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Ismail Dönmez's avatar

namtrac accepted review


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:F as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:F"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked openSUSE:Factory:Staging:F


Repo Checker's avatar

repo-checker accepted review

Accepted as part of openSUSE:Factory:Staging:F


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by