Overview
Request 685629 accepted
Qt 5.12.2
- Created by Vogtinator
- In state accepted
Request History
Vogtinator created request
Qt 5.12.2
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
jengelh added Vogtinator as a reviewer
%__make
dimstar_suse set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:E
dimstar_suse changed priority to moderate => important
raising priority for openSUSE:Factory:Staging:E
dimstar accepted review
Vogtinator accepted review
dimstar_suse accepted review
ready to accept
dimstar_suse approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory
Please do not add new
%{__make}(or other %__), and instead usemakedirectly.Why is that an issue? I had to manually expand %make_jobs, so it needs to be identical.
It's not really an issue, but
%__makeis alwaysmakeon openSUSE anyway, so it felt kinda redundant.I'll leave the review open for now - but not because of _make. There's a fix for plasma-framework that needs to be merged with Qt 5.12.2. Edits binary files though, so not directly suitable as patch.