Overview

Request 724841 accepted

submitted by snwint via jenkins

Loading...

Jan Engelhardt's avatar

hrrrmpph. This ought to either use a Source URL, or a _service file, but not some random tarball that god knows who how it was created.


Dominique Leuenberger's avatar

wrong sir - this is a nice to have, but the yast team has their entire workflow done perfectly around git and jenkins CI - there is no need for this to change


Steffen Winterfeldt's avatar

What?


Jan Engelhardt's avatar

Whaddaya mean "what?" Source: https://github.com/wfeldt/libx86emu/archive/2.4.tar.gz or a file _service with <services> <service name="tar_scm" mode="disabled"> <param name="scm">git</param> <param name="url">https://github...andsoon</param> <param name="revision">2.4</param> </service> <service name="recompress" mode="disabled"> <param name="file">*.tar</param> <param name="compression">xz</param> </service> <service name="set_version" mode="disabled"/> </services>


Steffen Winterfeldt's avatar

Sorry, you lost me there.

The spec looks (to me) like that of hundreds of other packages and does so for years without complaints. So what exactly is your point?


Jan Engelhardt's avatar

We upped the standards!


Dominique Leuenberger's avatar

as a suggestion - not as a mandate.


Steffen Winterfeldt's avatar

Where is it documented?


Jan Engelhardt's avatar

https://en.opensuse.org/openSUSE:Package_source_verification


Steffen Winterfeldt's avatar

There's nothing in that document requiring changes. Specifically that doc is about ensuring the integrity when dealing with upstream. Not in-house development, as in this case.

In any case, if you think the YaST team's packaging could do with some improvement, it is probably better to talk to the team directly about this and not adding cryptic comments in some random submit request.

Request History
Steffen Winterfeldt's avatar

snwint created request

submitted by snwint via jenkins


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:E as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:E"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:E


Ismail Dönmez's avatar

namtrac accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by