Overview
Request 762843 accepted
use only %license
- Created by alois
- In state accepted
-
Package maintainer:
badshah400
- Supersedes 761837
Before your changes the file had 0 (!) warnings for SLE, as you can check yourself here: https://build.opensuse.org/request/show/761748
Now it has 8 and 2 warnings for SLE 12/15 in RPM Lint (click on the tab RPM Lint), also several warnings for Leap (one of them was caused by the previous request, and 3 more due to this one)
Do you think this change is good?
I've seen in the other request that %license can be removed and the warnings ignored. But why did you remove the group? It triggers lots of warnings and is maybe used for grouping in package managers.
If you could readd the Group (unless there is good reasoning for this) I will accept this ASAP. Also I found out that if you additionally add - 2.11.0 as a suffix to the first line of your changelog then there will be 0 warnings in the Leap RPM linter.
I had done this in my changelog in the following line:
Sat May 18 20:37:18 UTC 2019 - Kira Marie Backes kira@kiralein.de - 2.7.2
And one last thing: Why did you remove the %defattr? There is one warning about this in the linter for SLE_12, not sure if this is also legacy and is no longer needed? ;-)
As I understand as long as older targets just complain, it's better to conform to the latest spec format.
At an rate, Factory reviewers requested those changes.
Where did they request that? Please link that so I can learn and I'll immediately accept it.
I've only seen the other request where they requested removal of the %doc license but I've not seen the request to remove %group or %defattr
%defattr is removed by spec-cleaner and it has been doing so for some time now.
You're right, they didn't ask to remove Group in this case, but they did that on a few occasions. Anyway I restored it, let's see what they say.
Groups are also considered obsolete. If you want more details there was a nice poop storm on the Factory mailing list a couple of months ago when someone edited every package to remove such references:)
That surely is weird, at the bottom of this page you can browse packages by group: https://software.opensuse.org/explore
I have looked it up, there is a pending proposal to use a tag-list but that still works with the Group: field so it should not simply be removed AFAICT
[1] https://en.opensuse.org/openSUSE:Package_group_guidelines
[2] https://lists.opensuse.org/opensuse-factory/2019-10/msg00131.html
You can re-add the Group if you would like. Please see the discussions/drama about Groups on opensuse-factory. I'm not sure if spec-cleaner still removes Group or not, but it should not do that anymore.
