Overview

Request 770466 accepted

- Add -fcommon as there are a lot re-definitions which lead to errors
and compile failures with gcc10 which enables -fno-common by default
bsc#1160383 - acpica fails with -fno-common

- Update to version 20200110

Loading...

Dominique Leuenberger's avatar

Candidate to break the build of virtualbox - testing


Dominique Leuenberger's avatar

Confirmed - by removing acpica from the Staging, virtualbox succeeded again. Can you please take care of that? (either by fixing or linking up with the virtualbox maintainer)


Dominique Leuenberger's avatar

Unignored: returned to active backlog.


Dominique Leuenberger's avatar

CC @lwfinger

Larry, seems our current virtualbox package does not like acpica 20200110

Can you please check if there is any way to make this work?



Larry Finger's avatar

I will see what I can do. I'm not really pleased that every time that package gets updated, virtualbox breaks!


Dominique Leuenberger's avatar

Understandable...

In anzycase: please only submit once the currently pending submission has been accepted. This is in a currently green Staging, waiting for a check-in slot (so, no rush with a fix)

I expect the current submission to be checked in by Thursday evening


Larry Finger's avatar

I saw VB 6.1.2 in the 20200201 snapshot, and then tried a new build using openSUSE:Factory:Staging:M as an alternative project. Unfortunately, that project still uses the old acpica. Which project has the new one?


Dominique Leuenberger's avatar

you can use --alternative-project hardware


Larry Finger's avatar

Now, I am thoroughly confused. Building against that alternative project does not fail. Is it possible that there was an OBS glitch?


Thomas Renninger's avatar

This is because openSUSE:Factory:Staging:M uses gcc10 which enables -fno-common compile option by default. I will supersede this submitrequest having this fixed. Not sure whether this helps for VirtualBox. If, then it may have been built with latest staging projects and acpica failed totally to build and is a virtualbox requirement, right?


Thomas Renninger's avatar

https://build.opensuse.org/request/show/770466


Larry Finger's avatar

Yes, acpica is a VirtualBox requirement as the VB build includes compilation of the BIOS for virtual machines.

The -fno-common option likely explains the difference between the failure with Staging:M and the correct build with acpica version 20200110 using hardware as an alternativeproject. The resulting VB packages work correctly for Windows XP, 7, and 10, FreeDOS, and TW and Leap 15.2 virtual machines.

Thanks for looking into this issue. We might avoid some problems if I were notified the next time that acpica is updated so that I can test against your project before it gets pushed upstream. VB consumes at least 1 hour of OBS time per build, and the failures seem to happen near the end of the build, as Murphy's Law would predict. :) If we coordinate, we might push some of this development time onto my local machines.


Thomas Renninger's avatar

I have added user lwfinger to the acpica devel project as "Reader". Whatever that means, I hope you get notifications on requests, etc.

You may want to use: osc requestmaintainership and friends to remove this one and request reviewer if you do not get notifications.

Thanks for the heads up!

Request History
Thomas Renninger's avatar

trenn created request

- Add -fcommon as there are a lot re-definitions which lead to errors
and compile failures with gcc10 which enables -fno-common by default
bsc#1160383 - acpica fails with -fno-common

- Update to version 20200110


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:M as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:M"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:M"


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:M"


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:F as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:F"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:F"


Dominique Leuenberger's avatar

dimstar accepted review


Oliver Kurz's avatar

okurz-factory accepted review

Staging Project openSUSE:Factory:Staging:F got accepted.


Oliver Kurz's avatar

okurz-factory approved review

Staging Project openSUSE:Factory:Staging:F got accepted.


Oliver Kurz's avatar

okurz-factory accepted request

Staging Project openSUSE:Factory:Staging:F got accepted.

openSUSE Build Service is sponsored by