Overview
Request 823587 revoked
- Created by dsterba
- In state revoked
-
Open review for
dsterba
-
Open review for
factory-staging
Request History
dsterba created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar accepted review
dimstar_suse set openSUSE:Factory:Staging:B as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:B"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:B"
favogt_factory added dsterba as a reviewer
Waiting for clarification
dimstar declined review
favogt wrote 2 days ago
Deleting the [Install] section is a noop, it will only break later calls to "systemctl enable btrfsmaintenance-refresh.service". Existing systems will not be impacted by that. In fact, the removal of After=local-fs.target might even break it.
Is that intentional?
I recommend updating systemd-presets-common-SUSE instead to not explicitly enable btrfsmaintenance-refresh.service.
dimstar declined request
favogt wrote 2 days ago
Deleting the [Install] section is a noop, it will only break later calls to "systemctl enable btrfsmaintenance-refresh.service". Existing systems will not be impacted by that. In fact, the removal of After=local-fs.target might even break it.
Is that intentional?
I recommend updating systemd-presets-common-SUSE instead to not explicitly enable btrfsmaintenance-refresh.service.
dimstar_suse reopened request
Reopened via staging workflow.
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:B"
dimstar_suse declined request
Declined via staging workflow.
dsterba revoked request
Deleting the [Install] section is a noop, it will only break later calls to "systemctl enable btrfsmaintenance-refresh.service". Existing systems will not be impacted by that. In fact, the removal of After=local-fs.target might even break it.
Is that intentional?
I recommend updating systemd-presets-common-SUSE instead to not explicitly enable btrfsmaintenance-refresh.service.
@favogt Removing the install section for a service which should only be enabled by a .timer, .path or similar unit is the right and correct way to do this. This is exactly what systemd is doing, too.
Nobody should enable the btrfsmaintenance-refresh.service, this doesn't make any sense.
You are of course correct that btrfsmaintenance-refresh.service should not get enabled via a preset, too.
The deletion of the [Install] section 1) is a noop for existing installs 2) breaks btrfsmaintenance-refresh.path on new installations without the preset change.
Please read the bug report for the full story: https://bugzilla.opensuse.org/show_bug.cgi?id=1165780#c42