Overview

Request 829090 revoked

A scientific software framework used for data processing, fitting, and analysis

Loading...

Atri Bhattacharya's avatar

Just want to confirm that this has actually been picked up for license review; somehow a previous sr got left off the boat last time. Thanks in advance!


Atri Bhattacharya's avatar

@dimstar This has been held up in License-review purgatory for more than two months since it was submitted. Including my previous attempt (sr#815792, which also hung around for two months or so before you, rather than the license reviewer, commented on its legality) it has now been 4 months plus since I have been trying to get this pkg included in the distro without success. I don't know if even this time it is being actually reviewed or just forgotten about. How is this acceptable?


Dominique Leuenberger's avatar

I am so terrible sorry that this is hanging around for so long.

I just had a look at the legal report - and this looks mostly good - except one file which imho is source for the holdup:

 root-6.22.02/math/mathcore/src/triangle.c
/*  Berkeley, California  94705-1927                                         */
/*  jrs@cs.berkeley.edu                                                      */
/*                                                                           */
/*  This program may be freely redistributed under the condition that the    */
/*    copyright notices (including this entire header and the copyright      */
/*    notice printed when the `-h' switch is selected) are not removed, and  */
/*    no compensation is received.  Private, research, and institutional     */
/*    use is free.  You may distribute modified versions of this code UNDER  */
/*    THE CONDITION THAT THIS CODE AND ANY MODIFICATIONS MADE TO IT IN THE   */
/*    SAME FILE REMAIN UNDER COPYRIGHT OF THE ORIGINAL AUTHOR, BOTH SOURCE   */
/*    AND OBJECT CODE ARE MADE FREELY AVAILABLE WITHOUT CHARGE, AND CLEAR    */
/*    NOTICE IS GIVEN OF THE MODIFICATIONS.  Distribution of this code as    */
/*    part of a commercial system is permissible ONLY BY DIRECT ARRANGEMENT  */
/*    WITH THE AUTHOR.  (If you are not directly supplying this code to a    */
/*    customer, and you are instead telling them how they can obtain it for  */
/*    free, then you are not required to make any arrangement with me.)      */
/*                                                                           */
/*  Hypertext instructions for Triangle are available on the Web at          */

This is non-free - which is a problem


Dominique Leuenberger's avatar

There are actually more files imposing invalid limitations on top of LGPL:

  • root-6.22.02/math/mathmore/inc/Math/KelvinFunctions.h: *** THIS SOFTWARE CAN NOT BE USED FOR COMMERCIAL GAIN. ***
  • root-6.22.02/montecarlo/pythia8/src/TPythia8Decayer.cxx: Permission to use, copy, modify and distribute this software and its documentation strictly for non-commercial purposes is hereby granted

Atri Bhattacharya's avatar

Big thanks again for your response. I will contact upstream about these issues.

In the meanwhile, should I pull this request or let it wait for legal to decline this formally? Would you know if the latter way would make it easier for the review to happen the next time I submit?


Dominique Leuenberger's avatar

I'd let it run - IF legal sees it and then gets a replacement, there is a chance they might remember why they declined it. OTOH, It's an utter shame that there is actually no formal review on this package happening :(


Dominique Leuenberger's avatar

btw:


    Any Proprietary: 12 files
    Any reference local: 14 files
    Apache-2.0: 2728 files
    GPL-2.0+: 1 files
        root-6.22.02/core/clib/res/Demangle.h
    GPL-3.0: 1 files
        root-6.22.02/interpreter/llvm/src/docs/GoldPlugin.rst
    GPL-3.0+: 26 files
    GPL-Unspecified: 22 files
    LGPL Unspecified: 6 files
    LPPL-1.2+: 1 files
        root-6.22.02/documentation/tmva/UsersGuide/myArticle.cls
    OFL-1.1: 126 files
    any reference local: 24 files 

57+License: LGPL-2.1-or-later seems quite inaccurate


Atri Bhattacharya's avatar

@dimstar Thanks again. I don't, however, see the large number of Apache-2.0 licensed files in the sources. I'm working on all the rest with upstream.


Dominique Leuenberger's avatar

root-6.22.02/documentation/doxygen/mathjax/mathjax/config/AM_HTMLorMML.processed.js

Seems mostly do be documentation related, doxygen stuff

Request History
Atri Bhattacharya's avatar

badshah400 created request

A scientific software framework used for data processing, fitting, and analysis


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar_suse added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:85"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:85"


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:adi:85"


Dominique Leuenberger's avatar

dimstar_suse added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:67"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:67"


Saul Goodman's avatar

licensedigger declined review

@dec16180 declined the legal report with the following comment: b'The packages contains a non-commercial license \r\nSee. root-6.22.02/math/mathcore/src/triangle.c or root-6.22.02/fonts/* '


Saul Goodman's avatar

licensedigger declined request

@dec16180 declined the legal report with the following comment: b'The packages contains a non-commercial license \r\nSee. root-6.22.02/math/mathcore/src/triangle.c or root-6.22.02/fonts/* '


Dominique Leuenberger's avatar

dimstar_suse reopened request

Reopened via staging workflow.


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:adi:67"


Dominique Leuenberger's avatar

dimstar_suse declined request

Declined via staging workflow.


Atri Bhattacharya's avatar

badshah400 revoked request

openSUSE Build Service is sponsored by