Overview

Request 840321 accepted

thanks to Stefan Brüns

Loading...

Dominique Leuenberger's avatar

5+- avoid using _service as it is forbidden in Factory

Is inaccurate - type local, disabled and buildtime are allowed.


Matthias Mailänder's avatar

It was a needless use of _service probably pre-dating the sourceURL era.


Stefan Brüns's avatar

This should also be cleaned up:

  • allegro is not used at all
  • default %defattr is deprecated
  • BuildRoot is deprecated
  • DATE mangling is deprecated

Dominique Leuenberger's avatar
found conflict of kdesdk-scripts-20.08.1-1.1.x86_64 with makeobj-121.0-3.1.x86_64
  /usr/bin/makeobj

Dominique Leuenberger's avatar
found conflict of kdesdk-scripts-20.08.1-1.1.x86_64 with makeobj-121.0-3.1.x86_64
  /usr/bin/makeobj

CC @luca_b and @cgiboudeaux and @Vogtinator


Stefan Brüns's avatar

Possible solutions:

  1. Rename makeobj from kdesdk-scripts - not really possible, as it is also called from other scripts and e.g. as a command from vim, see https://invent.kde.org/search?search=makeobj&project_id=2491&group_id=1558

  2. Rename makeobj from simutrans - either makeobj-simutrans or simutrans-makeobj. Only reference to the binary name is the manpage, and various places on the internet

  3. Just conflicting the two packages - not nice for people wanting both, though that is probably rare.

I would vote for renaming the binary to 'makeobj-simutrans'. That makes it easier to find by command completion.

Debian installs the binary under /usr/games/makeobj.


Request History
Matthias Mailänder's avatar

Mailaender created request

thanks to Stefan Brüns


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Richard Brown's avatar

RBrownSUSE added openSUSE:Factory:Staging:adi:22 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:22"


Richard Brown's avatar

RBrownSUSE accepted review

Picked "openSUSE:Factory:Staging:adi:22"


Ismail Dönmez's avatar

namtrac accepted review


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:22 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:22 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:22 got accepted.

openSUSE Build Service is sponsored by