Overview

Request 873236 superseded

- Spec file fixes and cleanups
+ disable pcp-export-zabbix-agent to avoid conflicting /etc/zabbix/
ownership.
+ fix unversioned Provides
+ remove unused python2 build logic and unconditionally enable python3
+ 0009-remove-rundir-install.patch
- Add SUSE specific dejavu-fonts dependency for pcp-gui sans

- Drop unnecessary %pre/%post recursive chown calls; (bsc#1152533)
- Changelog for patches carried as part of 5.2.2 source tarball:
+ build-drop-old-config-file-transition-code-from-rpm-.patch
+ 0007-pmdas-perf-Add-cpunumber-option-for-dynamic-perf-eve.patch
+ 0008-pmdas-perf-Add-support-for-hv_24x7-nest-events-on-mu.patch
+ 0009-qa-perfevent-Test-hv_24x7-events-on-multinode.patch

- Upgrade to 5.2.2; (jsc#SLE-16929)
+ improvements to client tools and utilities
+ new pmdabpftrace monitoring agent
+ pmdaperfevent enhancements
+ pmproxy, libpcp_web and libpcp hardening and improvements
+ assorted bug fixes
+ obsolete pcp-manager discovery service, now provided by pmfind
+ improved FHS compliance
- Remove upstreamed:
+ 0001-Add-missing-includes-in-Qt-5.15-beta2.patch
- Rebase against upstream (faeb2507f):
+ 0001-Install-libraries-without-exec-permission.patch
- Fix build with -fno-common; (bsc#1160411)
- Merge upstream build-time tmpdir fixes
+ 0007-pmns-Make-drop-duplicate-if-else.patch

Dominique Leuenberger's avatar
Dominique Leuenberger (dimstar) -
reviewer

Introduces a new build cycle

ffmpeg-4, gstreamer-plugins-bad, libquicktime, libvirt, pcp, samba, Wireshark

Dominique Leuenberger's avatar
Dominique Leuenberger (dimstar) -
reviewer

The change comes from the new libvirt based dependency

David Disseldorp's avatar
David Disseldorp (dmdiss) -
author source maintainer

I see a few options here, with the most obvious being:

  1. drop the libvirt monitoring agent
  2. rework pcp to not require build-time presence of python libraries
  3. disable Samba's ctdb-pcp-pmda

I'll go with option (1) for now and raise this upstream.

Jan Engelhardt's avatar
Jan Engelhardt (jengelh) -
reviewer

samba depending on ffmpeg-4? that ain't sounding right.

David Disseldorp's avatar
David Disseldorp (dmdiss) -
author source maintainer

libsmbclient I'd assume (edit: I read that the other way around - ffmpeg depends on libsmbclient)

Dominique Leuenberger's avatar
Dominique Leuenberger (dimstar) -
reviewer

other way around: the build result of samba is consumed to build ffmpeg4

osc buildinfo openSUSE:Factory ffmpeg-4 standard x86_64 -d | grep libsmbclient
…
added libsmbclient-devel@openSUSE:Factory/standard because of (direct):pkgconfig(smbclient)
…
Dominique Leuenberger's avatar
Dominique Leuenberger (dimstar_suse) -
reviewer target maintainer

Awaiting solution for the build cycle - cycles are a no-go

Ismail Dönmez's avatar
Ismail Dönmez (namtrac) -

@dmdiss Also see https://en.opensuse.org/openSUSE:Package_dependencies#Renaming_a_package for the correct Provides usage.

David Disseldorp's avatar
David Disseldorp (dmdiss) -
author source maintainer

I did an initial review,

Thanks for the feedback, Ismail.

- Wrong Provides
+Provides: pcp-pmda-prometheus < 5.0.0

Provides should have a fixed version, you also have non-versioned provides elsewhere in the spec file, please fix those too.

Okay, will do.

- __python2 usage should be dropped, use python2 please

Hmm, this is in the upstream spec, which I tray to avoid diverging from. I suppose I can here if it's required.

- Don't own directories belonging to other packages

# FIXME: %{_sysconfdir}/zabbix is provided by zabbix-server
+%dir %{_sysconfdir}/zabbix
+%dir %{_sysconfdir}/zabbix/zabbix_agentd.d

What is the correct way to do this? I added the zabbix-server dependency (and only install zabbix_agentd.d/zbxpcp.conf), but still had rpmlint throw errors.

Dominique Leuenberger's avatar
Dominique Leuenberger (dimstar) -
reviewer
  • __python2 usage should be dropped, use python2 please

In fact : python2 is EOL; do not use it. use python3

David Disseldorp's avatar
David Disseldorp (dmdiss) -
author source maintainer 
__python2 usage should be dropped, use python2 please

In fact : python2 is EOL; do not use it. use python3

We already disable py2 packaging. This is more cruft inherited from the upstream spec. I'll remove it if it's important here.

Dominique Leuenberger's avatar
Dominique Leuenberger (dimstar) -
reviewer

I care mostly if the python2 interpreter is still in use or not; if not, then I do not mind the cruft in the spec (you have to maintain it; so if it's ok for you, it's ok for me)

David Disseldorp's avatar
David Disseldorp (dmdiss) -
author source maintainer

Thanks for the feedback. I'm not sure why I initially added the _libexecdir redefine. Will drop, test and resubmit.

Request History
David Disseldorp's avatar

dmdiss created request

- Spec file fixes and cleanups
+ disable pcp-export-zabbix-agent to avoid conflicting /etc/zabbix/
ownership.
+ fix unversioned Provides
+ remove unused python2 build logic and unconditionally enable python3
+ 0009-remove-rundir-install.patch
- Add SUSE specific dejavu-fonts dependency for pcp-gui sans

- Drop unnecessary %pre/%post recursive chown calls; (bsc#1152533)
- Changelog for patches carried as part of 5.2.2 source tarball:
+ build-drop-old-config-file-transition-code-from-rpm-.patch
+ 0007-pmdas-perf-Add-cpunumber-option-for-dynamic-perf-eve.patch
+ 0008-pmdas-perf-Add-support-for-hv_24x7-nest-events-on-mu.patch
+ 0009-qa-perfevent-Test-hv_24x7-events-on-multinode.patch

- Upgrade to 5.2.2; (jsc#SLE-16929)
+ improvements to client tools and utilities
+ new pmdabpftrace monitoring agent
+ pmdaperfevent enhancements
+ pmproxy, libpcp_web and libpcp hardening and improvements
+ assorted bug fixes
+ obsolete pcp-manager discovery service, now provided by pmfind
+ improved FHS compliance
- Remove upstreamed:
+ 0001-Add-missing-includes-in-Qt-5.15-beta2.patch
- Rebase against upstream (faeb2507f):
+ 0001-Install-libraries-without-exec-permission.patch
- Fix build with -fno-common; (bsc#1160411)
- Merge upstream build-time tmpdir fixes
+ 0007-pmns-Make-drop-duplicate-if-else.patch

Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources

Factory Auto's avatar

factory-auto accepted review

Check script succeeded

Output of check script (non-fatal):
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_cc_by}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_mit}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_cc_by}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_cc_by}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_cc_by}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_lgplv21plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_mit}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_lgplv2plus}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_cc_by}'
Unknown license '%{license_gplv2plus}'
Unknown license '%{license_cc_by}'

Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:N as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:N"

Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:N"

Saul Goodman's avatar

licensedigger accepted review

ok

Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"

Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:N"

David Disseldorp's avatar

dmdiss superseded request

superseded by 873360

openSUSE Build Service is sponsored by
Places