Request 878534 (accepted)

Overview

Request 878534 accepted

No description set

Created by rwill about 3 years ago
In state accepted

Submit gnu-efi

Comments for request 878534 7

Dominique Leuenberger (dimstar) - about 3 years ago

reviewer

breaks systemd

[   82s] ../src/boot/efi/console.c:12: warning: "EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL_GUID" redefined
[   82s]    12 | #define EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL_GUID \
[   82s]       | 
[   82s] In file included from /usr/include/efi/efi.h:63,
[   82s]                  from ../src/boot/efi/console.c:3:
[   82s] /usr/include/efi/eficonex.h:22: note: this is the location of the previous definition
[   82s]    22 | #define EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL_GUID \
[   82s]       | 
[   82s] ../src/boot/efi/console.c:27:3: error: conflicting types for ‘EFI_KEY_STATE’
[   82s]    27 | } EFI_KEY_STATE;
[   82s]       |   ^~~~~~~~~~~~~

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:H/systemd/standard/x86_64

Dominique Leuenberger (dimstar) - about 3 years ago

reviewer

CC @fbui - gnu-efi and systemd do not play nice together here

Dominique Leuenberger (dimstar_suse) - about 3 years ago

reviewer target maintainer

awaiting discussion gnu-efi vs systemd

Raymund Will (rwill) - about 3 years ago

author source maintainer

From my PoV it should be possible for systemd to tolerate newer gnu-efi releases (like in guarding potentially conflicting definitions with #ifdef or some such)...

Franck? Gary?

Gary Ching-Pang Lin (gary_lin) - about 3 years ago

source maintainer

Simple Text Input Ex Protocol was newly added into 3.0.13, and it's not feasible to disable it completely in gnu-efi. We would need some change in systemd.

Gary Ching-Pang Lin (gary_lin) - about 3 years ago

source maintainer

It's fixed in systemd upstream. https://github.com/systemd/systemd/commit/95ba433a5f34baf92921fb58051bc8241f908c0e

Dominique Leuenberger (dimstar_suse) - about 3 years ago

reviewer target maintainer

Unignored: returned to active backlog.