Thanks Andreas for the update! I've noticed that as part of the update you've overhauled the specfile. What's the rationale behind that? I agree that fixing some hardcoded pathnames to proper variables is desirable, changes like %_libdir -> %{_libdir} probably as well (although I'm not sure why you've changed %{find_lang} to %find_lang). But why did you reorder the dependencies, conditions etc.? Also I'm not sure why you've deleted some %defattr calls? Finally, your changes don't seem to be equivalent as SLE12-based builds fail now...

Andreas Stieger (AndreasStieger) - over 3 years ago

author

Uh this is the standard run of spec-cleaner which does all of the above.

@jankara: review reminder