Request 882556 (revoked)

This request supersedes: request 882524 (Show diff)

Overview

Request 882556 revoked

- Set GO111MODULE=auto to build with go1.16+
* Default changed to GO111MODULE=on in go1.16
* Set temporarily until using upstream release with go.mod
* Add BuildRequires: golang(API) >= 1.13 recommended dependency expression

Created by RBrownSUSE about 3 years ago
In state revoked
Supersedes 882524

Submit cilium

Comments for request 882556 4

Dominique Leuenberger (dimstar) - about 3 years ago

reviewer

That fix 'to make it build with g01.16' seems incomplete:

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:M/cilium/standard/x86_64

Dominique Leuenberger (dimstar) - about 3 years ago

reviewer

[   59s] + make -C daemon CILIUM_ENVOY_SHA=6d0a55191baac475046d13e52ffe330f3a56a4ce/1.14.4/Modified/DEBUG/BoringSSL
[   59s] make: Entering directory '/home/abuild/rpmbuild/BUILD/go/src/github.com/cilium/cilium/daemon'
[   59s] cat: /home/abuild/rpmbuild/BUILD/go/src/github.com/cilium/cilium/GIT_VERSION: No such file or directory
[   59s] CGO_ENABLED=0 go build -mod=vendor -ldflags '-X "github.com/cilium/cilium/pkg/version.ciliumVersion=1.8.5 " -s -w -X "github.com/cilium/cilium/pkg/envoy.RequiredEnvoyVersionSHA=6d0a55191baac475046d13e52ffe330f3a56a4ce/1.14.4/Modified/DEBUG/BoringSSL" -X "github.com/cilium/cilium/pkg/datapath/loader.DatapathSHA=18c4d775a921406cad71989cc3f2f7fec806d932" '  -o cilium-agent
[  121s] ln -f -s cilium-agent cilium-node-monitor || cp cilium-agent cilium-node-monitor;
[  121s] make: Leaving directory '/home/abuild/rpmbuild/BUILD/go/src/github.com/cilium/cilium/daemon'
[  121s] + make precheck
[  123s] ineffassign .
[  123s] -: no Go files in /home/abuild/rpmbuild/BUILD/go/src/github.com/cilium/cilium
[  123s] ineffassign: error during loading
[  123s] make: *** [Makefile:415: ineffassign] Error 1
[  123s] error: Bad exit status from /var/tmp/rpm-tmp.5NCX0Q (%build)

Dominique Leuenberger (dimstar) - almost 3 years ago

reviewer

ineffassign update contains a breaking change, resulting in what we see:

https://github.com/gordonklaus/ineffassign/pull/51

before, ineffassign . was recursive, unless started with -n. Newly, it is only recursive when using ineffassign ./...

This is what makes cilium build brak (i.e.no go files in ., and no recursion, so no go files found)

There are two ways out:

Do not run ineffassign'; in any case, this sounds more like a CI feature than a distro build package check. (patch Makefile, remove ineffassign from precheck and also in spec)
Run ineffassign ./...: this might well show up more issues then; a quick run here reported > 1000 'errors' (which does, as said above, more sound like a CI test, no a packaging test)

CC @mrostecki, @dirkmueller

Dominique Leuenberger (dimstar) - almost 3 years ago

reviewer

I created an SR for option 1: sr#893737

This sounds perfectly legit, as cilium no longer runs ineffassign as part of the Makefile in git master already (upstream commit e75d4a6e5fdc17d446f7e75170f2594f2157b093 )