Overview

Request 912438 accepted

- Update to version 2.0.0
- Remove NIS+ code
- Bump soversion to 3

Loading...

Jan Engelhardt's avatar

I have reason to believe this should be "network services library" not "network support library", based upon Solaris documentation (which is where glibc's NIS originally came out of).


Thorsten Kukuk's avatar
author source maintainer

You are completely wrong. The Solaris code was not open source, so couldn't be used and thus this is not where glibc's NIS originally come out of. glibc's NIS come originally from my libnis library, which got renamed for better "compatibility" with existing open source packages during integration, as their configure scripts looked for libnsl already. Else the content of libnsl from Solaris and libnsl from glibc have nearly nothing common, especially since glibc's libnsl does not contain the "network support functions" Solaris libnsl had. This was always core functionality of glibc itself.


Richard Brown's avatar

Jan, it's typically bad manners for a downstream reviewer to question the naming of an upstream developers baby.. and it's even worse to cast aspersions as to an origin of someones code..do you have any evidence to challenge the source of kukuk's code?


Jan Engelhardt's avatar

I was not and am not aware that any particular NSL implementation is using the acronym but with a different long name. Neither the source code repository of glibc nor github.com/thkukuk/libnsl mention "Network Support Library" in any form I can discover.

Therefore, it was fair to work with the assumption that writing "Network Support Library" into the specfile was a case of someone simply misremembering what the NSL acronym expands to, and, based on that, helping them out by providing alternate, more widely recognized, reading(s) of the acronym.

Think of "MP3". Ask people on the street what MP3 stands for, and there may be a sizable percentage that couldn't answer it correctly even though they make use of it all day. Then you tell them and all is good.

At no point did I intend to imply that the thkukuk-libnsl code is sourced from Sun. But there is also ample reason that it is:

  1. its toplevel readme says:
This code was formerly part of glibc, […]
  1. https://github.com/thkukuk/libnsl/blob/master/src/yp_xdr.c and glibc's copy of yp_xdr.c also says:
 * Copyright (c) 2010, Oracle America, Inc.
(terms like a BSD-3-Clause)

Without further analysis or proof at this time for brevity reasons, I will assume everyone is with me on that Oracle did in fact acquire Sun.

  1. yp_xdr.c in glibc, of sufficient age (ca. 2010), says:
/*
 * Sun RPC is a product of Sun Microsystems, Inc. and is provided for
 * unrestricted use provided that this legend is included on all tape
[…]

Without further analysis at this time for brevity reasons, I'll take this expression of licensing terms as an indicator that it derives from Sun code.


Thorsten Kukuk's avatar
author source maintainer

How long did you search to find the single autogenerated files to prove your claims by ignoring all the other files?

You should asked yourself whom to trust more: somebody who wrote the code during the last 25 years or yourself without any clue about the code history.


Thorsten Kukuk's avatar
author source maintainer

"Therefore, it was fair to work with the assumption that writing "Network Support Library" into the specfile was a case of someone simply misremembering what the NSL acronym expands to, and, based on that, helping them out by providing alternate, more widely recognized, reading(s) of the acronym."

The assumption that the author of the code does not know the name of his project is by no means a fair assumption.

Request History
Thorsten Kukuk's avatar

kukuk created request

- Update to version 2.0.0
- Remove NIS+ code
- Bump soversion to 3


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Richard Brown's avatar

RBrownSUSE set openSUSE:Factory:Staging:A as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:A"


Richard Brown's avatar

RBrownSUSE accepted review

Picked "openSUSE:Factory:Staging:A"


Simon Lees's avatar

simotek accepted review

Everything seems fine here


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:A got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:A got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:A got accepted.

openSUSE Build Service is sponsored by